TD-5727

AnjuJose011 · AnjuJose011 · commit 19d6cfc693bf · 2025-07-10T07:52:10.000+01:00
diff --git a/LearningHub.Nhs.WebUI/Controllers/ContributeController.cs b/LearningHub.Nhs.WebUI/Controllers/ContributeController.cs
@@ -171,8 +171,8 @@ public async Task<IActionResult> CreateVersion(int resourceId)
         [Route("my-contributions/{selectedTab}/{catalogueId}/{nodeId}")]
         public async Task<IActionResult> MyContributions()
         {
-            bool usergroup = await this.userGroupService.UserHasCatalogueContributionPermission();
-            if ((this.User.IsInRole("ReadOnly") || this.User.IsInRole("BasicUser")) || (!usergroup && (!await this.resourceService.UserHasPublishedResourcesAsync())))
+            bool catalogueContributionPermission = await this.userGroupService.UserHasCatalogueContributionPermission();
+            if ((this.User.IsInRole("ReadOnly") || this.User.IsInRole("BasicUser")) || (!catalogueContributionPermission && (!await this.resourceService.UserHasPublishedResourcesAsync())))
             {
                 return this.RedirectToAction("AccessDenied", "Home");
             }

Original file line number	Diff line number	Diff line change
`@@ -171,8 +171,8 @@ public async Task<IActionResult> CreateVersion(int resourceId)`
`171`	`171`	`[Route("my-contributions/{selectedTab}/{catalogueId}/{nodeId}")]`
`172`	`172`	`public async Task<IActionResult> MyContributions()`
`173`	`173`	`{`
`174`		`- bool usergroup = await this.userGroupService.UserHasCatalogueContributionPermission();`
`175`		`- if ((this.User.IsInRole("ReadOnly") \|\| this.User.IsInRole("BasicUser")) \|\| (!usergroup && (!await this.resourceService.UserHasPublishedResourcesAsync())))`
	`174`	`+ bool catalogueContributionPermission = await this.userGroupService.UserHasCatalogueContributionPermission();`
	`175`	`+ if ((this.User.IsInRole("ReadOnly") \|\| this.User.IsInRole("BasicUser")) \|\| (!catalogueContributionPermission && (!await this.resourceService.UserHasPublishedResourcesAsync())))`
`176`	`176`	`{`
`177`	`177`	`return this.RedirectToAction("AccessDenied", "Home");`
`178`	`178`	`}`