Merge pull request #1452 from TechnologyEnhancedLearning/TD-6284-LMS-Commit/ESR-external-access/Resource-Details-Optimizations

AnjuJose011 · web-flow · commit 1aaf34d91552 · 2025-09-30T13:16:17.000+01:00
performance optimization for GetByResourceVersionIdAsync
diff --git a/OpenAPI/LearningHub.Nhs.OpenApi.Repositories/Repositories/Resources/ScormResourceVersionRepository.cs b/OpenAPI/LearningHub.Nhs.OpenApi.Repositories/Repositories/Resources/ScormResourceVersionRepository.cs
@@ -46,9 +46,11 @@ public async Task<ScormResourceVersion> GetByIdAsync(int id)
         public async Task<ScormResourceVersion> GetByResourceVersionIdAsync(int resourceVersionId, bool includeDeleted = false)
         {
             return await DbContext.ScormResourceVersion
+            .Where(r => r.ResourceVersionId == resourceVersionId && (includeDeleted || !r.Deleted))
             .Include(r => r.File)
             .Include(r => r.ScormResourceVersionManifest)
-            .AsNoTracking().FirstOrDefaultAsync(r => r.ResourceVersionId == resourceVersionId && (includeDeleted || !r.Deleted));
+            .AsNoTracking()
+            .FirstOrDefaultAsync();
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -46,9 +46,11 @@ public async Task<ScormResourceVersion> GetByIdAsync(int id)`
`46`	`46`	`public async Task<ScormResourceVersion> GetByResourceVersionIdAsync(int resourceVersionId, bool includeDeleted = false)`
`47`	`47`	`{`
`48`	`48`	`return await DbContext.ScormResourceVersion`
	`49`	`+ .Where(r => r.ResourceVersionId == resourceVersionId && (includeDeleted \|\| !r.Deleted))`
`49`	`50`	`.Include(r => r.File)`
`50`	`51`	`.Include(r => r.ScormResourceVersionManifest)`
`51`		`- .AsNoTracking().FirstOrDefaultAsync(r => r.ResourceVersionId == resourceVersionId && (includeDeleted \|\| !r.Deleted));`
	`52`	`+ .AsNoTracking()`
	`53`	`+ .FirstOrDefaultAsync();`
`52`	`54`	`}`
`53`	`55`
`54`	`56`	`/// <summary>`