Not nullable should be empty list

Author: Phil-NHS

OpenAPI/LearningHub.Nhs.OpenApi.Models/ViewModels/ResourceMetadataViewModel.cs

@@ -34,7 +34,7 @@ public ResourceMetadataViewModel(
             string resourceType,
             int? majorVersion,
             decimal rating,
-            List<MajorVersionIdActivityStatusDescription>? userSummaryActivityStatuses)
+            List<MajorVersionIdActivityStatusDescription> userSummaryActivityStatuses)
         {
             this.ResourceId = resourceId;
             this.Title = title;
@@ -85,6 +85,6 @@ public ResourceMetadataViewModel(
         /// <summary>
         /// Gets or sets <see cref="UserSummaryActivityStatuses"/>.
         /// </summary>
-        public List<MajorVersionIdActivityStatusDescription>? UserSummaryActivityStatuses { get; set; }
+        public List<MajorVersionIdActivityStatusDescription> UserSummaryActivityStatuses { get; set; }
     }
 }

OpenAPI/LearningHub.Nhs.OpenApi.Models/ViewModels/ResourceReferenceWithResourceDetailsViewModel.cs

@@ -17,9 +17,11 @@ public class ResourceReferenceWithResourceDetailsViewModel
         /// <param name="description"><see cref="Description"/>.</param>
         /// <param name="catalogueViewModel"><see cref="Catalogue"/>.</param>
         /// <param name="resourceType"><see cref="ResourceType"/>.</param>
+        /// <param name="majorVersion"></param>
         /// <param name="rating"><see cref="Rating"/>.</param>
         /// <param name="link"><see cref="Link"/>.</param>
-        public ResourceReferenceWithResourceDetailsViewModel( // qqqq may need major version id adding
+        /// <param name="userSummaryActivityStatuses"></param>
+        public ResourceReferenceWithResourceDetailsViewModel(
             int resourceId,
             int refId,
             string title,
@@ -29,7 +31,7 @@ public ResourceReferenceWithResourceDetailsViewModel( // qqqq may need major ver
             int? majorVersion,
             decimal rating,
             string link,
-            List<MajorVersionIdActivityStatusDescription>? userSummaryActivityStatuses)
+            List<MajorVersionIdActivityStatusDescription> userSummaryActivityStatuses)
         {
             this.ResourceId = resourceId;
             this.RefId = refId;
@@ -94,6 +96,6 @@ public ResourceReferenceWithResourceDetailsViewModel( // qqqq may need major ver
         /// <summary>
         /// Gets <see cref="UserSummaryActivityStatuses"/>.
         /// </summary>
-        public List<MajorVersionIdActivityStatusDescription>? UserSummaryActivityStatuses { get; }
+        public List<MajorVersionIdActivityStatusDescription> UserSummaryActivityStatuses { get; }
     }
 }