Skip to content

Commit 272c41b

Browse files
Merge pull request #351 from TechnologyEnhancedLearning/Develop/fixes/TD-3707-Assessments-you-jump-all-over-the-page-after-submitting-answers
TD-3707: fixed question focus issue in assessments
2 parents a4c92a1 + 007d3aa commit 272c41b

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

LearningHub.Nhs.WebUI/Scripts/vuesrc/resource/CaseOrAssessmentResource.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@
288288
return questionBlockOrder - pageBreakOrder - 1;
289289
},
290290
setQuestionInFocus(pageIndex: number, value: number, remove: boolean) {
291-
if ((remove && this.questionsInFocus[pageIndex] === value) || this.canContinue) {
291+
if ((remove && this.questionsInFocus[pageIndex] === value)) {
292292
this.questionsInFocus[pageIndex] = undefined;
293293
} else {
294294
this.questionsInFocus[pageIndex] = value;

LearningHub.Nhs.WebUI/Scripts/vuesrc/resource/blocks/BlocksView.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,9 @@
9393
requestAnimationFrame(this.applyUpdates);
9494
},
9595
questionInFocus() {
96-
const question = this.blocks[this.questionInFocus];
97-
if (question && this.allQuestionsAnswered) {
98-
const element = document.getElementById(this.generateId(question.order - this.blocks[0].order));
96+
const lastAnsweredIndex = this.blocks.findIndex(block => block.blockType === BlockTypeEnum.Question && this.pagesProgress[this.blocks.indexOf(block)]);
97+
if (lastAnsweredIndex !== -1) {
98+
const element = document.getElementById(this.generateId(lastAnsweredIndex));
9999
if (element) {
100100
setTimeout(() => {
101101
element.scrollIntoView({ behavior: "smooth" });

0 commit comments

Comments
 (0)