Skip to content

Commit 399c3b5

Browse files
authored
Merge pull request #1337 from TechnologyEnhancedLearning/Develop/fix/TD-5836/ArticileFilesize
TD-5836-Article attachment filesize incorrect -ResourseDeatilsPage
2 parents d76402c + 9a1232b commit 399c3b5

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

LearningHub.Nhs.WebUI/Controllers/ContributeController.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,9 @@ public async Task<FileUploadResult> UploadArticleFile(IFormCollection inputForm)
202202
var file = inputForm.Files[0];
203203
int.TryParse(inputForm["resourceVersionId"], out int resourceVersionId);
204204
int.TryParse(inputForm["changeingFileId"], out int existingFileId);
205+
int.TryParse(inputForm["fileSize"], out int fileSize);
205206
var currentUserId = this.User.Identity.GetCurrentUserId();
206-
return await this.contributeService.ProcessArticleFileAsync(resourceVersionId, file, existingFileId, currentUserId);
207+
return await this.contributeService.ProcessArticleFileAsync(resourceVersionId, file, fileSize, existingFileId, currentUserId);
207208
}
208209

209210
/// <summary>

LearningHub.Nhs.WebUI/Interfaces/IContributeService.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,11 @@ public interface IContributeService
8787
/// </summary>
8888
/// <param name="resourceVersionId">Resource version id.</param>
8989
/// <param name="file">File.</param>
90+
/// <param name="fileSize">fileSize.</param>
9091
/// <param name="changeingFileId">Changing file id.</param>
9192
/// <param name="currentUserId">Current user id.</param>
9293
/// <returns>A <see cref="Task{TResult}"/> representing the result of the asynchronous operation.</returns>
93-
Task<FileUploadResult> ProcessArticleFileAsync(int resourceVersionId, IFormFile file, int changeingFileId, int currentUserId);
94+
Task<FileUploadResult> ProcessArticleFileAsync(int resourceVersionId, IFormFile file, int fileSize,int changeingFileId, int currentUserId);
9495

9596
/// <summary>
9697
/// The ProcessResourceAttachedFileAsync.

LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute/ContentCommon.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@
243243
</div>
244244
</div>
245245

246-
<catalogue-select v-if="resourceCatalogueCount>1 && showCatalogueSelect" v-model.number="resourceCatalogueId" @input="catalogueSelected"></catalogue-select>
246+
<catalogue-select v-if="resourceCatalogueCount>0 && showCatalogueSelect" v-model.number="resourceCatalogueId" @input="catalogueSelected"></catalogue-select>
247247
</div>
248248
</template>
249249

LearningHub.Nhs.WebUI/Services/ContributeService.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -382,10 +382,11 @@ public async Task<FileChunkDetailViewModel> GetFileChunkDetail(int fileChunkDeta
382382
/// </summary>
383383
/// <param name="resourceVersionId">The resourceVersionId<see cref="int"/>.</param>
384384
/// <param name="file">The file<see cref="IFormFile"/>.</param>
385+
/// <param name="fileSize">The fileSize<see cref="int"/>.</param>
385386
/// <param name="existingFileId">The existingFileId<see cref="int"/>.</param>
386387
/// <param name="currentUserId">The currentUserId<see cref="int"/>.</param>
387388
/// <returns>The <see cref="Task{FileUploadResult}"/>.</returns>
388-
public async Task<FileUploadResult> ProcessArticleFileAsync(int resourceVersionId, IFormFile file, int existingFileId, int currentUserId)
389+
public async Task<FileUploadResult> ProcessArticleFileAsync(int resourceVersionId, IFormFile file, int fileSize, int existingFileId, int currentUserId)
389390
{
390391
var filelocation = string.Empty;
391392
string extension = Path.GetExtension(file.FileName).Replace(".", string.Empty);
@@ -415,7 +416,7 @@ public async Task<FileUploadResult> ProcessArticleFileAsync(int resourceVersionI
415416
FileTypeId = fileType == null ? 0 : fileType.Id,
416417
FileName = file.FileName,
417418
FilePath = filelocation,
418-
FileSize = (int)(file.Length / 1000),
419+
FileSize = (int)(fileSize / 1000),
419420
ReplacedFileId = existingFileId,
420421
});
421422

@@ -425,7 +426,7 @@ public async Task<FileUploadResult> ProcessArticleFileAsync(int resourceVersionI
425426
ResourceVersionId = resourceVersionId,
426427
FileName = file.FileName,
427428
FileTypeId = fileType == null ? 0 : fileType.Id,
428-
FileSizeKb = (int)(file.Length / 1000),
429+
FileSizeKb = (int)(fileSize / 1000),
429430
Invalid = false,
430431
};
431432
}

0 commit comments

Comments
 (0)