Merge pull request #719 from TechnologyEnhancedLearning/Develop/Fixes/TD-4072-DIG201-Content-has-heading-markup,-but-is-not-a-heading

TD-4072: DIG201 Content has heading markup, but is not a heading issue fixed

Author: ArunimaGeorge

LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute-resource/ContributeAuthorsTab.vue

@@ -31,6 +31,7 @@
                                         v-bind:inputId="authorName"
                                         v-bind:characterLimit="100"
                                         v-bind:disabled="authorIsContributor"
+                                        :showTitle="false"
                                         class="mt-25">
                             <template v-slot:description>
                                 <label :for="'authorName'" class="mb-0">Author name</label>
@@ -39,6 +40,7 @@
                         <CharacterCount v-model="authorOrganisation"
                                         v-bind:inputId="authorOrganisation"
                                         v-bind:characterLimit="100"
+                                        :showTitle="false"
                                         class="mt-15">
                             <template v-slot:description>
                                 <label :for="'authorOrganisation'" class="mb-0">Organisation</label>
@@ -47,6 +49,7 @@
                         <CharacterCount v-model="authorRole"
                                         v-bind:inputId="authorRole"
                                         v-bind:characterLimit="100"
+                                        :showTitle="false"
                                         class="mt-15">
                             <template v-slot:description>
                                 <label :for="'authorRole'" class="mb-0">Role</label>

LearningHub.Nhs.WebUI/Scripts/vuesrc/globalcomponents/CharacterCount.vue

@@ -41,7 +41,7 @@
                         'character-count-component--error': (hasOtherError),
                         'character-count-component--large': (size === 'large'),
                        }">
-        <h2 class="nhsuk-heading-l">
+        <h2 class="nhsuk-heading-l" v-if="showTitle">
             <slot name="title"></slot>
         </h2>
         <div class="mb-2">
@@ -98,6 +98,10 @@
             disabled: Boolean,
             focusOnLoad: Boolean,
             size: String,
+            showTitle: {
+                default: true,
+                type: Boolean  
+            }
         },
         data() {
             return {

LearningHub.Nhs.WebUI/Scripts/vuesrc/globalcomponents/CharacterCountWithSaveCancelButtons.vue

@@ -3,6 +3,7 @@
         <CharacterCount v-model="inputValue"
                         v-bind:characterLimit="characterLimit"
                         v-bind:size="size"
+                        :showTitle="false"
                         focusOnLoad></CharacterCount>
         <div class="d-inline-flex">
             <Button v-on:click="save"

LearningHub.Nhs.WebUI/Views/Shared/Tenant/LearningHub/_Layout.cshtml

@@ -71,11 +71,13 @@
         <partial name="_CookieConsentPartial" />
     </div>
 
-    <header class="nhsuk-header" role="banner" id="header">
+    <header class="nhsuk-header" role="banner">
     <div id="content-header">
         <partial name="~/Views/Shared/_NavPartial.cshtml" />
     </div>
     </header>
+    <div id="header">
+        </div>
 
     <div class="nhsuk-width-container app-width-container beta-banner">
         <span class="beta-banner__beta-box">BETA</span>