Merge pull request #1171 from TechnologyEnhancedLearning/Develop/POC/TD-5593_selfentrolled_moodle_courses_discoverable_in_lh

Fixed the issue with fall back image downloading locally and cionsist…

Author: binon

LearningHub.Nhs.WebUI/Views/Home/_CourseEnrolled.cshtml

@@ -12,7 +12,7 @@
     {
         var apiBaseUrl = Configuration["MoodleAPIConfig:BaseUrl"];        
         string path = $"course/view.php";
-        string returnUrl = $@"{apiBaseUrl}/{path}?id={courseId}";
+        string returnUrl = $@"{apiBaseUrl}{path}?id={courseId}";
 
         return returnUrl;
     }
@@ -21,11 +21,9 @@
     <div class="nhsuk-card-banner-container">
         @if (!string.IsNullOrWhiteSpace(Model.CourseImage))
         {
-            if (Model.CourseImage.EndsWith(".svg", StringComparison.OrdinalIgnoreCase))
+            @if (Model.CourseImage.EndsWith(".svg", StringComparison.OrdinalIgnoreCase))
             {
-                <object class="nhsuk-card__img nhsuk-card-banner" type="image/svg+xml" data="@Model.CourseImage">
-                    <img src="/images/default-course.jpg" alt="Fallback image" />
-                </object>
+                <img class="nhsuk-card__img nhsuk-card-banner" src="@Model.CourseImage" alt="Course image" onerror="this.onerror=null;this.src='/images/default-course.jpg';" />
             }
             else
             {

LearningHub.Nhs.WebUI/Views/Search/_ResourceSearchResult.cshtml

@@ -38,7 +38,7 @@
 
 		var apiBaseUrl = Configuration["MoodleAPIConfig:BaseUrl"];
 		string path = $"course/view.php";
-		string returnUrl = $@"{apiBaseUrl}/{path}?id={courseId}";
+		string returnUrl = $@"{apiBaseUrl}{path}?id={courseId}";
 
 		return returnUrl;
 	}