Skip to content

Commit 6c63c4a

Browse files
authored
Merge pull request #1373 from TechnologyEnhancedLearning/Develop/Fixes/To-check-Recent-learning-issue
Removed the commented code
2 parents 88ec502 + 2ccae81 commit 6c63c4a

File tree

1 file changed

+20
-28
lines changed

1 file changed

+20
-28
lines changed

OpenAPI/LearningHub.Nhs.OpenApi.Services/Services/MyLearningService.cs

Lines changed: 20 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -157,11 +157,9 @@ public async Task<MyLearningDetailedViewModel> GetActivityDetailed(int userId, M
157157
/// <returns>The <see cref="Task"/>.</returns>
158158
public async Task<MyLearningActivitiesDetailedViewModel> GetUserRecentMyLearningActivitiesAsync(int userId, MyLearningRequestModel requestModel)
159159
{
160-
try
161-
{
162160
var result = await resourceActivityRepository.GetUserRecentMyLearningActivities(userId, requestModel);
163161

164-
//// var entrolledCourses = await this.moodleApiService.GetRecentEnrolledCoursesAsync(userId, requestModel, 6);
162+
var entrolledCourses = await this.moodleApiService.GetRecentEnrolledCoursesAsync(userId, requestModel, 6);
165163

166164
var mappedMyLearningActivities = result.Select(Activity => new MyLearningCombinedActivitiesViewModel
167165
{
@@ -182,28 +180,27 @@ public async Task<MyLearningActivitiesDetailedViewModel> GetUserRecentMyLearning
182180
CompletedActivities = 0,
183181
}).ToList();
184182

185-
////var mappedEnrolledCourses = entrolledCourses.Select(course => new MyLearningCombinedActivitiesViewModel
186-
////{
187-
//// UserId = userId,
188-
//// ResourceId = (int)course.Id,
189-
//// ResourceVersionId = (int)course.Id,
190-
//// IsCurrentResourceVersion = true,
191-
//// ResourceReferenceId = (int)course.Id,
192-
//// MajorVersion = 1,
193-
//// MinorVersion = 0,
194-
//// ResourceType = ResourceTypeEnum.Moodle,
195-
//// Title = course.DisplayName,
196-
//// CertificateEnabled = course.CertificateEnabled,
197-
//// ActivityStatus = (course.Completed == true || course.ProgressPercentage.TrimEnd('%') == "100") ? ActivityStatusEnum.Completed : ActivityStatusEnum.Incomplete,
198-
//// ActivityDate = DateTimeOffset.FromUnixTimeMilliseconds((long)course.LastAccess),
199-
//// ScorePercentage = Convert.ToInt32(course.ProgressPercentage.TrimEnd('%')),
200-
//// TotalActivities = course.TotalActivities,
201-
//// CompletedActivities = course.CompletedActivities,
202-
////}).ToList();
183+
var mappedEnrolledCourses = entrolledCourses.Select(course => new MyLearningCombinedActivitiesViewModel
184+
{
185+
UserId = userId,
186+
ResourceId = (int)course.Id,
187+
ResourceVersionId = (int)course.Id,
188+
IsCurrentResourceVersion = true,
189+
ResourceReferenceId = (int)course.Id,
190+
MajorVersion = 1,
191+
MinorVersion = 0,
192+
ResourceType = ResourceTypeEnum.Moodle,
193+
Title = course.DisplayName,
194+
CertificateEnabled = course.CertificateEnabled,
195+
ActivityStatus = (course.Completed == true || course.ProgressPercentage.TrimEnd('%') == "100") ? ActivityStatusEnum.Completed : ActivityStatusEnum.Incomplete,
196+
ActivityDate = DateTimeOffset.FromUnixTimeMilliseconds((long)course.LastAccess),
197+
ScorePercentage = Convert.ToInt32(course.ProgressPercentage.TrimEnd('%')),
198+
TotalActivities = course.TotalActivities,
199+
CompletedActivities = course.CompletedActivities,
200+
}).ToList();
203201

204202
// Combine both result sets
205-
////var combainedUserActivities = mappedMyLearningActivities.Concat(mappedEnrolledCourses).ToList();
206-
var combainedUserActivities = mappedMyLearningActivities.ToList();
203+
var combainedUserActivities = mappedMyLearningActivities.Concat(mappedEnrolledCourses).ToList();
207204

208205
var pagedResults = combainedUserActivities.OrderByDescending(activity => activity.ActivityDate).Skip(requestModel.Skip).Take(requestModel.Take).ToList();
209206

@@ -215,11 +212,6 @@ public async Task<MyLearningActivitiesDetailedViewModel> GetUserRecentMyLearning
215212
};
216213

217214
return viewModel;
218-
}
219-
catch (Exception ex)
220-
{
221-
return null;
222-
}
223215
}
224216

225217
/// <summary>

0 commit comments

Comments
 (0)