TD-3955: hard coded value replaced with enum

sarathlal-sarangadharan · sarathlal-sarangadharan · commit 8c5fea10c21d · 2024-04-08T09:23:27.000+01:00
diff --git a/LearningHub.Nhs.WebUI/Controllers/Api/ScormController.cs b/LearningHub.Nhs.WebUI/Controllers/Api/ScormController.cs
@@ -260,7 +260,7 @@ private async Task<bool> Commit(SCO scoObject)
 
                 // Persist update.
                 await this.activityService.UpdateScormActivityAsync(scoObject);
-                if (scoObject.LessonStatusId == 3 || scoObject.LessonStatusId == 5)
+                if (scoObject.LessonStatusId == ScormLessionStatus.ActivityStatusId(ScormLessionStatus.Completed) || scoObject.LessonStatusId == ScormLessionStatus.ActivityStatusId(ScormLessionStatus.Passed))
                 {
                     await this.activityService.CompleteScormActivity(scoObject);
                 }

Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,7 @@ private async Task<bool> Commit(SCO scoObject)`
`260`	`260`
`261`	`261`	`// Persist update.`
`262`	`262`	`await this.activityService.UpdateScormActivityAsync(scoObject);`
`263`		`- if (scoObject.LessonStatusId == 3 \|\| scoObject.LessonStatusId == 5)`
	`263`	`+ if (scoObject.LessonStatusId == ScormLessionStatus.ActivityStatusId(ScormLessionStatus.Completed) \|\| scoObject.LessonStatusId == ScormLessionStatus.ActivityStatusId(ScormLessionStatus.Passed))`
`264`	`264`	`{`
`265`	`265`	`await this.activityService.CompleteScormActivity(scoObject);`
`266`	`266`	`}`