Skip to content

Commit a457c7d

Browse files
Merge pull request #499 from TechnologyEnhancedLearning/Develop/fixes/TD-4411-My-learning-page---Completed-filter-along-with-Assessment-doesnt-display-the-correct-results
TD-4411: Fixed filter result for 'Completed' filter along with 'Assessment'.
2 parents 1323a4d + e28850e commit a457c7d

File tree

2 files changed

+60
-9
lines changed

2 files changed

+60
-9
lines changed

WebAPI/LearningHub.Nhs.Database/Stored Procedures/Activity/GetUserLearningActivities.sql

Lines changed: 30 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
-- Sarathlal 08-03-2024
1111
-- Sarathlal 23-04-2024 TD-2954: Audio/Video/Assessment issue resolved and duplicate issue also resolved
1212
-- Sarathlal 25-04-2024 TD-4067: Resource with muliple version issue resolved
13+
-- Arunima 26-07-2024 TD-4411: "Completed" filter along with "Assessment" doesn't display the correct results
1314
-------------------------------------------------------------------------------
1415
CREATE PROCEDURE [activity].[GetUserLearningActivities] (
1516
@userId INT
@@ -271,9 +272,35 @@ FROM (
271272
)
272273
)
273274
OR
274-
([Res].[ResourceTypeId] IN (6,11) AND [ResourceActivity].[ActivityStatusId] = 3)
275-
OR ([Res].[ResourceTypeId] IN (11) AND [ResourceActivity].[ActivityStatusId] = 3 AND [AssessResVer].[AssessmentType]=1)
276-
--OR
275+
([Res].[ResourceTypeId] IN (6) AND [ResourceActivity].[ActivityStatusId] = 3)
276+
OR (
277+
EXISTS (SELECT 1 FROM @tmpActivityStatus WHERE ActivityStatusId = 3)
278+
AND
279+
(
280+
[Res].[ResourceTypeId] = 11 AND [AssessResVer].[AssessmentType]=1
281+
AND
282+
EXISTS
283+
(
284+
SELECT 1
285+
FROM [activity].[AssessmentResourceActivity] AS [AssessmentResourceActivity6]
286+
WHERE
287+
[AssessmentResourceActivity6].[Deleted] = 0
288+
AND
289+
[ResourceActivity].[Id] = [AssessmentResourceActivity6].[ResourceActivityId]
290+
)
291+
AND
292+
(
293+
(SELECT TOP(1)
294+
[AssessmentResourceActivity7].[Score]
295+
FROM [activity].[AssessmentResourceActivity] AS [AssessmentResourceActivity7]
296+
WHERE
297+
[AssessmentResourceActivity7].[Deleted] = 0
298+
AND [ResourceActivity].[Id] = [AssessmentResourceActivity7].[ResourceActivityId]) >= 0.0
299+
)
300+
)
301+
302+
)
303+
--OR
277304
--(
278305
-- ([Res].[ResourceTypeId] IN (1,5,10,12) AND [ResourceActivity].[ActivityStatusId] = 3)
279306
-- AND
@@ -507,5 +534,3 @@ LEFT JOIN (
507534
ORDER BY [t2].[ActivityStart] DESC, [t2].[Id], [t2].[Id0], [t2].[Id1], [t2].[Id2], [VideoResourceVersion].[Id], [AudeoResourceVersion].[Id], [t3].[Id], [t4].[Id], [t5].[Id], [t6].[Id], [t7].[Id], [t8].[Id], [t9].[Id], [t10].[Id], [t11].[Id]
508535

509536
END
510-
511-

WebAPI/LearningHub.Nhs.Database/Stored Procedures/Activity/GetUserLearningActivitiesCount.sql

Lines changed: 30 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
-- Sarathlal 18-12-2023
1010
-- Sarathlal 08-03-2024
1111
-- Sarathlal 23-04-2024 TD-2954: Audio/Video/Assessment issue resolved and duplicate issue also resolved
12+
-- Arunima 26-07-2024 TD-4411: "Completed" filter along with "Assessment" doesn't display the correct results
1213
-------------------------------------------------------------------------------
1314
CREATE PROCEDURE [activity].[GetUserLearningActivitiesCount] (
1415
@userId INT
@@ -186,10 +187,35 @@ FROM (
186187
)
187188
)
188189
OR
189-
([Res].[ResourceTypeId] IN (6,11) AND [ResourceActivity].[ActivityStatusId] = 3)
190-
OR ([Res].[ResourceTypeId] IN (11) AND [ResourceActivity].[ActivityStatusId] = 3 AND [AssessResVer].[AssessmentType]=1)
191-
192-
--OR
190+
([Res].[ResourceTypeId] IN (6) AND [ResourceActivity].[ActivityStatusId] = 3)
191+
OR (
192+
EXISTS (SELECT 1 FROM @tmpActivityStatus WHERE ActivityStatusId = 3)
193+
AND
194+
(
195+
[Res].[ResourceTypeId] = 11 AND [AssessResVer].[AssessmentType]=1
196+
AND
197+
EXISTS
198+
(
199+
SELECT 1
200+
FROM [activity].[AssessmentResourceActivity] AS [AssessmentResourceActivity6]
201+
WHERE
202+
[AssessmentResourceActivity6].[Deleted] = 0
203+
AND
204+
[ResourceActivity].[Id] = [AssessmentResourceActivity6].[ResourceActivityId]
205+
)
206+
AND
207+
(
208+
(SELECT TOP(1)
209+
[AssessmentResourceActivity7].[Score]
210+
FROM [activity].[AssessmentResourceActivity] AS [AssessmentResourceActivity7]
211+
WHERE
212+
[AssessmentResourceActivity7].[Deleted] = 0
213+
AND [ResourceActivity].[Id] = [AssessmentResourceActivity7].[ResourceActivityId]) >= 0.0
214+
)
215+
)
216+
217+
)
218+
--OR
193219
--(
194220
-- ([Res].[ResourceTypeId] IN (1,5,10,12) AND [ResourceActivity].[ActivityStatusId] = 3)
195221
-- AND

0 commit comments

Comments
 (0)