Skip to content

Commit a5056db

Browse files
Merge pull request #321 from TechnologyEnhancedLearning/Develop/Fixes/TD-4067-unknown-error-on-links-to-scorm/html-resources-on-my-learning-page
TD-4067: Issue in elearning when multiple version is available has been resolved
2 parents acf5321 + 58c0b5e commit a5056db

File tree

3 files changed

+14
-7
lines changed

3 files changed

+14
-7
lines changed

WebAPI/LearningHub.Nhs.Database/Stored Procedures/Activity/GetUserLatestActivityCheck.sql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
-- Modification History
88
-- Sarathlal 20-02-2024
99
-- Sarathlal 23-04-2024 TD-2954: Audio/Video/Assessment issue resolved and duplicate issue also resolved
10+
-- Sarathlal 25-04-2024 TD-4067: Resource with muliple version issue resolved
1011
-------------------------------------------------------------------------------
1112

1213
CREATE PROCEDURE [activity].[GetUserLatestActivityCheck] (
@@ -17,7 +18,7 @@ AS
1718
BEGIN
1819
SELECT
1920
--Resource activity starts here
20-
[t2].[Id] as Id,[t2].[UserId] as UserId,[t7].[ResourceId] as ResourceId,[t2].[ResourceVersionId] as ResourceVersionId,[t7].[NodePathId],[t2].[AmendDate],[t2].[Deleted],[t2].[CreateUserId],[t2].[CreateDate],[t2].[AmendUserId]
21+
[t2].[Id] as Id,[t2].[UserId] as UserId,[t7].[ResourceId] as ResourceId,[t2].[ResourceVersionId] as ResourceVersionId,[t2].[NodePathId],[t2].[AmendDate],[t2].[Deleted],[t2].[CreateUserId],[t2].[CreateDate],[t2].[AmendUserId]
2122
,[t2].[LaunchResourceActivityId],[t2].[MajorVersion],[t2].[MinorVersion],[t2].[ActivityStatusId],[t2].[ActivityStart],[t2].[ActivityEnd],[t9].[DurationSeconds],[t2].[Score]
2223
--Node path clumns starts here
2324
,[t6].[AmendDate] as NodePath_AmendDate,[t6].[AmendUserId] as NodePath_AmendUserId,[t6].[CatalogueNodeId] as NodePath_CatalogueNode, [t6].[CreateDate] as NodePath_CreateDate, [t6].[CreateUserId] as NodePath_CreateUserId, [t6].[Deleted] as NodePath_Deleted, [t6].[IsActive] as NodePath_IsActive

WebAPI/LearningHub.Nhs.Database/Stored Procedures/Activity/GetUserLearningActivities.sql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
-- Sarathlal 14-12-2023
1010
-- Sarathlal 08-03-2024
1111
-- Sarathlal 23-04-2024 TD-2954: Audio/Video/Assessment issue resolved and duplicate issue also resolved
12+
-- Sarathlal 25-04-2024 TD-4067: Resource with muliple version issue resolved
1213
-------------------------------------------------------------------------------
1314
CREATE PROCEDURE [activity].[GetUserLearningActivities] (
1415
@userId INT
@@ -57,7 +58,7 @@ BEGIN
5758

5859
SELECT
5960
--Resource activity starts here
60-
[t2].[Id] as Id,[t2].[UserId] as UserId,[t7].[ResourceId] as ResourceId,[t2].[ResourceVersionId] as ResourceVersionId,[t7].[NodePathId],[t2].[AmendDate],[t2].[Deleted],[t2].[CreateUserId],[t2].[CreateDate],[t2].[AmendUserId]
61+
[t2].[Id] as Id,[t2].[UserId] as UserId,[t7].[ResourceId] as ResourceId,[t2].[ResourceVersionId] as ResourceVersionId,[t2].[NodePathId],[t2].[AmendDate],[t2].[Deleted],[t2].[CreateUserId],[t2].[CreateDate],[t2].[AmendUserId]
6162
,[t2].[LaunchResourceActivityId],[t2].[MajorVersion],[t2].[MinorVersion],[t2].[ActivityStatusId],[t2].[ActivityStart],[t2].[ActivityEnd],[t9].[DurationSeconds],[t2].[Score]
6263
--Node path clumns starts here
6364
,[t6].[AmendDate] as NodePath_AmendDate,[t6].[AmendUserId] as NodePath_AmendUserId,[t6].[CatalogueNodeId] as NodePath_CatalogueNode, [t6].[CreateDate] as NodePath_CreateDate, [t6].[CreateUserId] as NodePath_CreateUserId, [t6].[Deleted] as NodePath_Deleted, [t6].[IsActive] as NodePath_IsActive

WebAPI/LearningHub.Nhs.Repository/Activity/ResourceActivityRepository.cs

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -502,12 +502,17 @@ private void BindResourceNestedData(List<MyLearningActivity> result)
502502
i.Resource.Deleted = i.Resource_Deleted;
503503
int resourceTypeId = i.Resource_ResourceTypeId;
504504
i.Resource.ResourceTypeEnum = (ResourceTypeEnum)resourceTypeId;
505-
ResourceReference resourceReference = new ResourceReference();
506-
resourceReference.OriginalResourceReferenceId = i.ResourceReference_OriginalResourceReferenceId;
507-
resourceReference.NodePathId = i.ResourceReference_NodePathId;
508-
resourceReference.ResourceId = i.ResourceReference_ResourceId;
505+
var resourceReferences = result.Where(x => x.Id == i.Id && x.ResourceVersionId == i.ResourceVersionId).ToList();
509506
List<ResourceReference> resourceReferenceList = new List<ResourceReference>();
510-
resourceReferenceList.Add(resourceReference);
507+
foreach (var b in resourceReferences)
508+
{
509+
ResourceReference resourceReference = new ResourceReference();
510+
resourceReference.OriginalResourceReferenceId = b.ResourceReference_OriginalResourceReferenceId;
511+
resourceReference.NodePathId = b.ResourceReference_NodePathId;
512+
resourceReference.ResourceId = b.ResourceReference_ResourceId;
513+
resourceReferenceList.Add(resourceReference);
514+
}
515+
511516
i.Resource.ResourceReference = resourceReferenceList;
512517
});
513518
}

0 commit comments

Comments
 (0)