TD-5924 Tidy up

Author: Phil-NHS

LearningHub.Nhs.WebUI.BlazorClient/Program.cs

@@ -1,6 +1,5 @@
-using Blazored.LocalStorage; // Still required server side even if not used so components dont fail to build
+using Blazored.LocalStorage;
 using LearningHub.Nhs.WebUI.BlazorClient.DI;
-
 using LearningHub.Nhs.Shared.Configuration;
 using LearningHub.Nhs.Shared.Interfaces.Http;
 using LearningHub.Nhs.WebUI.BlazorClient.Services;
@@ -26,7 +25,6 @@
 using TELBlazor.Components.Core.Services.HelperServices;
 using TELBlazor.Components.OptionalImplementations.Core.Services.HelperServices;
 
-
 var builder = WebAssemblyHostBuilder.CreateDefault(args);
 
 var http = new HttpClient { BaseAddress = new Uri(builder.HostEnvironment.BaseAddress) };
@@ -54,7 +52,7 @@
     .CreateLogger();
 
 // Add Serilog to logging providers
-builder.Logging.AddSerilog(Log.Logger, dispose: true);//qqqq may not need dispose for client
+builder.Logging.AddSerilog(Log.Logger);
 
 //for really bad fails
 try
@@ -85,7 +83,7 @@
     builder.Services.AddScoped<LoggingLevelSwitch>(sp => levelSwitch);
     builder.Services.AddScoped<ILogLevelSwitcherService, SerilogLogLevelSwitcherService>();
 
-    // TODO builder.Services.AddScoped<ICacheService, WasmCacheServiceStub>();
+    // TODO (QQQQ) implement post TD-5925 builder.Services.AddScoped<ICacheService, WasmCacheServiceStub>();
 
     await builder.Build().RunAsync();
 }

LearningHub.Nhs.WebUI.BlazorClient/Services/WasmCacheServiceStub.cs

@@ -1,12 +1,12 @@
-// TODO: using LearningHub.Nhs.Caching;
+// TODO (QQQQ) implement post TD-5925: using LearningHub.Nhs.Models;
 
 namespace LearningHub.Nhs.WebUI.BlazorClient.Services
 {
     /// <summary>
     /// We may use storage, we may just stub it and throw an error, we cant directly use redis we may access it via an api
     /// The cachestub currently just returns there is nothing available so the caller then will revert to calling the api.
     /// </summary>
-    public class WasmCacheServiceStub // TODO: ICacheService
+    public class WasmCacheServiceStub // TODO (QQQQ) implement post TD-5925 and get from NHS.Models: ICacheService
     {
         public Task<T> GetAsync<T>(string key)
         {

LearningHub.Nhs.WebUI/Controllers/Api/BFFController.cs

@@ -78,7 +78,6 @@ public async Task<IActionResult> ProxyRequest(string apiName, string path)
             string sanitizedPath = path?.Trim('/').ToLowerInvariant() ?? string.Empty;
             string sanitizedApiName = apiName?.Trim('/').ToLowerInvariant() ?? string.Empty;
 
-            // qqqq https://lh-web.dev.local/bff/lh-api.dev.local/Catalogue/GetLatestCatalogueAccessRequest/500
             IAPIHttpClient apiClient;
             try
             {
@@ -103,7 +102,6 @@ public async Task<IActionResult> ProxyRequest(string apiName, string path)
 
             if (!this.IsPathAllowed(sanitizedPath))
             {
-                // qqqq "catalogue/getlatestcatalogueaccessrequest/500"
                 return this.Forbid("This path is not allowed via BFF proxy.");
             }
 

LearningHub.Nhs.WebUI/Startup/ServiceMappings.cs

@@ -88,7 +88,7 @@ public static void AddLearningHubMappings(this IServiceCollection services, ICon
 
             // Config
             services.Configure<OpenAthensScopes>(configuration.GetSection("OpenAthensScopes"));
-            services.Configure<BFFPathValidationOptions>(configuration.GetSection("Settings:" + BFFPathValidationOptions.SectionName)); // qqqq
+            services.Configure<BFFPathValidationOptions>(configuration.GetSection("Settings:" + BFFPathValidationOptions.SectionName));
 
             // Blazor
             services.AddRazorComponents()
@@ -143,8 +143,6 @@ public static void AddLearningHubMappings(this IServiceCollection services, ICon
             services.AddScoped<OfflineCheckFilter>();
 
             // <!-- blazor architecture keep at bottom so can use existing services and map them-->
-
-            // <!--qqqq blazor services maybe collection so all together and update show whats missing-->
             // Future candidates for DI collection
             services.AddBlazoredLocalStorage();
 

LearningHub.Nhs.WebUI/Views/Home/LandingPage.cshtml

@@ -37,20 +37,6 @@
             Sign up, explore and learn
         </div>
     </div>
-    <!--qqqq-->
-    <component type="typeof(TELBlazor.Components.Components.BaseComponents.TELButton)"
-               render-mode="WebAssemblyPrerendered"
-               param-IsSubmitButtonForEditForm="false"
-               param-NoJSActionUrl="@("nojsfallback/mvcendpoint/telbuttonshowcase")"
-               param-FormData="@(new Dictionary<string, string>{{"increment","1"}})"
-               param-ButtonStyle="TELBlazor.Components.Core.Enums.TELButtonStyle.Warning"
-               param-PreventDoubleClick="false"
-               param-ButtonText="@("Click me!")"
-               param-AdditionalCssClasses="@("")"
-               param-AriaLabel="@("Click Counter")"
-               param-AssistiveText="@("Click to increase the number")"
-               param-TabIndex="0"
-               param-ToolTipTitle="@("Click to increment")" />
     <div class="landing-page__access-container">
         <div class="nhsuk-width-container app-width-container">
             <div class="nhsuk-grid-row">