Merge pull request #753 from TechnologyEnhancedLearning/Merge-Begonia-Rc

Merge begonia  release changes to RC

Author: AnjuJose011

.github/pull_request_template.md

@@ -1,25 +1,25 @@
 ### JIRA link
-_TD-###_
+[TD-####](https://hee-tis.atlassian.net/browse/TD-####)
 
 ### Description
-_Describe what has changed and how that will affect the app. If relevant, add references to the resources you used. Use this as your opportunity to highlight anything odd and give people context around particular decisions._
+_Describe what has changed and how that will affect the app. If relevant, add links to any sources/documentation you used. Highlight anything unusual and give people context around particular decisions._
 
 ### Screenshots
-_Attach screenshots on mobile, tablet and desktop._
+_Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors._
 
 -----
 ### Developer checks
 (Leave tasks unticked if they haven't been appropriate for your ticket.)
 
 I have:
-- [ ] Run the formatter and made sure there are no IDE errors
-- [ ] Written appropriate unit tests for the changes, including:
-	- accessibility tests for new views
-	- tests for new controller methods
-	- tests for new or modified API endpoints
-- [ ] Manually tested my work with and without JavaScript
-- [ ] Tested any Views or partials created or changed with [Wave Chrome plugin](https://chrome.google.com/webstore/detail/wave-evaluation-tool/jbbplnpkjmmeebjpijfedlgcdilocofh/related) and addressed any valid accessibility issues
-- [ ] Updated/added documentation in [Confluence](https://hee-tis.atlassian.net/wiki/spaces/TP/pages/3477930003/Learning+Hub) and/or [GitHub Readme](https://github.com/TechnologyEnhancedLearning/LearningHub.Nhs.UserApi/blob/master/README.md). List of documentation links added/changed:
+- [ ] Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
+- [ ] Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
+- [ ] Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
+- [ ] Tested any Views or partials created or changed with [Wave Chrome plugin](https://chrome.google.com/webstore/detail/wave-evaluation-tool/jbbplnpkjmmeebjpijfedlgcdilocofh/related). Addressed any valid accessibility issues and documented any invalid errors
+- [ ] Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need  to be tested to ensure nothing is broken
+- [ ] Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
+Either:
+- [ ] Documented my work in [Confluence](https://hee-tis.atlassian.net/wiki/spaces/TP/pages/3461087233/Development), updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
   - [doc_1_here](link_1_here)
-- [ ] Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
-- [ ] Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.
+Or:
+- [ ] Confirmed that none of the work that I have undertaken requires any updates to documentation

AdminUI/LearningHub.Nhs.AdminUI/Controllers/ResourceController.cs

@@ -91,11 +91,15 @@ public ResourceController(
         /// The Details.
         /// </summary>
         /// <param name="id">The id<see cref="int"/>.</param>
+        /// <param name="activeTab">The activeTab<see cref="string"/>.</param>
+        /// <param name="status">The status<see cref="string"/>.</param>
         /// <returns>The <see cref="Task{IActionResult}"/>.</returns>
         [HttpGet]
-        public async Task<IActionResult> Details(int id)
+        public async Task<IActionResult> Details(int id, string activeTab = "details", string status = "")
         {
             var resource = await this.resourceService.GetResourceVersionExtendedViewModelAsync(id);
+            this.ViewBag.ActiveTab = activeTab;
+            this.ViewBag.Status = status;
             return this.View(resource);
         }
 
@@ -138,6 +142,41 @@ public async Task<IActionResult> GetValidationResults(int resourceVersionId)
             return this.PartialView("_ValidationResults", vm);
         }
 
+        /// <summary>
+        /// The GetDevIdDetails.
+        /// </summary>
+        /// <param name="resourceVersionId">The resourceVersionId<see cref="int"/>.</param>
+        /// <returns>The <see cref="Task{IActionResult}"/>.</returns>
+        [HttpPost]
+        public async Task<IActionResult> GetDevIdDetails(int resourceVersionId)
+        {
+            var vm = await this.resourceService.GetResourceVersionDevIdDetailsAsync(resourceVersionId);
+
+            return this.PartialView("_DevIdDetails", vm);
+        }
+
+        /// <summary>
+        /// The update the dev Id details.
+        /// </summary>
+        /// <param name="model">The model.</param>
+        /// <returns>The <see cref="Task{IActionResult}"/>.</returns>
+        [HttpPost]
+        public async Task<IActionResult> UpdateDevIdDetails(ResourceVersionDevIdViewModel model)
+        {
+            var message = string.Empty;
+            if (await this.resourceService.DoesDevIdExistsAsync(model.DevId))
+            {
+                message = "Duplicate";
+            }
+            else
+            {
+                await this.resourceService.UpdateDevIdDetailsAsync(model);
+                message = "Success";
+            }
+
+            return this.RedirectToAction("Details", new { id = model.ResourceVersionId, activeTab = "devId", status = message });
+        }
+
         /// <summary>
         /// The Index.
         /// </summary>

AdminUI/LearningHub.Nhs.AdminUI/Interfaces/IResourceService.cs

@@ -32,9 +32,30 @@ public interface IResourceService
         /// The GetResourceVersionValidationResultAsync.
         /// </summary>
         /// <param name="resourceVersionId">The resourceVersionId<see cref="int"/>.</param>
-        /// <returns>The <see cref="Task{ResourceVersionEventViewModel}}"/>.</returns>
+        /// <returns>The <see cref="Task{ResourceVersionValidationResultViewModel}}"/>.</returns>
         Task<ResourceVersionValidationResultViewModel> GetResourceVersionValidationResultAsync(int resourceVersionId);
 
+        /// <summary>
+        /// The GetResourceVersionDevIdDetailsAsync.
+        /// </summary>
+        /// <param name="resourceVersionId">The resourceVersionId<see cref="int"/>.</param>
+        /// <returns>The <see cref="Task{ResourceVersionDevIdViewModel}}"/>.</returns>
+        Task<ResourceVersionDevIdViewModel> GetResourceVersionDevIdDetailsAsync(int resourceVersionId);
+
+        /// <summary>
+        /// Check dev id already exist against a resource.
+        /// </summary>
+        /// <param name="devId">string devId.</param>
+        /// <returns>The <see cref="Task{bool}"/>.</returns>
+        Task<bool> DoesDevIdExistsAsync(string devId);
+
+        /// <summary>
+        /// To update dev id details for a resource.
+        /// </summary>
+        /// <param name="model">the ResourceVersionDevIdViewModel.</param>
+        /// <returns>The <see cref="Task{ResourceVersionDevIdViewModel}}"/>.</returns>
+        Task UpdateDevIdDetailsAsync(ResourceVersionDevIdViewModel model);
+
         /// <summary>
         /// The GetResourceVersionExtendedViewModelAsync.
         /// </summary>

AdminUI/LearningHub.Nhs.AdminUI/LearningHub.Nhs.AdminUI.csproj

@@ -89,7 +89,7 @@
     <PackageReference Include="HtmlSanitizer" Version="6.0.453" />
 	<PackageReference Include="IdentityModel" Version="4.4.0" />
     <PackageReference Include="LearningHub.Nhs.Caching" Version="2.0.2" />
-    <PackageReference Include="LearningHub.Nhs.Models" Version="3.0.43" />
+    <PackageReference Include="LearningHub.Nhs.Models" Version="3.0.44" />
     <PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.19.0" />
     <PackageReference Include="Microsoft.AspNetCore.Authentication.OpenIdConnect" Version="6.0.0" />
     <PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="6.0.0" />

AdminUI/LearningHub.Nhs.AdminUI/Services/ResourceService.cs

@@ -2,6 +2,7 @@
 {
     using System;
     using System.Collections.Generic;
+    using System.Net;
     using System.Net.Http;
     using System.Text;
     using System.Threading.Tasks;
@@ -130,6 +131,89 @@ public async Task<ResourceVersionValidationResultViewModel> GetResourceVersionVa
             return viewmodel;
         }
 
+        /// <summary>
+        /// The GetResourceVersionDevIdDetailsAsync.
+        /// </summary>
+        /// <param name="resourceVersionId">The resourceVersionId<see cref="int"/>.</param>
+        /// <returns>The <see cref="List{ResourceVersionDevIdViewModel}"/>.</returns>
+        public async Task<ResourceVersionDevIdViewModel> GetResourceVersionDevIdDetailsAsync(int resourceVersionId)
+        {
+            ResourceVersionDevIdViewModel viewmodel = null;
+
+            var client = await this.LearningHubHttpClient.GetClientAsync();
+
+            var request = $"Resource/GetResourceVersionDevIdDetails/{resourceVersionId.ToString()}";
+            var response = await client.GetAsync(request).ConfigureAwait(false);
+
+            if (response.IsSuccessStatusCode)
+            {
+                var result = response.Content.ReadAsStringAsync().Result;
+                viewmodel = JsonConvert.DeserializeObject<ResourceVersionDevIdViewModel>(result);
+            }
+            else if (response.StatusCode == System.Net.HttpStatusCode.Unauthorized
+                        ||
+                     response.StatusCode == System.Net.HttpStatusCode.Forbidden)
+            {
+                throw new Exception("AccessDenied");
+            }
+
+            return viewmodel;
+        }
+
+        /// <summary>
+        /// The GetResourceVersionDevIdDetailsAsync.
+        /// </summary>
+        /// <param name="devId">The devId<see cref="string"/>.</param>
+        /// <returns>The <see cref="List{ResourceVersionDevIdViewModel}"/>.</returns>
+        public async Task<bool> DoesDevIdExistsAsync(string devId)
+        {
+            var client = await this.LearningHubHttpClient.GetClientAsync();
+
+            var request = $"Resource/DoesDevIdExists/{devId}";
+            var response = await client.GetAsync(request).ConfigureAwait(false);
+            var doesDevIdExist = false;
+            if (response.IsSuccessStatusCode)
+            {
+                var result = response.Content.ReadAsStringAsync().Result;
+                doesDevIdExist = JsonConvert.DeserializeObject<bool>(result);
+            }
+            else if (response.StatusCode == System.Net.HttpStatusCode.Unauthorized
+                        ||
+                     response.StatusCode == System.Net.HttpStatusCode.Forbidden)
+            {
+                throw new Exception("AccessDenied");
+            }
+
+            return doesDevIdExist;
+        }
+
+        /// <summary>
+        /// Update dev id details for a resource.
+        /// </summary>
+        /// <param name="model">The model.</param>
+        /// <returns>The <see cref="List{ResourceVersionDevIdViewModel}"/>.</returns>
+        /// <exception cref="Exception">the exception.</exception>
+        public async Task UpdateDevIdDetailsAsync(ResourceVersionDevIdViewModel model)
+        {
+            var json = JsonConvert.SerializeObject(model);
+            var stringContent = new StringContent(json, UnicodeEncoding.UTF8, "application/json");
+
+            var client = await this.LearningHubHttpClient.GetClientAsync();
+
+            var request = $"Resource/UpdateDevId";
+            var response = await client.PutAsync(request, stringContent).ConfigureAwait(false);
+
+            if (response.StatusCode == HttpStatusCode.Unauthorized || response.StatusCode == HttpStatusCode.Forbidden)
+            {
+                throw new Exception("AccessDenied");
+            }
+
+            if (!response.IsSuccessStatusCode)
+            {
+                throw new Exception("Update first name failed!");
+            }
+        }
+
         /// <summary>
         /// The GetResourceVersionExtendedViewModelAsync.
         /// </summary>