TD-5930 Properties Environment is redundant as in top level appsettings

Author: Phil-NHS

LearningHub.Nhs.WebUI.BlazorClient/Program.cs

@@ -63,7 +63,7 @@
         return new TELBlazorBaseComponentConfiguration
         {
             JSEnabled = true, //if we are inject the client then it is true
-            HostType = $"{builder.Configuration["Properties:Environment"]} {builder.Configuration["Properties:Application"]}"
+            HostType = $"{builder.Configuration["Environment"]} {builder.Configuration["Properties:Application"]}"
         };
     });
 

LearningHub.Nhs.WebUI.BlazorClient/wwwroot/appsettings.json

@@ -1,4 +1,5 @@
 {
+  "Environment": "",
   "Settings": {
     "BuildNumber": "Production",
     "https": null,
@@ -49,7 +50,6 @@
     }
   },
   "Properties": {
-    "Application": "LearningHub Nhs WebUI Blazor Client",
-    "Environment": "Production"
+    "Application": "LearningHub Nhs WebUI Blazor Client"
   }
 }

LearningHub.Nhs.WebUI.sln

@@ -4,17 +4,12 @@ Microsoft Visual Studio Solution File, Format Version 12.00
 VisualStudioVersion = 17.4.33213.308
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "LearningHub.Nhs.WebUI", "LearningHub.Nhs.WebUI\LearningHub.Nhs.WebUI.csproj", "{16BBF937-C1E9-4240-B56E-20E3E5FA2005}"
-	ProjectSection(ProjectDependencies) = postProject
-		{9F1B0470-E809-49FE-A6E8-152C7EBD012E} = {9F1B0470-E809-49FE-A6E8-152C7EBD012E}
-	EndProjectSection
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{B5D48B6A-D4A7-494E-89C0-64428232D242}"
 	ProjectSection(SolutionItems) = preProject
-		.editorconfig = .editorconfig
-		global.json = global.json
+		Directory.Build.props = Directory.Build.props
+		Directory.Packages.props = Directory.Packages.props
 		nuget.config = nuget.config
-		nuget.config.cicd = nuget.config.cicd
-		nuget.config.template = nuget.config.template
 		StyleCop.ruleset = StyleCop.ruleset
 	EndProjectSection
 EndProject
@@ -23,9 +18,6 @@ EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "MigrationTool", "MigrationTool", "{94676CCE-A38B-4FAF-905E-CE85CE95845E}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "LearningHub.Nhs.Api", "WebAPI\LearningHub.Nhs.API\LearningHub.Nhs.Api.csproj", "{21F15E96-314F-4F39-822F-C2568CDC4A5A}"
-	ProjectSection(ProjectDependencies) = postProject
-		{9F1B0470-E809-49FE-A6E8-152C7EBD012E} = {9F1B0470-E809-49FE-A6E8-152C7EBD012E}
-	EndProjectSection
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "LearningHub.Nhs.Api.Shared", "WebAPI\LearningHub.Nhs.Api.Shared\LearningHub.Nhs.Api.Shared.csproj", "{719833B9-EC79-48F2-9123-C4DF111AE9AA}"
 EndProject
@@ -60,9 +52,6 @@ EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "AdminUI", "AdminUI", "{9642BC19-BAE7-45A9-B4F2-8D7529786CDC}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "LearningHub.Nhs.AdminUI", "AdminUI\LearningHub.Nhs.AdminUI\LearningHub.Nhs.AdminUI.csproj", "{1C97A3C2-73E8-4AFF-92EF-F65B4899FADB}"
-	ProjectSection(ProjectDependencies) = postProject
-		{9F1B0470-E809-49FE-A6E8-152C7EBD012E} = {9F1B0470-E809-49FE-A6E8-152C7EBD012E}
-	EndProjectSection
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "OpenAPI", "OpenAPI", "{66ED23A2-F15A-4ECB-A84D-736C95BEFC61}"
 EndProject

LearningHub.Nhs.WebUI/Startup/ServiceMappings.cs

@@ -164,7 +164,7 @@ public static void AddLearningHubMappings(this IServiceCollection services, ICon
                 return new TELBlazorBaseComponentConfiguration
                 {
                     JSEnabled = jsEnabled,
-                    HostType = $"{configuration["Properties:Environment"]} {configuration["Properties:Application"]}",
+                    HostType = $"{configuration["Environment"]} {configuration["Properties:Application"]}",
                 };
             });