Skip to content

Commit b7908e7

Browse files
authored
Merge pull request #242 from TechnologyEnhancedLearning/RC
Merge RC changes to LH Phoenix
2 parents 51292ec + 9459509 commit b7908e7

File tree

4 files changed

+20
-30
lines changed

4 files changed

+20
-30
lines changed

LearningHub.Nhs.WebUI/Helpers/ViewActivityHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ public static string GetDurationText(this int durationInMilliseconds)
300300
else
301301
{
302302
duration = $"{t.Minutes}min {t.Seconds}sec";
303-
duration = duration.Replace("0min", string.Empty);
303+
duration = duration.StartsWith("0min") ? duration.Replace("0min", string.Empty) : duration;
304304
}
305305
}
306306
}

LearningHub.Nhs.WebUI/Styles/nhsuk/layout.scss

Lines changed: 14 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@
5858
flex: 1 0 0;
5959
}
6060

61-
.nhsuk-header__logo .nhsuk-header__link--service {
62-
display:inline-flex;
61+
.nhsuk-header__logo .nhsuk-header__link--service {
62+
display: inline-flex;
6363
}
6464

6565
.nhsuk-header__service-name {
@@ -90,22 +90,15 @@
9090
height: px2rem(18);
9191
text-align: center;
9292
border-radius: px2rem(9);
93-
padding:px2rem(1) px2rem(3) 0;
93+
padding: px2rem(1) px2rem(3) 0;
9494
}
9595

9696
.nhsuk-header__menu {
9797
display: none;
9898
}
9999

100-
.nhsuk-header__search {
101-
.nhsuk-search__input {
102-
width: px2rem(260);
103-
}
104-
105-
label {
106-
color: #E0E0E6;
107-
}
108-
100+
.nhsuk-header__search .nhsuk-search__input {
101+
width: px2rem(260);
109102
}
110103

111104
.nhsuk-header__search {
@@ -135,7 +128,7 @@
135128
}
136129

137130
.beta-banner + div {
138-
border-top:1px solid $color_nhsuk-grey-3;
131+
border-top: 1px solid $color_nhsuk-grey-3;
139132
}
140133

141134
.beta-banner__beta-box {
@@ -194,14 +187,14 @@
194187
@media (min-width: px2rem(990)) {
195188

196189
.nhsuk-header__navigation-item--current a {
197-
border-bottom:4px solid $nhsuk-grey-lighter;
198-
font-weight:normal;
190+
border-bottom: 4px solid $nhsuk-grey-lighter;
191+
font-weight: normal;
199192
}
200193

201194
.nhsuk-header__navigation-link {
202-
position:relative;
195+
position: relative;
203196
}
204-
197+
205198
.nhsuk-header__navigation-item:last-child {
206199
margin-right: 16px;
207200
}
@@ -275,7 +268,7 @@
275268
text-align: center;
276269
margin: 0;
277270
right: 0;
278-
font-weight:600;
271+
font-weight: 600;
279272
}
280273

281274
.nhsuk-header__search-form {
@@ -300,7 +293,7 @@
300293
background: $nhsuk-error-color;
301294
color: $nhsuk-white;
302295
min-width: px2rem(18);
303-
width:fit-content;
296+
width: fit-content;
304297
height: px2rem(18);
305298
text-align: center;
306299
border-radius: px2rem(9);
@@ -349,7 +342,7 @@
349342
}
350343

351344
.nhsuk-header__logo {
352-
max-width:none;
345+
max-width: none;
353346
}
354347

355348
.nhsuk-header__mobile-only-nav {
@@ -409,7 +402,7 @@
409402
}
410403

411404
.nhsuk-header__search .nhsuk-search__submit {
412-
padding-top:nhsuk-spacing(1);
405+
padding-top: nhsuk-spacing(1);
413406
}
414407

415408
.nhsuk-header__menu {

LearningHub.Nhs.WebUI/Views/MyLearning/Index.cshtml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,4 @@
223223
</div>
224224
</div>
225225
</div>
226-
</div>
227-
228-
229-
226+
</div>

LearningHub.Nhs.WebUI/Views/Resource/_ResourceItem.cshtml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@
9292
@* Weblink *@
9393
@if (canShowMoreDetails && resourceItem.ResourceTypeEnum == ResourceTypeEnum.WebLink)
9494
{
95-
<div class="nhsuk-card nhsuk-bg-light-blue">
95+
<div id="resourcePg" class="nhsuk-card nhsuk-bg-light-blue">
9696
<div class="nhsuk-card__content">
9797
<p class="nhsuk-body-l nhsuk-u-margin-bottom-3">Visit site:</p>
9898
@{
@@ -103,7 +103,7 @@
103103
displayText = resourceItem.WebLinkDetails.Url;
104104
}
105105
}
106-
<p class="nhsuk-body-l word-break__break-word"><a href="@GetWeblinkNavigateLink(resourceItem.WebLinkDetails.Url)" target="_blank">@displayText</a></p>
106+
<p class="nhsuk-body-l word-break__break-word"><a v-on:click=checkUserCertificateAvailability(@resourceItem.Id) href="@GetWeblinkNavigateLink(resourceItem.WebLinkDetails.Url)" target="_blank">@displayText</a></p>
107107
</div>
108108
</div>
109109
}
@@ -127,12 +127,12 @@
127127
@if (canShowMoreDetails && resourceItem.ResourceTypeEnum == ResourceTypeEnum.GenericFile)
128128
{
129129
<div class="resource-panel-container">
130-
<div class="nhsuk-card nhsuk-bg-light-blue">
130+
<div id="resourcePg" class="nhsuk-card nhsuk-bg-light-blue">
131131
<div class="nhsuk-card__content">
132132
<p class="nhsuk-body-l nhsuk-u-margin-bottom-3">Download:</p>
133133
<p class="nhsuk-body-l word-break__break-word">
134134
<span class="nhsuk-u-margin-right-4 pill @UtilityHelper.GetPillColour(resourceItem.GenericFileDetails.File.FileName)">@GetFileExtension(resourceItem.GenericFileDetails.File.FileName)</span>
135-
<a class="nhsuk-u-margin-right-4" href="@GetDownloadResourceLink(resourceItem.GenericFileDetails.File.FilePath, resourceItem.GenericFileDetails.File.FileName)">@resourceItem.GenericFileDetails.File.FileName</a> (@resourceItem.GenericFileDetails.File.FileSizeKb KB)
135+
<a v-on:click=checkUserCertificateAvailability(@resourceItem.Id) class="nhsuk-u-margin-right-4" href="@GetDownloadResourceLink(resourceItem.GenericFileDetails.File.FilePath, resourceItem.GenericFileDetails.File.FileName)">@resourceItem.GenericFileDetails.File.FileName</a> (@resourceItem.GenericFileDetails.File.FileSizeKb KB)
136136
</p>
137137
</div>
138138
</div>

0 commit comments

Comments
 (0)