Skip to content

Commit c4c9203

Browse files
TD-3688: Issue fix for Completed status resource showing in In progress tray
1 parent be3f312 commit c4c9203

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

WebAPI/LearningHub.Nhs.Database/Stored Procedures/Resources/GetDashboardResources.sql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,8 @@ BEGIN
223223
BEGIN
224224
INSERT INTO @MyActivity
225225
SELECT TOP (@MaxRows) ra.ResourceId, MAX(ra.Id) ResourceActivityId
226-
FROM activity.ResourceActivity ra
226+
FROM
227+
(SELECT a.* FROM activity.ResourceActivity a INNER JOIN (SELECT ResourceId, MAX(Id) as id FROM activity.ResourceActivity GROUP BY ResourceId,ActivityStatusId ) AS b ON a.ResourceId = b.ResourceId AND a.id = b.id order by a.Id desc OFFSET 0 ROWS) ra
227228
JOIN [resources].[Resource] r ON ra.ResourceId = r.Id
228229
JOIN [resources].[ResourceVersion] rv ON rv.Id = ra.ResourceVersionId
229230
LEFT JOIN [resources].[AssessmentResourceVersion] arv ON arv.ResourceVersionId = ra.ResourceVersionId
@@ -234,7 +235,7 @@ BEGIN
234235
AND (
235236
(r.ResourceTypeId IN (1, 5, 8, 10, 12) AND ra.ActivityStatusId <> 1)
236237
OR (r.ResourceTypeId IN (2, 7) AND (mar.Id IS NULL OR (mar.Id IS NOT NULL AND mar.PercentComplete < 100) OR ra.ActivityStart < '2020-09-07 00:00:00 +00:00'))
237-
OR (r.ResourceTypeId = 6 AND sa.CmiCoreLesson_status NOT IN (3, 5))
238+
OR (r.ResourceTypeId = 6 AND (sa.CmiCoreLesson_status NOT IN (3, 5) AND (ra.ActivityStatusId NOT IN(3, 5))))
238239
OR (r.ResourceTypeId IN (9) AND ra.ActivityStatusId NOT IN (6))
239240
OR (r.ResourceTypeId = 11 AND ((ara.Id IS NOT NULL AND ara.score < arv.PassMark) OR ra.ActivityStatusId IN (1)))
240241
)

0 commit comments

Comments
 (0)