Skip to content

Commit c8ed837

Browse files
committed
take latest cahnges from RC
2 parents 4a8372f + 5017fc0 commit c8ed837

File tree

5 files changed

+26
-3
lines changed

5 files changed

+26
-3
lines changed

LearningHub.Nhs.WebUI/Controllers/OpenAthensController.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,11 @@ public ActionResult Login(string returnUrl, bool invalidScope = false)
235235
return this.View();
236236
}
237237

238+
if (string.IsNullOrWhiteSpace(this.authConfig.ClientId) || string.IsNullOrWhiteSpace(this.Settings.LearningHubWebUiUrl))
239+
{
240+
throw new Exception("ClientId or origin are empty.");
241+
}
242+
238243
var authUri = OpenAthensOpenIdConnect.GetAuthServerUri(this.authConfig, this.Settings, returnUrl);
239244

240245
return this.Redirect(authUri.AbsoluteUri);

WebAPI/LearningHub.Nhs.Database/Tables/Resource/ExternalReference.sql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,6 @@ REFERENCES [resources].[ResourceReference] ([Id])
2020
GO
2121

2222
ALTER TABLE [resources].[ExternalReference] CHECK CONSTRAINT [FK_ExternalReference_ResourceReference]
23+
GO
24+
CREATE NONCLUSTERED INDEX [IX_Resources_ExternalReference_ExternalReference_Deleted] ON [resources].[ExternalReference]([ExternalReference], [Deleted])
2325
GO

WebAPI/LearningHub.Nhs.Database/Tables/Resource/ScormResourceVersion.sql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,6 @@ GO
3939

4040
ALTER TABLE [resources].[ScormResourceVersion] ADD CONSTRAINT [FK_ScormResourceVersion_EsrLinkType] FOREIGN KEY([EsrLinkTypeId])
4141
REFERENCES [resources].[EsrLinkType] ([Id])
42+
GO
43+
CREATE NONCLUSTERED INDEX [IX_Resources_ScormResourceVersion_ResourceVersionId] ON [resources].[ScormResourceVersion]([ResourceVersionId])
4244
GO

WebAPI/LearningHub.Nhs.Database/Tables/Resource/ScormResourceVersionManifest.sql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,3 +40,5 @@ GO
4040
ALTER TABLE [resources].[ScormResourceVersionManifest] ADD CONSTRAINT [FK_ScormResourceVersionManifest_ScormResourceVersion] FOREIGN KEY([ScormResourceVersionId])
4141
REFERENCES [resources].[ScormResourceVersion] ([Id])
4242
GO
43+
CREATE NONCLUSTERED INDEX [IX_Resources_ScormResourceVersionManifest_ScormResourceVersionId_ManifestURL]ON [resources].[ScormResourceVersionManifest] ([ScormResourceVersionId])INCLUDE ([ManifestURL])
44+
GO

WebAPI/LearningHub.Nhs.Repository/Resources/BlockCollectionRepository.cs

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,22 @@ public async Task DeleteBlockCollection(int userId, int blockCollectionId)
8383

8484
foreach (var id in collectionIds)
8585
{
86-
using (var lhContext = new LearningHubDbContext(this.DbContext.Options))
86+
_ = Task.Run(async () =>
8787
{
88-
_ = lhContext.Database.ExecuteSqlRawAsync("resources.BlockCollectionDelete @p0", new SqlParameter("@p0", SqlDbType.Int) { Value = id });
89-
}
88+
var lhContext = new LearningHubDbContext(this.DbContext.Options);
89+
try
90+
{
91+
await lhContext.Database.ExecuteSqlRawAsync("resources.BlockCollectionDelete @p0", new SqlParameter("@p0", SqlDbType.Int) { Value = id });
92+
}
93+
catch (Exception ex)
94+
{
95+
throw new Exception(ex.Message);
96+
}
97+
finally
98+
{
99+
await lhContext.DisposeAsync();
100+
}
101+
});
90102
}
91103
}
92104

0 commit comments

Comments
 (0)