Skip to content

Commit e1cdfb3

Browse files
Merge pull request #1123 from TechnologyEnhancedLearning/Develop/Fixes/TD-5143-issue-reading-twice-with-screen-reader-on-contribute-resource-screens
TD-5143: issue reading twice with screen reader on contribute resourc…
2 parents 0f4508f + b40f736 commit e1cdfb3

File tree

3 files changed

+16
-5
lines changed

3 files changed

+16
-5
lines changed

LearningHub.Nhs.WebUI/Scripts/vuesrc/ckeditorwithhint.vue

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,26 @@
11
<template>
22
<div>
3-
<ckeditor v-model="description" :config="editorConfig" @ready="onEditorReady" @blur="onBlur"></ckeditor>
4-
<div :class="[`pt-2 footer-text${this.valid ? '' : ' text-danger'}`]">{{ hint }}</div>
3+
<ckeditor v-model="description"
4+
:config="editorConfig"
5+
@ready="onEditorReady"
6+
@blur="onBlur"
7+
tabindex="0"
8+
:aria-describedby="'editor-hint'"
9+
role="textbox"></ckeditor>
10+
<div :id="'editor-hint'"
11+
:class="[`pt-2 footer-text${this.valid ? '' : ' text-danger'}`]"
12+
aria-live="polite">
13+
{{ hint }}
14+
</div>
515
</div>
616
</template>
717

18+
819
<script lang="ts">
920
import Vue, { PropOptions } from 'vue';
1021
import CKEditorToolbar from './models/ckeditorToolbar';
1122
import CKEditor from 'ckeditor4-vue/dist/legacy.js';
12-
import {getRemainingCharacters, getRemainingCharactersFromHtml} from "./helpers/ckeditorValidationHelper";
23+
import { getRemainingCharacters, getRemainingCharactersFromHtml } from "./helpers/ckeditorValidationHelper";
1324
1425
const getCharactersText = (n: number) => n === 1 ? `${n} character` : `${n} characters`;
1526

LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute/ContentCommon.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
Write a description that explains the resource and its benefits to learners.
6363
</div>
6464
<div class="col-12 my-3">
65-
<ckeditorwithhint :initialValue="this.resourceDescription" :maxLength="1800" @blur="saveDescription" @change="changeDescription" />
65+
<ckeditorwithhint :initialValue="this.resourceDescription" :maxLength="1800" @blur="saveDescription" @change="changeDescription"/>
6666
</div>
6767
</div>
6868

LearningHub.Nhs.WebUI/Scripts/vuesrc/globalcomponents/CharacterCount.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
</div>
7878
<div id="character-count-component-status-message"
7979
class="character-count-component-status-message"
80-
aria-live="polite">
80+
>
8181
<span>
8282
You have {{ charactersDiff }} character{{ charactersDiffPlural ? 's' : '' }} remaining
8383
</span>

0 commit comments

Comments
 (0)