Skip to content

Commit ec0ea98

Browse files
authored
Merge pull request #113 from TechnologyEnhancedLearning/refactor-optimisations
feat(docs): want a version bump to see intended load metric improvement
2 parents ce5a065 + 5dcdd1b commit ec0ea98

File tree

1 file changed

+56
-20
lines changed

1 file changed

+56
-20
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 56 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -25,28 +25,64 @@ _Paste screenshots for all views created or changed: mobile, tablet and desktop,
2525
### Logging
2626
_Provide description of any component scoped logging or specific level logging to check
2727

28-
### Size Optimisation
29-
_Provide wasm size comparison between prod and dev showcases, does it exceed 8Mb
30-
- Network tab in Chrome
31-
- Disable cache
32-
- reload
33-
- filter wasm dll js dotnet.wasm, blazor.webassembly.js, TELBlazor.dll
34-
- if using compression check .br or .gz (if Content-Encoding: br or gz is in headers)
35-
- Sum up
36-
37-
| Measure | [Dev](https://technologyenhancedlearning.github.io/TELBlazor-DevShowCase/) Value | [Prod](https://technologyenhancedlearning.github.io/TELBlazor/) Value | Difference | Notes |
38-
|----------|--------------------------------------------------------------------------|----------------------------------------------------------------------|-------|-------|
39-
| Load Size | X.X MB | |
40-
| Lighthouse Accessibility Score | Y.Y MB | |
41-
| Difference | | |
28+
### Performance comparison
4229

30+
Complete the below comparison table to check for any concerning changes in performance.
31+
32+
Use **Incognito** mode and **disable cache** in the Network tab to get a cold load comparison.
33+
34+
**Lighthouse**
35+
36+
1. Open the Developer Tools (F12 or Ctrl+Shift+I).
37+
2. Go to the **Lighthouse** tab.
38+
3. Deselect the "SEO" category.
39+
4. Select "Desktop" for the device.
40+
5. Choose "Navigation (Analyze page load)".
41+
6. Click "Analyze page load" and wait for the results.
42+
43+
Here's an example of what to look for and compare:
44+
45+
* **First Contentful Paint**: The time it takes for the first text or image to appear. A lower value is better.
46+
* **Speed Index**: How quickly content is visually displayed during page load. A lower value is better.
47+
* **Largest Contentful Paint**: The time it takes for the largest content element to be rendered. A lower value is better.
48+
* **Total Blocking Time**: The total amount of time between First Contentful Paint and Time to Interactive where the main thread was blocked for long enough to prevent input responsiveness. A lower value is better.
49+
50+
**Network**
51+
52+
1. Go to the **Network** tab.
53+
2. Ensure **"Disable cache"** is checked.
54+
3. **Clear** the log.
55+
4. **Preserve log** can be checked to maintain a history of requests.
56+
5. Perform a hard reload (Ctrl+Shift+R or Cmd+Shift+R).
57+
6. Copy and paste the bottom line of the log to get the following metrics:
58+
59+
* **Requests**: The total number of requests made.
60+
* **Transferred**: The compressed size of all transferred resources.
61+
* **Resources**: The total uncompressed size of all resources.
62+
* **Finish**: The time from the request initiation to the completion of the last response.
63+
64+
You can also use the `.wasm` filter in the Network tab to inspect the sizes of individual WebAssembly files.
65+
66+
---
67+
68+
### Comparison Table
69+
70+
Please fill in the table below with the values from both the Dev and Prod environments.
71+
*or just check the values if its quicker and make sure to highlight anything concerning*
72+
| Measure | [Dev Showcase](https://technologyenhancedlearning.github.io/TELBlazor-DevShowCase/) | [Prod](https://technologyenhancedlearning.github.io/TELBlazor/) | Notes (E.g. Significant change) |
73+
| :--- | :--- | :--- | :--- |
74+
| **Lighthouse Performance Score** | | | |
75+
| **Lighthouse Accessibility Score** | | | |
76+
| **Lighthouse Best Practices Score** | | | |
77+
| **First Contentful Paint** | | | |
78+
| **Speed Index** | | | |
79+
| **Total Blocking Time** | | | |
80+
| **Largest Contentful Paint** | | | |
81+
| **Transferred (Cold Load Payload)** | | | |
82+
| **Resources (Full App Weight)** | | | |
83+
| **Requests** | | | |
84+
| **Finish Time** | | | |
4385

44-
-----
45-
### Recommended Prepipeline steps
46-
These test are run by the pipeline but running them locally can be convenient to see issues early or to debug issues seen in the pipeline locally.
47-
- Run against release configuration by select release configuration at the the top of solution explorer (to check against optimisation such as tree shaking for example)
48-
- clean rebuild the solution
49-
- run tests against release
5086

5187
-----
5288
### Developer checks

0 commit comments

Comments
 (0)