feat(pr readme): we're due a version bump i feel

Author: Phil-NHS

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,48 +1,67 @@
 # PR Template
 
-## TODO:
-Test it here too
-https://technologyenhancedlearning.github.io/GitPageBlazorWASM-TestGHPage/
-check version matches branch name and pullrequest release
-- maybe a rule that any introduced css for example if bringing in an enum. needs to be refactored to nhse-tel? so tel-nhse is source of truth on all things css
-
-
-## TODO: About
-- SO FAR no js controllers are not going to be covered in testing in the package it will be done by how used in LH
-But in future we could simulate them with just an api with stock response or find a programatic way, or build a hosted environment.
-The gh-page are pure wasm so not supported for nojs
-
-- brave check no js (Locally not on wasm static test page)
-
-## TODO: This is just replicating LH for now ... ideas
-- Link to replicated component
-- Link design confluence if coming from design
-- Tick box for JS
-- If testers find an issue create an automated test of what they did, even potentially with playright record test functionality
-- something about is there a linked lh branch using the change
-
-### JIRA link
+### JIRA/RoadMap
+_Provide your ticket number
 [TD-####](https://hee-tis.atlassian.net/browse/TD-####)
+[Git Ticket Board](https://github.com/orgs/TechnologyEnhancedLearning/projects/9)[Ticket Board](https://github.com/orgs/TechnologyEnhancedLearning/projects/9)
+[Git Ticket](https://github.com/TechnologyEnhancedLearning/TELBlazor/issues/42)
 
 ### Description
 _Describe what has changed and how that will affect the app. If relevant, add links to any sources/documentation you used. Highlight anything unusual and give people context around particular decisions._
 
+### Resulting Dev package
+_Your dev generated package name and reference
+[TELBlazor published packages](https://github.com/TechnologyEnhancedLearning/TELBlazor/pkgs/nuget/TELBlazor.Components)
+Dev packages are follow by branch name -branch-name and are generated
+Will this code change result in a production package version increase 
+
 ### Screenshots
 _Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors._
 
+### Linked package consumer tasks
+[TD-####](https://hee-tis.atlassian.net/browse/TD-####)
+[ ] - consumers also need to update nhsuk css dependency to : __put_required_nhsuk_semantic_version_here__
+
+### Logging
+_Provide description of any component scoped logging or specific level logging to check
+
 -----
 ### Developer checks
 (Leave tasks unticked if they haven't been appropriate for your ticket.)
 
 I have:
-- [ ] Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
-- [ ] Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
-- [ ] Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
-- [ ] Tested any Views or partials created or changed with [Wave Chrome plugin](https://chrome.google.com/webstore/detail/wave-evaluation-tool/jbbplnpkjmmeebjpijfedlgcdilocofh/related). Addressed any valid accessibility issues and documented any invalid errors
-- [ ] Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need  to be tested to ensure nothing is broken
-- [ ] Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
-Either:
-- [ ] Documented my work in [Confluence](https://hee-tis.atlassian.net/wiki/spaces/TP/pages/3461087233/Development), updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
-  - [doc_1_here](link_1_here)
-Or:
-- [ ] Confirmed that none of the work that I have undertaken requires any updates to documentation
+- [ ] Provided showcase example of component if applicable
+- [ ] Added appropriate logging and scopped logging reporting in appsettings for component if applicable
+- [ ] Updated readme documentation
+- [ ] Updated showcase documentation for component
+- [ ] I have locally run tests against a local package (not just using project reference)
+- [ ] Used a browser set to No Js before using it to locally run and test changes (recommend brave as second browser)
+- [ ] Written Unit tests with accesibility syntax
+- [ ] Written E2E tests with accesibility syntax and accessibility test
+- [ ] Tested components with [Wave Chrome plugin](https://chrome.google.com/webstore/detail/wave-evaluation-tool/jbbplnpkjmmeebjpijfedlgcdilocofh/related). Addressed any valid accessibility issues and documented any invalid errors
+- [ ] [Check code coverage](https://technologyenhancedlearning.github.io/TELBlazor-CodeReport/) or locally with local report generation
+- [ ] Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the PR and need  to be tested to ensure nothing is broken
+- [ ] Tested in [Dev Showcase](https://technologyenhancedlearning.github.io/TELBlazor-DevShowCase/) (including logging by using log level switcher)
+- [ ] Scanned over my pull request and commented with any useful explanations/questions to reviewers
+- [ ] Scanned over cicd warnings
+
+---
+### Peer Reviewers and Assignee checks before Approval
+- [ ] Feedback has been provided
+- [ ] Project has been run locally (you can provide pr feedback via vs if desired)
+- [ ] Locally checked in browser set to No Js from before load (recommend Brave with no js settings)
+- [ ] [Dev Showcase](https://technologyenhancedlearning.github.io/TELBlazor-DevShowCase/) was checked and it was checked the package number matched the PR
+- [ ] In Dev Showcase checked against different logging levels if applicable (use log level switcher to change level)
+- [ ] All conversations have been responded to (emoji will do) and marked resolved
+- [ ] Out of scope code observations have been recorded to inform future tasks
+- [ ] Common questions / Architectural explanations decisions from PR documented
+- [ ] [Check code coverage](https://technologyenhancedlearning.github.io/TELBlazor-CodeReport/)
+- [ ] Should E2E or Unit test have been added
+- [ ] If the published dev package is linked and used in tandom with a package consumer task is it working locally (Not a hard requirement but useful in case changes required)
+- [ ] Checked component readme in Showcase
+
+---
+### Post PR Intentions and Actions
+- [ ] On merge will someone check [Prod Showcase](https://technologyenhancedlearning.github.io/TELBlazor/)
+- [ ] Tick yes if consuming projects need a version bump and/or code changes to take advantage of new components etc
+- [ ] If there is a linked consuming project task has the task assignee, or task been updated to know the package is available as a dev/prod version and been provided the version number.