Skip to content

Update type styling on panel component #3

@wellhairy

Description

@wellhairy

We should consider updating the type styling on the new panel component and pushing the changes back to the Main NHS repo.

The type styling is using

  • standard h1 bottom margin
  • equal top and botttom margin

H1 line height often creates between 3 and 5px differnece so this often makes the content look like it's falling when content wrapped in a box or there isn't enough white space. This results in type styling that looks incorrect even if it's using standard styling. We shoudld:

  • Reduce the bottom margin under the H1 to match the outside padding so the white space looks more consistent
  • And, either pull the 1st heading up with a negative margin or tweak the top and bottom padding to remover space at the top of the created by the heading line height.

Before
Image

After
Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions