Skip to content

Commit 43bd978

Browse files
author
“TechnourceDeveloper”
committed
Add comments in functions and change more screens variable name
1 parent ec625ee commit 43bd978

File tree

4 files changed

+11
-8
lines changed

4 files changed

+11
-8
lines changed

app/src/main/java/com/technource/android/ui/moreModule/AboutActivity.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import com.example.android_kotlin_boilerplate.databinding.ActivityAboutBinding
88
import com.technource.android.base.BaseActivity
99
import com.technource.android.commonInterface.RecyclerviewInterface
1010
import com.technource.android.ui.viewTermsModule.TermsViewActivity
11+
import com.technource.android.utils.Constants
1112

1213
class AboutActivity : BaseActivity<ActivityAboutBinding>() {
1314
override fun getViewBinding() = ActivityAboutBinding.inflate(layoutInflater)
@@ -40,7 +41,7 @@ class AboutActivity : BaseActivity<ActivityAboutBinding>() {
4041
moreListAdapter.setOnItemClick(object : RecyclerviewInterface {
4142
override fun onItemClick(position: Int) {
4243
val intent = Intent(this@AboutActivity, TermsViewActivity::class.java)
43-
intent.putExtra("url", moreModel[position].url)
44+
intent.putExtra(Constants.INTENT_KEY_URL, moreModel[position].url)
4445
startActivity(intent)
4546
overridePendingTransition(R.anim.slide_in_up, R.anim.nothing_ani)
4647
}

app/src/main/java/com/technource/android/ui/moreModule/MoreViewModel.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ class MoreViewModel : ViewModel() {
3030
*/
3131
private fun fetchData() {
3232
val moreList = listOf(
33-
MoreModel("About us", Constants.aboutUs),
34-
MoreModel("Terms & Condition", Constants.termsNCondition),
35-
MoreModel("Privacy Policy", Constants.privacyPolicy)
33+
MoreModel("About us", Constants.ABOUT_US_LINK),
34+
MoreModel("Terms & Condition", Constants.TERMS_CONDITION_LINK),
35+
MoreModel("Privacy Policy", Constants.PRIVACY_POLICY_LINK)
3636
)
3737
more.value = moreList
3838
}

app/src/main/java/com/technource/android/ui/viewTermsModule/TermsViewActivity.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,13 @@ import android.webkit.WebView
88
import android.webkit.WebViewClient
99
import com.example.android_kotlin_boilerplate.databinding.ActivityTermsViewBinding
1010
import com.technource.android.base.BaseActivity
11+
import com.technource.android.utils.Constants
1112

1213
class TermsViewActivity : BaseActivity<ActivityTermsViewBinding>() {
1314
override fun getViewBinding() = ActivityTermsViewBinding.inflate(layoutInflater)
1415

1516
override fun initObj() {
16-
val url: String? = intent.getStringExtra("url")
17+
val url: String? = intent.getStringExtra(Constants.INTENT_KEY_URL)
1718
// Configure WebView settings
1819
val webViewSettings = binding.webView.settings
1920
webViewSettings.javaScriptEnabled = true

app/src/main/java/com/technource/android/utils/Constant.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@ class Constants {
99
const val IS_INTRO_SCREEN_DONE = "is_intro_screen_done"
1010
const val IS_LOGGED_IN = "is_logged_in"
1111
const val GIT_REPO_LINK = "https://github.com/TechnourceDeveloper/Android-Kotlin-Boilarplate"
12-
const val aboutUs = "https://www.technource.com/services/"
13-
const val termsNCondition = "https://www.technource.com/terms-conditions/"
14-
const val privacyPolicy = "https://technource.com/privacy-policy/"
12+
const val ABOUT_US_LINK = "https://www.technource.com/services/"
13+
const val TERMS_CONDITION_LINK = "https://www.technource.com/terms-conditions/"
14+
const val PRIVACY_POLICY_LINK = "https://technource.com/privacy-policy/"
15+
const val INTENT_KEY_URL = "url"
1516
}
1617
}

0 commit comments

Comments
 (0)