Skip to content

Commit f73dadb

Browse files
committed
[REF] stop auto-installing flanker
Reasons for the change: 1. Flanker project is dead (last commit in 2023). 2. Installing with `[validator]` depends on redis. 3. If you don't deploy a Redis server, validating an email takes ~20s. 4. If you deploy the Redis server, password auth is not supported. 5. Password auth support cannot be added upstream because of point 1. Extra notes: - Upstream removed flanker for the same reasons in Odoo 19.1: odoo/odoo#232653 - Continuation of #579 - Whoever wants it can add it back with a simple line in their pip dependencies list. @moduon MT-13982
1 parent 0025c6c commit f73dadb

File tree

5 files changed

+0
-20
lines changed

5 files changed

+0
-20
lines changed

15.0.Dockerfile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,6 @@ RUN build_deps=" \
148148
click-odoo-contrib \
149149
debugpy \
150150
pydevd-odoo \
151-
flanker[validator] \
152151
geoip2 \
153152
"git-aggregator<3.0.0" \
154153
inotify \
@@ -162,9 +161,6 @@ RUN build_deps=" \
162161
watchdog \
163162
wdb \
164163
&& (python3 -m compileall -q /usr/local/lib/python3.8/ || true) \
165-
# generate flanker cached tables during install when /usr/local/lib/ is still intended to be written to
166-
# https://github.com/Tecnativa/doodba/issues/486
167-
&& python3 -c 'from flanker.addresslib import address' >/dev/null 2>&1 \
168164
&& apt-get purge -yqq $build_deps \
169165
&& apt-get autopurge -yqq \
170166
&& rm -Rf /var/lib/apt/lists/* /tmp/*

16.0.Dockerfile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ RUN build_deps=" \
153153
click-odoo-contrib \
154154
debugpy \
155155
pydevd-odoo \
156-
"flanker[validator] @ git+https://github.com/mailgun/flanker.git@v0.9.15" \
157156
geoip2 \
158157
"git-aggregator==4.0" \
159158
inotify \
@@ -167,9 +166,6 @@ RUN build_deps=" \
167166
watchdog \
168167
wdb \
169168
&& (python3 -m compileall -q /usr/local/lib/python3.10/ || true) \
170-
# generate flanker cached tables during install when /usr/local/lib/ is still intended to be written to
171-
# https://github.com/Tecnativa/doodba/issues/486
172-
&& python3 -c 'from flanker.addresslib import address' >/dev/null 2>&1 \
173169
&& apt-get purge -yqq $build_deps \
174170
&& apt-get autopurge -yqq \
175171
&& rm -Rf /var/lib/apt/lists/* /tmp/*

17.0.Dockerfile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@ RUN build_deps=" \
152152
click-odoo-contrib \
153153
debugpy \
154154
pydevd-odoo \
155-
"flanker[validator] @ git+https://github.com/mailgun/flanker.git@v0.9.15" \
156155
geoip2 \
157156
"git-aggregator==4.0" \
158157
inotify \
@@ -166,9 +165,6 @@ RUN build_deps=" \
166165
watchdog \
167166
wdb \
168167
&& (python3 -m compileall -q /usr/local/lib/python3.10/ || true) \
169-
# generate flanker cached tables during install when /usr/local/lib/ is still intended to be written to
170-
# https://github.com/Tecnativa/doodba/issues/486
171-
&& python3 -c 'from flanker.addresslib import address' >/dev/null 2>&1 \
172168
&& apt-get purge -yqq $build_deps \
173169
&& apt-get autopurge -yqq \
174170
&& rm -Rf /var/lib/apt/lists/* /tmp/*

18.0.Dockerfile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,6 @@ RUN build_deps=" \
154154
click-odoo-contrib \
155155
debugpy \
156156
pydevd-odoo \
157-
"flanker[validator] @ git+https://github.com/mailgun/flanker.git@v0.9.15" \
158157
geoip2 \
159158
"git-aggregator==4.0" \
160159
inotify \
@@ -168,9 +167,6 @@ RUN build_deps=" \
168167
watchdog \
169168
wdb \
170169
&& (python3 -m compileall -q /usr/local/lib/python3.10/ || true) \
171-
# generate flanker cached tables during install when /usr/local/lib/ is still intended to be written to
172-
# https://github.com/Tecnativa/doodba/issues/486
173-
&& python3 -c 'from flanker.addresslib import address' >/dev/null 2>&1 \
174170
&& apt-get purge -yqq $build_deps \
175171
&& apt-get autopurge -yqq \
176172
&& rm -Rf /var/lib/apt/lists/* /tmp/*

19.0.Dockerfile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ RUN build_deps=" \
153153
click-odoo-contrib \
154154
debugpy \
155155
pydevd-odoo \
156-
"flanker[validator] @ git+https://github.com/mailgun/flanker.git@v0.9.15" \
157156
geoip2 \
158157
"git-aggregator==4.0" \
159158
inotify \
@@ -169,9 +168,6 @@ RUN build_deps=" \
169168
rlPyCairo \
170169
pycairo \
171170
&& (python3 -m compileall -q /usr/local/lib/python3.12/ || true) \
172-
# generate flanker cached tables during install when /usr/local/lib/ is still intended to be written to
173-
# https://github.com/Tecnativa/doodba/issues/486
174-
&& python3 -c 'from flanker.addresslib import address' >/dev/null 2>&1 \
175171
&& apt-get purge -yqq $build_deps \
176172
&& apt-get autopurge -yqq \
177173
&& rm -Rf /var/lib/apt/lists/* /tmp/*

0 commit comments

Comments
 (0)