Skip to content

Commit 5dc97cf

Browse files
committed
chore: fix phi4 comment copypasta referencing deepseek
1 parent 263943c commit 5dc97cf

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

ios/llama.cpp/common/chat.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1398,7 +1398,7 @@ static common_chat_params common_chat_params_init_phi_4(const common_chat_templa
13981398
// For Phi-4, we need to inject tools into the system message
13991399
// because the template expects tools in the system message with <|tool|> tags
14001400
// The Phi-4 template has issues with tool calls.
1401-
// It is advisable to use --chat-template-file models/templates/llama-cpp-deepseek-r1.jinja instead,
1401+
// It is advisable to use --chat-template-file models/templates/llama-cpp-microsoft-Phi-4-mini-instruct.jinja
14021402
// - It expects tools from the system message (instead of as a global variable as most templates).
14031403
// - It does not print tool calls (this is worked around by the Minja + the generic mode, but without the <|tool_call|> syntax)
14041404
// - With defaults, it prints tool call results (messages such as {"role": "tool", "name": "foo", "content": "42"}) as <|tool|>42<|end|> which conflicts with the tool description wrapping mechanism.

macos/llama.cpp/common/chat.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1398,7 +1398,7 @@ static common_chat_params common_chat_params_init_phi_4(const common_chat_templa
13981398
// For Phi-4, we need to inject tools into the system message
13991399
// because the template expects tools in the system message with <|tool|> tags
14001400
// The Phi-4 template has issues with tool calls.
1401-
// It is advisable to use --chat-template-file models/templates/llama-cpp-deepseek-r1.jinja instead,
1401+
// It is advisable to use --chat-template-file models/templates/llama-cpp-microsoft-Phi-4-mini-instruct.jinja
14021402
// - It expects tools from the system message (instead of as a global variable as most templates).
14031403
// - It does not print tool calls (this is worked around by the Minja + the generic mode, but without the <|tool_call|> syntax)
14041404
// - With defaults, it prints tool call results (messages such as {"role": "tool", "name": "foo", "content": "42"}) as <|tool|>42<|end|> which conflicts with the tool description wrapping mechanism.

src/llama.cpp/common/chat.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1398,7 +1398,7 @@ static common_chat_params common_chat_params_init_phi_4(const common_chat_templa
13981398
// For Phi-4, we need to inject tools into the system message
13991399
// because the template expects tools in the system message with <|tool|> tags
14001400
// The Phi-4 template has issues with tool calls.
1401-
// It is advisable to use --chat-template-file models/templates/llama-cpp-deepseek-r1.jinja instead,
1401+
// It is advisable to use --chat-template-file models/templates/llama-cpp-microsoft-Phi-4-mini-instruct.jinja
14021402
// - It expects tools from the system message (instead of as a global variable as most templates).
14031403
// - It does not print tool calls (this is worked around by the Minja + the generic mode, but without the <|tool_call|> syntax)
14041404
// - With defaults, it prints tool call results (messages such as {"role": "tool", "name": "foo", "content": "42"}) as <|tool|>42<|end|> which conflicts with the tool description wrapping mechanism.

0 commit comments

Comments
 (0)