-
Notifications
You must be signed in to change notification settings - Fork 1k
Open
Labels
stale: 30dNo interaction in the last 30 daysNo interaction in the last 30 days
Description
js_driver_napi.cc的CreateJsDriver方法中,未设置JSHVMInitParam的group_id,导致后续创建engine的时候,group_id固定为-1;
`
static napi_value CreateJsDriver(napi_env env, napi_callback_info info) {
#ifdef JS_V8
...
#elif JS_JSH
auto param = std::make_shared();
param->is_debug = is_dev_module;
// 此处需要设置group_id
if (has_vm_init_param) {
}
#else
auto param = std::make_shared<VMInitParam>();
#endif
...
}
`
但是如果设置了group_id,所有hippy engine共用一个js engine实例,会出现各种崩溃问题。
Metadata
Metadata
Assignees
Labels
stale: 30dNo interaction in the last 30 daysNo interaction in the last 30 days