Skip to content

Commit 617b5a0

Browse files
committed
Remove useless code
1 parent 88095f6 commit 617b5a0

File tree

4 files changed

+12
-31
lines changed

4 files changed

+12
-31
lines changed

src/common/core/InnerDatabase.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -645,12 +645,6 @@ void InnerDatabase::tryLoadIncremetalMaterial()
645645
if (!m_needLoadIncremetalMaterial) {
646646
return;
647647
}
648-
auto config = CommonCore::shared().getABTestConfig("clicfg_wcdb_incremental_backup");
649-
if (config.failed() || config.value().length() == 0
650-
|| atoi(config.value().data()) != 1) {
651-
m_needLoadIncremetalMaterial = false;
652-
return;
653-
}
654648

655649
const StringView &databasePath = getPath();
656650
StringView materialPath

src/common/core/operate/OperationQueue.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -524,11 +524,6 @@ void OperationQueue::asyncCheckpoint(const UnsafeStringView& path)
524524
Operation operation(Operation::Type::Checkpoint, path);
525525
Parameter parameter;
526526
double checkPointInterval = OperationQueueTimeIntervalForCheckpoint;
527-
auto config = CommonCore::shared().getABTestConfig("clicfg_wcdb_checkpoint_interval");
528-
if (config.valueOrDefault().length() > 0) {
529-
checkPointInterval = std::max(checkPointInterval, atof(config->data()));
530-
checkPointInterval = std::min(checkPointInterval, 600.0);
531-
}
532527
async(operation, checkPointInterval, parameter, AsyncMode::ForwardOnly);
533528
}
534529
}

src/common/repair/factory/FactoryBackup.cpp

Lines changed: 12 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -59,21 +59,16 @@ bool FactoryBackup::work(const UnsafeStringView& database, bool interruptible)
5959
bool FactoryBackup::doBackUp(const UnsafeStringView& database, bool interruptible)
6060
{
6161
Optional<size_t> incrementalMaterialSize = 0;
62-
auto config = CommonCore::shared().getABTestConfig("clicfg_wcdb_incremental_backup");
63-
bool incrememtalBackupEnable = config.succeed() && config.value().length() > 0
64-
&& atoi(config.value().data()) == 1;
6562
SharedIncrementalMaterial incrementalMaterial;
66-
if (incrememtalBackupEnable) {
67-
incrementalMaterial = CommonCore::shared().tryGetIncrementalMaterial(database);
68-
if (interruptible && incrementalMaterial != nullptr) {
69-
incrementalMaterialSize = saveIncrementalMaterial(database, incrementalMaterial);
70-
if (!incrementalMaterialSize.hasValue()) {
71-
return false;
72-
}
73-
if (Time::now().seconds() - incrementalMaterial->info.lastBackupTime < OperationQueueTimeIntervalForBackup
74-
&& incrementalMaterial->pages.size() < BackupMaxIncrementalPageCount) {
75-
return true;
76-
}
63+
incrementalMaterial = CommonCore::shared().tryGetIncrementalMaterial(database);
64+
if (interruptible && incrementalMaterial != nullptr) {
65+
incrementalMaterialSize = saveIncrementalMaterial(database, incrementalMaterial);
66+
if (!incrementalMaterialSize.hasValue()) {
67+
return false;
68+
}
69+
if (Time::now().seconds() - incrementalMaterial->info.lastBackupTime < OperationQueueTimeIntervalForBackup
70+
&& incrementalMaterial->pages.size() < BackupMaxIncrementalPageCount) {
71+
return true;
7772
}
7873
}
7974

@@ -103,12 +98,10 @@ bool FactoryBackup::doBackUp(const UnsafeStringView& database, bool interruptibl
10398
}
10499

105100
SharedIncrementalMaterial newIncrementalMaterial = backup.getIncrementalMaterial();
106-
if (incrememtalBackupEnable) {
107-
if (!saveIncrementalMaterial(database, newIncrementalMaterial).hasValue()) {
108-
return false;
109-
}
110-
CommonCore::shared().tryRegisterIncrementalMaterial(database, newIncrementalMaterial);
101+
if (!saveIncrementalMaterial(database, newIncrementalMaterial).hasValue()) {
102+
return false;
111103
}
104+
CommonCore::shared().tryRegisterIncrementalMaterial(database, newIncrementalMaterial);
112105

113106
if (interruptible) {
114107
notifiyBackupEnd(

src/objc/tests/repair/common/BackupTestCase.mm

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ - (void)setUp
4747
{
4848
[super setUp];
4949
self.objectCount = 100;
50-
[WCTDatabase setABTestConfigWithName:@"clicfg_wcdb_incremental_backup" andValue:@"1"];
5150
}
5251

5352
- (NSMutableArray<NSObject<RepairTestObject>*>*)objects

0 commit comments

Comments
 (0)