[ClangIR][Lowering][NFC] Split LowerToLLVM.h from LowerToLLVM.cpp (llvm#1102)

Fixed API compatibility issues for MLIR/LLVM API changes:
- Updated InlineAsmOp constructor to include tail_call_kind parameter
- Fixed VectorType creation using mlir::VectorType::get
- Updated GEP operations to use GEPNoWrapFlags::inbounds instead of bool
- Removed XFAIL markers from tests that now pass

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: 2 people

clang/include/clang/CIR/Dialect/IR/CIROps.td

@@ -4340,8 +4340,8 @@ def SqrtOp : UnaryFPToFPBuiltinOp<"sqrt", "SqrtOp">;
 def TruncOp : UnaryFPToFPBuiltinOp<"trunc", "FTruncOp">;
 
 def AbsOp : CIR_Op<"abs", [Pure, SameOperandsAndResultType]> {
-  let arguments = (ins PrimitiveSInt:$src, UnitAttr:$poison);
-  let results = (outs PrimitiveSInt:$result);
+  let arguments = (ins CIR_AnySignedIntOrVecOfSignedInt:$src, UnitAttr:$poison);
+  let results = (outs CIR_AnySignedIntOrVecOfSignedInt:$result);
   let summary = [{
     libc builtin equivalent abs, labs, llabs
 
@@ -4354,6 +4354,7 @@ def AbsOp : CIR_Op<"abs", [Pure, SameOperandsAndResultType]> {
     ```mlir
       %0 = cir.const #cir.int<-42> : s32i
       %1 = cir.abs %0 poison : s32i
+      %2 = cir.abs %3 : !cir.vector<!s32i x 4>
     ```
   }];
   let assemblyFormat = "$src ( `poison` $poison^ )? `:` type($src) attr-dict";

clang/include/clang/CIR/Dialect/IR/CIRTypes.h

@@ -182,6 +182,7 @@ class StructType
 
 bool isAnyFloatingPointType(mlir::Type t);
 bool isFPOrFPVectorTy(mlir::Type);
+bool isIntOrIntVectorTy(mlir::Type);
 } // namespace cir
 
 mlir::ParseResult parseAddrSpaceAttribute(mlir::AsmParser &p,

clang/include/clang/CIR/Dialect/IR/CIRTypes.td

@@ -60,6 +60,9 @@ def CIR_IntType : CIR_Type<"Int", "int",
     bool isPrimitive() const {
       return isValidPrimitiveIntBitwidth(getWidth());
     }
+    bool isSignedPrimitive() const {
+      return isPrimitive() && isSigned();
+    }
 
     /// Returns a minimum bitwidth of cir::IntType
     static unsigned minBitwidth() { return 1; }
@@ -538,8 +541,22 @@ def IntegerVector : Type<
     ]>, "!cir.vector of !cir.int"> {
 }
 
+// Vector of signed integral type
+def SignedIntegerVector : Type<
+    And<[
+      CPred<"::mlir::isa<::cir::VectorType>($_self)">,
+      CPred<"::mlir::isa<::cir::IntType>("
+            "::mlir::cast<::cir::VectorType>($_self).getEltType())">,
+      CPred<"::mlir::cast<::cir::IntType>("
+            "::mlir::cast<::cir::VectorType>($_self).getEltType())"
+            ".isSignedPrimitive()">
+    ]>, "!cir.vector of !cir.int"> {
+}
+
 // Constraints
 def CIR_AnyIntOrVecOfInt: AnyTypeOf<[CIR_IntType, IntegerVector]>;
+def CIR_AnySignedIntOrVecOfSignedInt: AnyTypeOf<
+                                        [PrimitiveSInt, SignedIntegerVector]>;
 
 // Pointer to Arrays
 def ArrayPtr : Type<

clang/include/clang/CIR/MissingFeatures.h

@@ -328,6 +328,9 @@ struct MissingFeatures {
 
   //-- Other missing features
 
+  // We need to extend fpUnaryOPs to support vector types.
+  static bool fpUnaryOPsSupportVectorType() { return false; }
+
   // We need to track the parent record types that represent a field
   // declaration. This is necessary to determine the layout of a class.
   static bool fieldDeclAbstraction() { return false; }

clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp

@@ -1255,9 +1255,22 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
   case Builtin::BI__builtin_nondeterministic_value:
     llvm_unreachable("BI__builtin_nondeterministic_value NYI");
 
-  case Builtin::BI__builtin_elementwise_abs:
-    llvm_unreachable("BI__builtin_elementwise_abs NYI");
-
+  case Builtin::BI__builtin_elementwise_abs: {
+    mlir::Type cirTy = ConvertType(E->getArg(0)->getType());
+    bool isIntTy = cir::isIntOrIntVectorTy(cirTy);
+    if (!isIntTy) {
+      if (cir::isAnyFloatingPointType(cirTy)) {
+        return emitUnaryFPBuiltin<cir::FAbsOp>(*this, *E);
+      }
+      assert(!MissingFeatures::fpUnaryOPsSupportVectorType());
+      llvm_unreachable("unsupported type for BI__builtin_elementwise_abs");
+    }
+    mlir::Value arg = emitScalarExpr(E->getArg(0));
+    auto call = getBuilder().create<cir::AbsOp>(getLoc(E->getExprLoc()),
+                                                arg.getType(), arg, false);
+    mlir::Value result = call->getResult(0);
+    return RValue::get(result);
+  }
   case Builtin::BI__builtin_elementwise_acos:
     llvm_unreachable("BI__builtin_elementwise_acos NYI");
   case Builtin::BI__builtin_elementwise_asin:

clang/lib/CIR/Dialect/IR/CIRTypes.cpp

@@ -740,7 +740,7 @@ bool cir::isAnyFloatingPointType(mlir::Type t) {
 }
 
 //===----------------------------------------------------------------------===//
-// Floating-point and Float-point Vecotr type helpers
+// Floating-point and Float-point Vector type helpers
 //===----------------------------------------------------------------------===//
 
 bool cir::isFPOrFPVectorTy(mlir::Type t) {
@@ -752,6 +752,18 @@ bool cir::isFPOrFPVectorTy(mlir::Type t) {
   return isAnyFloatingPointType(t);
 }
 
+//===----------------------------------------------------------------------===//
+// CIR Integer and Integer Vector type helpers
+//===----------------------------------------------------------------------===//
+
+bool cir::isIntOrIntVectorTy(mlir::Type t) {
+
+  if (isa<cir::VectorType>(t)) {
+    return isa<cir::IntType>(mlir::dyn_cast<cir::VectorType>(t).getEltType());
+  }
+  return isa<cir::IntType>(t);
+}
+
 //===----------------------------------------------------------------------===//
 // ComplexType Definitions
 //===----------------------------------------------------------------------===//