Fix condition nesting to prevent erroneous ConnectionClosedException throws

chrisdennis · chrisdennis · commit 2694256aa2d0 · 2022-09-09T15:50:22.000-04:00
diff --git a/tc-client/src/main/java/com/tc/object/ClientEntityManagerImpl.java b/tc-client/src/main/java/com/tc/object/ClientEntityManagerImpl.java
@@ -497,9 +497,9 @@ private Invocation.Task queueInFlightMessage(EntityID eid, Supplier<NetworkVoltr
           if (!channel.getProductID().isReconnectEnabled()) {
             throwClosedExceptionOnMessage(inFlight, "connection not capable of resend");
           }
-        } else {
-          throwClosedExceptionOnMessage(inFlight, "Connection closed before sending message");
         }
+      } else {
+        throwClosedExceptionOnMessage(inFlight, "Connection closed before sending message");
       }
       return () -> {
         if (inFlight.cancel()) {

Original file line number	Diff line number	Diff line change
`@@ -497,9 +497,9 @@ private Invocation.Task queueInFlightMessage(EntityID eid, Supplier<NetworkVoltr`
`497`	`497`	`if (!channel.getProductID().isReconnectEnabled()) {`
`498`	`498`	`throwClosedExceptionOnMessage(inFlight, "connection not capable of resend");`
`499`	`499`	`}`
`500`		`- } else {`
`501`		`- throwClosedExceptionOnMessage(inFlight, "Connection closed before sending message");`
`502`	`500`	`}`
	`501`	`+ } else {`
	`502`	`+ throwClosedExceptionOnMessage(inFlight, "Connection closed before sending message");`
`503`	`503`	`}`
`504`	`504`	`return () -> {`
`505`	`505`	`if (inFlight.cancel()) {`