avoid garbage with enum values()

git-svn-id: https://svn.terracotta.org/repo/tc/tc-messaging/branches/private/voltron@26022 7fc7bbf3-cf45-46d4-be06-341739edd864

Author: timeck

src/main/java/com/tc/object/locks/ClientServerExchangeLockContext.java

@@ -14,6 +14,8 @@
 import java.io.IOException;
 
 public class ClientServerExchangeLockContext implements TCSerializable<ClientServerExchangeLockContext> {
+  private static final State[] STATE_VALUES = State.values();
+  
   private LockID   lockID;
   private NodeID   nodeID;
   private ThreadID threadID;
@@ -88,7 +90,7 @@ public ClientServerExchangeLockContext deserializeFrom(TCByteBufferInput input)
     ns.deserializeFrom(input);
     nodeID = ns.getNodeID();
     threadID = new ThreadID(input.readLong());
-    state = State.values()[input.readInt()];
+    state = STATE_VALUES[input.readInt()];
     if (state.getType() == Type.WAITER || state.getType() == Type.TRY_PENDING) {
       this.timeout = input.readLong();
     } else {

src/main/java/com/tc/object/locks/LockIDSerializer.java

@@ -11,6 +11,8 @@
 import java.io.IOException;
 
 public class LockIDSerializer implements TCSerializable<LockIDSerializer> {
+  private static final LockIDType[] LOCK_ID_TYPE_VALUES = LockIDType.values();
+  
   private LockID lockID;
 
   public LockIDSerializer() {
@@ -35,7 +37,7 @@ public LockIDSerializer deserializeFrom(TCByteBufferInput serialInput) throws IO
 
   private LockID getImpl(byte type) {
     try {
-      switch (LockIDType.values()[type]) {
+      switch (LOCK_ID_TYPE_VALUES[type]) {
         case LONG:
           return new LongLockID();
         case STRING:

src/main/java/com/tc/object/msg/LockRequestMessage.java

@@ -31,6 +31,9 @@
  */
 public class LockRequestMessage extends DSOMessageBase implements MultiThreadedEventContext {
 
+  private static final RequestType[] REQUEST_TYPE_VALUES = RequestType.values();
+  private static final ServerLockLevel[] SERVER_LOCK_LEVEL_VALUES = ServerLockLevel.values();
+  
   private final static byte LOCK_ID                = 1;
   private final static byte LOCK_LEVEL             = 2;
   private final static byte THREAD_ID              = 3;
@@ -144,7 +147,7 @@ protected boolean hydrateValue(byte name) throws IOException {
         return true;
       case LOCK_LEVEL:
         try {
-          lockLevel = ServerLockLevel.values()[getByteValue()];
+          lockLevel = SERVER_LOCK_LEVEL_VALUES[getByteValue()];
         } catch (ArrayIndexOutOfBoundsException e) {
           return false;
         }
@@ -154,7 +157,7 @@ protected boolean hydrateValue(byte name) throws IOException {
         return true;
       case REQUEST_TYPE:
         try {
-          requestType = RequestType.values()[getByteValue()];
+          requestType = REQUEST_TYPE_VALUES[getByteValue()];
         } catch (ArrayIndexOutOfBoundsException e) {
           return false;
         }

src/main/java/com/tc/object/msg/LockResponseMessage.java

@@ -22,6 +22,9 @@
 
 public class LockResponseMessage extends DSOMessageBase implements MultiThreadedEventContext {
 
+  private static final ServerLockLevel[] SERVER_LOCK_LEVEL_VALUES = ServerLockLevel.values();
+  private static final ResponseType[] RESPONSE_TYPE_VALUES = ResponseType.values();
+  
   private static final byte TYPE              = 1;
   private static final byte THREAD_ID         = 2;
   private static final byte LOCK_ID           = 3;
@@ -97,7 +100,7 @@ protected boolean hydrateValue(byte name) throws IOException {
     switch (name) {
       case TYPE:
         try {
-          responseType = ResponseType.values()[getByteValue()];
+          responseType = RESPONSE_TYPE_VALUES[getByteValue()];
         } catch (ArrayIndexOutOfBoundsException e) {
           return false;
         }
@@ -112,7 +115,7 @@ protected boolean hydrateValue(byte name) throws IOException {
         return true;
       case LOCK_LEVEL:
         try {
-          lockLevel = ServerLockLevel.values()[getByteValue()];
+          lockLevel = SERVER_LOCK_LEVEL_VALUES[getByteValue()];
         } catch (ArrayIndexOutOfBoundsException e) {
           return false;
         }

src/main/java/com/tc/object/msg/ServerEventSerializableContext.java

@@ -19,6 +19,8 @@
  */
 class ServerEventSerializableContext implements TCSerializable<ServerEventSerializableContext> {
 
+  private static final ServerEventType[] SERVER_EVENT_TYPE_VALUES = ServerEventType.values();
+
   private static final DNAEncoding serializer = new SerializerDNAEncodingImpl();
 
   private ServerEvent event;
@@ -54,7 +56,7 @@ public void serializeTo(final TCByteBufferOutput out) {
   public ServerEventSerializableContext deserializeFrom(TCByteBufferInput in) throws IOException {
     try {
       int index = (Integer) serializer.decode(in);
-      final ServerEventType type = ServerEventType.values()[index];
+      final ServerEventType type = SERVER_EVENT_TYPE_VALUES[index];
       final String destination = (String) serializer.decode(in);
       final Object key = serializer.decode(in);
       final byte[] value = (byte[]) serializer.decode(in);