Skip to content

Commit 9df614c

Browse files
added missing default value for io_share_level variable, added sanity checks for new features
1 parent b547b1c commit 9df614c

File tree

4 files changed

+27
-14
lines changed

4 files changed

+27
-14
lines changed

tests/sanity/main.tf

Lines changed: 26 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,26 @@ variable "env" {
2121

2222
variable "vm" {
2323
type = map(object({
24-
vmname = string
25-
vmtemp = string
26-
dc = string
27-
vmrp = string
28-
vmfolder = string
29-
datastore = string
30-
is_windows_image = bool
31-
tags = map(string)
32-
instances = number
33-
network = map(list(string))
34-
vmgateway = string
35-
dns_servers = list(string)
36-
data_disk = map(map(string))
24+
vmname = string
25+
vmtemp = string
26+
dc = string
27+
vmrp = string
28+
vmfolder = string
29+
datastore = string
30+
is_windows_image = bool
31+
tags = map(string)
32+
instances = number
33+
network = map(list(string))
34+
vmgateway = string
35+
dns_servers = list(string)
36+
data_disk = map(map(string))
37+
cpu_share_level = string
38+
cpu_share_count = number
39+
memory_share_level = string
40+
memory_share_count = number
41+
# io_reservation = list(number)
42+
io_share_level = list(string)
43+
io_share_count = list(number)
3744
}))
3845
}
3946

@@ -54,6 +61,12 @@ module "example-server-basic" {
5461
dc = each.value.dc
5562
datastore = each.value.datastore
5663
data_disk = each.value.data_disk
64+
cpu_share_level = each.value.cpu_share_level
65+
# cpu_share_count = each.value.cpu_share_level == "custom" ? each.value.cpu_share_count : null
66+
# memory_share_level = each.value.memory_share_level
67+
# memory_share_count = each.value.memory_share_level == "custom" ? each.value.memory_share_count : null
68+
# io_share_level = each.value.io_share_level
69+
# io_share_count = each.value.io_share_level == "custom" ? each.value.io_share_count : null
5770
}
5871

5972
output "DC_ID" {

tests/sanity/plan.sh

100644100755
File mode changed.

tests/smoke/plan.sh

100644100755
File mode changed.

variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ variable "io_reservation" {
6060
variable "io_share_level" {
6161
description = "The share allocation level for this disk. Can be one of low, normal, high, or custom. Default: normal."
6262
type = list(string)
63-
default = [""]
63+
default = ["normal"]
6464
}
6565

6666
variable "io_share_count" {

0 commit comments

Comments
 (0)