refactor(hooks): replace blocking/required with onFailure property

BREAKING CHANGE: ToolConfig interface changed

- Remove confusing `blocking` and `required` boolean properties
- Add single `onFailure: 'continue' | 'stop'` property
- 'stop' halts subsequent tools (for syntax checks)
- 'continue' (default) runs all tools and reports at end
- Log error details in runStep catch block instead of swallowing
- Update tests and documentation

Author: TerrorSquad

booster/.husky/README.md

@@ -28,17 +28,16 @@ To add a new tool, simply add a `ToolConfig` object to the `TOOLS` array.
 
 ### Configuration Object (`ToolConfig`)
 
-| Property           | Type              | Description                                                                                                                     |
-| ------------------ | ----------------- | ------------------------------------------------------------------------------------------------------------------------------- |
-| `name`             | `string`          | Display name of the tool (used in logs).                                                                                        |
-| `command`          | `string`          | The binary command to run (e.g., `eslint`, `rector`).                                                                           |
-| `type`             | `'node' \| 'php'` | Determines where to look for the binary (`node_modules/.bin` or `vendor/bin`).                                                  |
-| `args`             | `string[]`        | (Optional) Arguments to pass to the command.                                                                                    |
-| `extensions`       | `string[]`        | (Optional) Only run on files with these extensions.                                                                             |
-| `stagesFilesAfter` | `boolean`         | (Optional) If `true`, re-stages files after execution (useful for fixers).                                                      |
-| `passFiles`        | `boolean`         | (Optional) If `false`, does not pass the list of staged files to the command. Default is `true`.                                |
-| `required`         | `boolean`         | (Optional) If `true`, the hook will fail if this tool fails. Default is `false` (but usually the hook fails if any tool fails). |
-| `blocking`         | `boolean`         | (Optional) If `true`, stops running subsequent tools if this tool fails. Useful for syntax checks that must pass first.         |
+| Property           | Type                        | Description                                                                                      |
+| ------------------ | --------------------------- | ------------------------------------------------------------------------------------------------ |
+| `name`             | `string`                    | Display name of the tool (used in logs).                                                         |
+| `command`          | `string`                    | The binary command to run (e.g., `eslint`, `rector`).                                            |
+| `type`             | `'node' \| 'php'`           | Determines where to look for the binary (`node_modules/.bin` or `vendor/bin`).                   |
+| `args`             | `string[]`                  | (Optional) Arguments to pass to the command.                                                     |
+| `extensions`       | `string[]`                  | (Optional) Only run on files with these extensions.                                              |
+| `stagesFilesAfter` | `boolean`                   | (Optional) If `true`, re-stages files after execution (useful for fixers).                       |
+| `passFiles`        | `boolean`                   | (Optional) If `false`, does not pass the list of staged files to the command. Default is `true`. |
+| `onFailure`        | `'continue' \| 'stop'`      | (Optional) What happens when this tool fails. Default is `'continue'`. Use `'stop'` for syntax checks that must pass before other tools run. |
 
 ### Example
 
@@ -49,7 +48,8 @@ To add a new tool, simply add a `ToolConfig` object to the `TOOLS` array.
   args: ['--check'],
   type: 'node',
   extensions: ['.ts', '.js'],
-  stagesFilesAfter: false
+  stagesFilesAfter: false,
+  onFailure: 'continue'  // or 'stop' for critical checks
 }
 ```
 

booster/.husky/shared/tools.ts

@@ -61,7 +61,7 @@ export const TOOLS: ToolConfig[] = [
     type: 'php',
     runForEachFile: true,
     extensions: ['.php'],
-    blocking: true, // Stop subsequent tools if syntax check fails
+    onFailure: 'stop', // Stop subsequent tools if syntax check fails
   },
   {
     name: 'Rector',

booster/.husky/shared/types.ts

@@ -6,6 +6,13 @@
  */
 export type ToolType = 'node' | 'php' | 'system'
 
+/**
+ * Failure mode for a tool
+ * - 'continue': Log error, keep running other tools, report failure at end
+ * - 'stop': Log error, skip remaining tools, report failure immediately
+ */
+export type FailureMode = 'continue' | 'stop'
+
 /**
  * Configuration for a quality tool
  */
@@ -28,10 +35,12 @@ export interface ToolConfig {
   runForEachFile?: boolean
   /** Custom description to show in logs while running */
   description?: string
-  /** If true, the hook will fail if this tool fails. Default is false (but usually the hook fails if any tool fails). */
-  required?: boolean
-  /** If true, stops running subsequent tools if this tool fails. Useful for syntax checks that must pass before analysis. */
-  blocking?: boolean
+  /**
+   * What happens when this tool fails. Default is 'continue'.
+   * - 'continue': Log error, keep running other tools
+   * - 'stop': Log error, skip remaining tools (use for syntax checks that must pass first)
+   */
+  onFailure?: FailureMode
 }
 
 /**

booster/.husky/shared/workflow.ts

@@ -39,10 +39,11 @@ export async function runStep(
     log.success(`${toolName} completed successfully (${formattedDuration})`)
 
     return true
-  } catch {
+  } catch (error) {
     const duration = Date.now() - startTime
     const formattedDuration = formatDuration(duration)
-    log.error(`${toolName} failed after ${formattedDuration}`)
+    const errorMessage = error instanceof Error ? error.message : String(error)
+    log.error(`${toolName} failed after ${formattedDuration}: ${errorMessage}`)
 
     return false
   }
@@ -190,14 +191,12 @@ export async function runQualityChecks(files: string[], tools: ToolConfig[]): Pr
 
     if (!success) {
       allSuccessful = false
-      if (tool.blocking) {
+
+      // Check failure mode - 'stop' halts execution, 'continue' (default) keeps going
+      if (tool.onFailure === 'stop') {
         log.error(`${tool.name} failed. Stopping subsequent checks.`)
         return false
       }
-      if (tool.required) {
-        log.error(`${tool.name} is required but failed`)
-        return false
-      }
     }
   }
 

booster/.husky/tests/shared/workflow.test.ts

@@ -81,8 +81,7 @@ describe('workflow.ts', () => {
       name: 'test-tool',
       command: 'test-cmd',
       type: 'system',
-      extensions: ['.php'],
-      required: true
+      extensions: ['.php']
     }
 
     it('should skip if tool is skipped via env', async () => {
@@ -171,7 +170,7 @@ describe('workflow.ts', () => {
       expect(stageFiles).toHaveBeenCalledWith(['file.php'])
     })
 
-    it('should fail if required tool fails', async () => {
+    it('should fail if tool fails', async () => {
       vi.mocked(isSkipped).mockReturnValue(false)
       vi.mocked(fs.pathExists).mockResolvedValue(true)
       vi.mocked(exec).mockRejectedValue(new Error('fail'))
@@ -181,41 +180,46 @@ describe('workflow.ts', () => {
       expect(result).toBe(false)
     })
 
-    it('should not fail if optional tool fails', async () => {
+    it('should continue to next tool if tool with default onFailure fails', async () => {
       vi.mocked(isSkipped).mockReturnValue(false)
       vi.mocked(fs.pathExists).mockResolvedValue(true)
-      vi.mocked(exec).mockRejectedValue(new Error('fail'))
+      vi.mocked(exec)
+        .mockRejectedValueOnce(new Error('first tool failed'))
+        .mockResolvedValueOnce({} as any)
 
-      const optionalTool: ToolConfig = { ...mockTool, required: false }
-      const result = await runQualityChecks(['file.php'], [optionalTool])
+      const firstTool: ToolConfig = { ...mockTool }
+      const secondTool: ToolConfig = { ...mockTool, name: 'second-tool' }
+
+      const result = await runQualityChecks(['file.php'], [firstTool, secondTool])
 
       expect(result).toBe(false)
+      expect(exec).toHaveBeenCalledTimes(2) // Both tools ran
     })
 
-    it('should stop subsequent tools if blocking tool fails', async () => {
+    it('should stop subsequent tools if onFailure is stop', async () => {
       vi.mocked(isSkipped).mockReturnValue(false)
       vi.mocked(fs.pathExists).mockResolvedValue(true)
       vi.mocked(exec).mockRejectedValue(new Error('syntax error'))
 
-      const blockingTool: ToolConfig = { ...mockTool, blocking: true, required: false }
+      const stoppingTool: ToolConfig = { ...mockTool, onFailure: 'stop' }
       const subsequentTool: ToolConfig = { ...mockTool, name: 'subsequent-tool' }
 
-      const result = await runQualityChecks(['file.php'], [blockingTool, subsequentTool])
+      const result = await runQualityChecks(['file.php'], [stoppingTool, subsequentTool])
 
       expect(result).toBe(false)
-      expect(exec).toHaveBeenCalledTimes(1) // Only blocking tool ran
+      expect(exec).toHaveBeenCalledTimes(1) // Only stopping tool ran
       expect(log.error).toHaveBeenCalledWith(expect.stringContaining('Stopping subsequent checks'))
     })
 
-    it('should continue to next tool if non-blocking tool fails', async () => {
+    it('should continue to next tool if onFailure is continue', async () => {
       vi.mocked(isSkipped).mockReturnValue(false)
       vi.mocked(fs.pathExists).mockResolvedValue(true)
       vi.mocked(exec)
         .mockRejectedValueOnce(new Error('first tool failed'))
         .mockResolvedValueOnce({} as any)
 
-      const firstTool: ToolConfig = { ...mockTool, blocking: false, required: false }
-      const secondTool: ToolConfig = { ...mockTool, name: 'second-tool', required: false }
+      const firstTool: ToolConfig = { ...mockTool, onFailure: 'continue' }
+      const secondTool: ToolConfig = { ...mockTool, name: 'second-tool' }
 
       const result = await runQualityChecks(['file.php'], [firstTool, secondTool])