feat: refactor git hooks with common library for improved logging and organization

Author: TerrorSquad

booster/tools/git-hooks/REFACTORING_SUMMARY.md

@@ -0,0 +1,119 @@
+# Git Hooks Refactoring Summary
+
+## Overview
+Successfully refactored the git hooks system to extract common functionality and improve code organization with consistent colored logging.
+
+## Changes Made
+
+### 1. Created Common Library (`/booster/tools/git-hooks/lib/common.sh`)
+
+**Features:**
+- **Colored Logging System**: Consistent, emoji-enhanced logging functions
+  - `log_info()` - Information messages (cyan with ℹ️)
+  - `log_success()` - Success messages (green with ✅)
+  - `log_warning()` - Warning messages (yellow with ⚠️)
+  - `log_error()` - Error messages (red with ❌)
+  - `log_step()` - Process steps (blue with 📋)
+  - `log_tool()` - Tool execution (cyan with 🔧)
+  - `log_check()` - Check operations (blue with 🔍)
+  - `log_skip()` - Skipped operations (yellow with 🚫)
+  - `log_celebrate()` - Success celebration (green with 🎉)
+
+- **Environment Setup**: Standardized git environment detection
+  - `setup_git_environment()` - Detects ROOT, BASE, GIT_DIR, RUNNER
+  - `setup_branch_info()` - Gets current branch name
+  - `setup_common_paths()` - Sets up common file paths
+
+- **Early Exit Conditions**: Reusable skip logic
+  - `is_ci_environment()` - CI detection
+  - `is_merge_in_progress()` - Merge state detection
+  - `should_skip_in_ci()` - CI skip with logging
+  - `should_skip_during_merge()` - Merge skip with logging
+
+- **Dependency Checks**: Common validation functions
+  - `check_runner_available()` - Validates runner script
+  - `check_node_modules()` - Validates Node.js dependencies
+  - `check_vendor_directory()` - Validates PHP dependencies
+  - `check_file_exists()` - Generic file validation
+
+- **Command Execution**: Standardized command running
+  - `run_command()` - Execute with logging
+  - `run_command_quiet()` - Execute silently
+
+- **Package Detection**: Composer package management
+  - `has_composer_package()` - Check for Composer packages
+  - `has_tool()` - Check for vendor tools
+  - Automatic cache cleanup on exit
+
+### 2. Refactored `setup.sh`
+
+**Before:** Manual color definitions, basic echo statements
+**After:** 
+- Uses common library for all logging
+- Consistent colored output with emojis
+- Cleaner error handling with `error_exit()`
+- Simplified function names (e.g., `check_runner_available()` → `check_runner_script()`)
+
+### 3. Refactored `commit-msg.bash`
+
+**Before:** Duplicate environment setup, basic error messages
+**After:**
+- Uses common library for environment setup
+- Consistent logging throughout
+- Simplified validation functions
+- Better error reporting with `error_exit()`
+
+### 4. Refactored `pre-commit.bash`
+
+**Before:** Inline emojis, manual PHP file filtering, repetitive echo statements
+**After:**
+- Uses common library functions
+- Clean separation of concerns with dedicated functions:
+  - `check_staged_php_files()` - File detection
+  - `run_php_syntax_check()` - Syntax validation
+  - `run_rector_fix()` - Rector execution
+  - `run_ecs_fix()` - ECS execution
+  - `run_deptrac_check()` - Architecture validation
+  - `run_phpstan_analysis()` - Static analysis
+  - `run_psalm_analysis()` - Psalm analysis
+- Consistent tool detection with `has_tool()`
+
+### 5. Refactored `pre-push.bash`
+
+**Before:** Duplicate utility functions, basic echo statements
+**After:**
+- Uses common library for all shared functionality
+- Removed duplicate composer cache logic (handled by common.sh)
+- Consistent logging and error handling
+- Cleaner function organization
+
+## Benefits Achieved
+
+### Code Quality Improvements
+- **DRY Principle**: Eliminated code duplication across all hooks
+- **Separation of Concerns**: Common functionality extracted to library
+- **Consistent Interface**: All hooks now use same logging and error handling
+
+### User Experience Improvements
+- **Visual Consistency**: All hooks now use consistent colored output with emojis
+- **Better Error Messages**: Clear, actionable error messages with consistent formatting
+- **Progress Indication**: Clear step-by-step progress reporting
+
+### Maintainability Improvements
+- **Single Source of Truth**: Common functionality in one place
+- **Easier Updates**: Changes to logging/environment setup affect all hooks
+- **Better Testing**: Common functions can be tested independently
+
+## Validation
+All refactored scripts pass bash syntax validation:
+- ✅ `lib/common.sh` - Syntax valid
+- ✅ `setup.sh` - Syntax valid  
+- ✅ `commit-msg.bash` - Syntax valid
+- ✅ `pre-commit.bash` - Syntax valid
+- ✅ `pre-push.bash` - Syntax valid
+
+## Future Improvements
+- Consider adding configuration file support for hook behavior
+- Add unit tests for common library functions
+- Consider adding hook-specific configuration options
+- Add support for custom emoji/color schemes

booster/tools/git-hooks/hooks/commit-msg.bash

@@ -4,93 +4,55 @@
 set -euo pipefail
 IFS=$'\n\t'
 
-# --- Environment Setup ---
-setup_environment() {
-    ROOT=$(git rev-parse --show-toplevel)
-    if [ -f "$ROOT/booster/tools/runner.sh" ]; then
-        BASE="$ROOT/booster"
-    else
-        BASE="$ROOT"
-    fi
-    readonly ROOT BASE
-
-    local git_dir
-    git_dir=$(git rev-parse --git-dir)
-    readonly GIT_DIR="$git_dir"
-    readonly RUNNER="$BASE/tools/runner.sh"
-
-    local current_branch
-    current_branch=$(git symbolic-ref --short HEAD)
-    readonly CURRENT_BRANCH="$current_branch"
-
-    # Use relative path for DDEV compatibility
-    readonly UTIL_SCRIPT="./tools/commit-utils.js"
-}
+# Source common library
+PROJECT_ROOT="$(git rev-parse --show-toplevel)"
+source "$PROJECT_ROOT/tools/git-hooks/lib/common.sh"
 
 # --- Early Exit Conditions ---
-should_skip_hook() {
-    # Skip during merge
-    if [ -f "$GIT_DIR/MERGE_HEAD" ]; then
-        echo "Merge in progress. Skipping commit message checks."
+should_skip_commit_checks() {
+    if should_skip_during_merge; then
         return 0
     fi
-
     return 1
 }
 
 check_dependencies() {
-    if [ ! -d "$BASE/node_modules" ]; then
-        local install_cmd
-        if [ -d "$ROOT/.ddev" ]; then
-            install_cmd="ddev pnpm install"
-        else
-            install_cmd="pnpm install"
-        fi
-        echo "ERROR: No node_modules directory detected. Please run '$install_cmd' before committing." >&2
-        exit 1
-    fi
-}
-
-error() {
-    echo "ERROR: $*" >&2
-    exit 1
+    check_node_modules
 }
 
 # --- Validation Functions ---
 validate_branch_name() {
-    if ! bash "$RUNNER" node_modules/.bin/validate-branch-name -t "$CURRENT_BRANCH" > /dev/null 2>&1; then
+    if ! run_command_quiet node_modules/.bin/validate-branch-name -t "$CURRENT_BRANCH"; then
         # Run again without suppression to show the error details
         bash "$RUNNER" node_modules/.bin/validate-branch-name -t "$CURRENT_BRANCH"
-        error "Branch name validation failed. See rules in validate-branch-name.config.cjs."
+        error_exit "Branch name validation failed. See rules in validate-branch-name.config.cjs."
     fi
 }
 
 lint_commit_message() {
     local commit_file="$1"
-    bash "$RUNNER" node_modules/.bin/commitlint --edit "$commit_file"
+    run_command "commitlint" node_modules/.bin/commitlint --edit "$commit_file"
 }
 
 append_ticket_footer() {
     local commit_file="$1"
 
-    if [ ! -f "$UTIL_SCRIPT" ]; then
-        error "Missing commit-utils.js helper script."
-    fi
+    check_file_exists "$UTIL_SCRIPT" "commit-utils.js helper script"
 
     # Query NEED_TICKET & FOOTER_LABEL via helper script
     local need_ticket footer_label
     if ! need_ticket=$(bash "$RUNNER" node "$UTIL_SCRIPT" --need-ticket 2>/dev/null); then
-        error "Failed to determine ticket requirement."
+        error_exit "Failed to determine ticket requirement."
     fi
     if ! footer_label=$(bash "$RUNNER" node "$UTIL_SCRIPT" --footer-label 2>/dev/null); then
-        error "Failed to determine footer label."
+        error_exit "Failed to determine footer label."
     fi
 
     if [ "${need_ticket}" = "yes" ]; then
         local ticket_id
         ticket_id=$(bash "$RUNNER" node "$UTIL_SCRIPT" --extract-ticket "$CURRENT_BRANCH" 2>/dev/null || true)
         if [ -z "${ticket_id:-}" ]; then
-            error "No ticket ID found in branch name."
+            error_exit "No ticket ID found in branch name."
         fi
 
         local commit_body
@@ -105,9 +67,9 @@ append_ticket_footer() {
 main() {
     local commit_file="$1"
 
-    setup_environment
+    init_common
 
-    if should_skip_hook; then
+    if should_skip_commit_checks; then
         exit 0
     fi