chore(hooks): DRY API docs using shared helper; avoid direct process.exit in pre-commit

Author: TerrorSquad

booster/.husky/README.md

@@ -82,6 +82,8 @@ The hooks are designed to work seamlessly with DDEV.
 
 You can control the behavior of the hooks using environment variables. These can be set in your shell or in a `.env` file.
 
+Note: tool-specific skip variables are normalized to uppercase and non-alphanumeric characters are replaced with underscores. For example, a tool named `PHP Syntax Check` becomes `SKIP_PHP_SYNTAX_CHECK` and `api docs` becomes `SKIP_API_DOCS`.
+
 | Variable            | Description                                                                  |
 | ------------------- | ---------------------------------------------------------------------------- |
 | `GIT_HOOKS_VERBOSE` | Set to `1` or `true` to enable verbose logging (shows executed commands).    |

booster/.husky/pre-commit.ts

@@ -23,7 +23,7 @@ await runHook(GitHook.PreCommit, async () => {
 
   if (files.length === 0) {
     log.info('No files staged for commit. Skipping quality checks.')
-    process.exit(0)
+    return true
   }
 
   log.info(`Found ${files.length} staged file(s): ${files.join(', ')}`)

booster/.husky/pre-push.ts

@@ -9,7 +9,7 @@
  * - API Documentation generation
  */
 import { $, fs } from 'zx'
-import { GitHook, log, runHook, runWithRunner } from './shared/index.ts'
+import { GitHook, isSkipped, log, runHook, runWithRunner, generateApiDocs } from './shared/index.ts'
 
 const SKIP_COMMIT_MSG = 'chore: update API documentation'
 
@@ -45,40 +45,14 @@ async function runTests(): Promise<boolean> {
 }
 
 async function handleApiDocs(): Promise<boolean> {
-  log.tool('API Documentation', 'Generating OpenAPI specification...')
-  try {
-    if (!(await fs.pathExists('vendor/zircote/swagger-php'))) {
-      log.info('swagger-php not installed -> skipping API docs.')
-      return true
-    }
-
-    await runWithRunner(['composer', 'generate-api-spec'])
-
-    // Check if openapi.yml changed
-    const diff = await $`git diff --name-only`
-    if (!diff.stdout.includes('documentation/openapi.yml')) {
-      log.success('API documentation check passed (no changes)')
-      return true
-    }
-
-    log.info('API spec changed, regenerating HTML...')
-    await runWithRunner(['pnpm', 'generate:api-doc:html'])
-
-    // Check for changes in documentation files
-    const status = await $`git status --porcelain documentation/openapi.html documentation/openapi.yml`
-    if (status.stdout.trim() !== '') {
-      log.info('API documentation is outdated. Updating and committing...')
-
-      await $`git add documentation/openapi.html documentation/openapi.yml`
-      // Skip pre-commit (linting) but run commit-msg (ticket appending)
-      await $`SKIP_PRECOMMIT=1 git commit -m ${SKIP_COMMIT_MSG}`
-
-      log.success('API documentation updated and committed.')
-      log.warn('The new documentation commit was created AFTER the push started.')
-      log.warn('Your code has been pushed, but you must run "git push" AGAIN to send the documentation update.')
-      return true
-    }
+  // Allow skipping API docs generation explicitly via env var
+  if (isSkipped('api_docs')) {
+    log.info('Skipping API docs generation (SKIP_API_DOCS environment variable set)')
+    return true
+  }
 
+  try {
+    await generateApiDocs()
     return true
   } catch (e) {
     log.error('API spec generation failed')

booster/.husky/shared/core.ts

@@ -115,6 +115,11 @@ export function formatDuration(ms: number): string {
  * @param name Name of the tool/check (will be converted to SKIP_<NAME>)
  */
 export function isSkipped(name: string): boolean {
-  const skipEnvVar = `SKIP_${name.toUpperCase()}`
+  // Normalize name -> uppercase, replace non-alphanum with underscore, collapse multiple underscores
+  const normalized = String(name)
+    .toUpperCase()
+    .replace(/[^A-Z0-9]+/g, '_')
+    .replace(/^_+|_+$/g, '')
+  const skipEnvVar = `SKIP_${normalized}`
   return process.env[skipEnvVar] === '1' || process.env[skipEnvVar] === 'true'
 }