refactor: update runWithRunner and runVendorBin to return ProcessOutput type

Author: TerrorSquad

booster/tools/git-hooks/shared/runner.sh

@@ -2,15 +2,6 @@
 
 # Generic runner script - handles DDEV container detection and command execution
 
-# Force color output to preserve colors through shell layers and WSL
-export FORCE_COLOR=1
-export CLICOLOR_FORCE=1
-export NO_COLOR=
-export TERM=${TERM:-xterm-256color}
-# Ensure Node.js tools output colors
-export NPM_CONFIG_COLOR=always
-export PNPM_CONFIG_COLOR=always
-
 # Check if we're inside a DDEV container
 is_inside_container() {
     [[ -n "$DDEV_HOSTNAME" || -n "$DDEV_PROJECT" || -n "$DDEV_SITENAME" ]]
@@ -30,15 +21,12 @@ elif command -v ddev >/dev/null 2>&1; then
     if [ -f ".ddev/config.yaml" ]; then
         project_name=$(grep "^name:" .ddev/config.yaml | sed 's/name: *//' | tr -d '"')
         container_name="ddev-${project_name}-web"
-        
+
         if [ -n "$project_name" ] && command -v docker >/dev/null 2>&1; then
             # Use docker exec -t for TTY support and colors
             exec docker exec -t "$container_name" "$@"
         fi
     fi
-    
-    # Fallback to ddev exec (no colors but still works)
-    exec ddev exec "$@"
 else
     exec "$@"
-fi
+fi

booster/tools/git-hooks/shared/utils.ts

@@ -5,7 +5,7 @@
  * Provides consistent logging, file operations, and tool detection
  */
 
-import { $, chalk, fs, path } from 'zx'
+import { $, chalk, fs, path, ProcessOutput } from 'zx'
 
 // Configure zx behavior
 $.verbose = false
@@ -26,7 +26,10 @@ interface RunOptions {
  * @param command Array of command parts
  * @param options Execution options
  */
-export async function runWithRunner(command: string[], options: RunOptions = {}): Promise<any> {
+export async function runWithRunner(
+  command: string[],
+  options: RunOptions = {},
+): Promise<ProcessOutput> {
   const { quiet = false } = options
 
   // Log command execution if not quiet
@@ -73,7 +76,7 @@ export async function getStagedPhpFiles(): Promise<string[]> {
     // Filter for PHP files that actually exist
     const phpFiles: string[] = []
     for (const file of allFiles) {
-      if (file.endsWith('.php') && !file.includes('/vendor/') && (await fs.pathExists(file))) {
+      if (file.endsWith('.php') && !file.startsWith('vendor/') && (await fs.pathExists(file))) {
         phpFiles.push(file)
       }
     }
@@ -180,7 +183,7 @@ export async function hasComposerPackage(packageName: string): Promise<boolean>
  * @param toolName Name of the tool
  * @param args Arguments to pass to the tool
  */
-export async function runVendorBin(toolName: string, args: string[] = []): Promise<any> {
+export async function runVendorBin(toolName: string, args: string[] = []): Promise<ProcessOutput> {
   const command = [`./vendor/bin/${toolName}`, ...args]
   return await runWithRunner(command)
 }