feat: implement runner.sh for git hooks CI compatibility

- Add generic runner.sh script for DDEV container detection
- Simplify hook wrappers to use fixed 'pnpm zx' command via runner
- Update test project with new hook implementation
- Fix GitHub Actions 'pnpm: command not found' error

Author: TerrorSquad

booster/tools/git-hooks/hooks/commit-msg

@@ -1,7 +1,9 @@
 #!/usr/bin/env bash
 
 # Git hook wrapper for ZX implementation
-# This script calls the modern ZX-based commit-msg hook
 
-# Call the ZX-based TypeScript hook
-pnpm zx "tools/git-hooks/hooks/commit-msg.ts" "$@"
+# Get the directory of this script
+HOOK_DIR="$(dirname "$0")"
+
+# Use the generic runner script to execute the TypeScript hook
+exec "$HOOK_DIR/../shared/runner.sh" pnpm zx "tools/git-hooks/hooks/commit-msg.ts" "$@"

booster/tools/git-hooks/hooks/pre-commit

@@ -1,7 +1,9 @@
 #!/usr/bin/env bash
 
 # Git hook wrapper for ZX implementation
-# This script calls the modern ZX-based pre-commit hook
 
-# Call the ZX-based TypeScript hook
-pnpm zx "tools/git-hooks/hooks/pre-commit.ts" "$@"
+# Get the directory of this script
+HOOK_DIR="$(dirname "$0")"
+
+# Use the generic runner script to execute the TypeScript hook
+exec "$HOOK_DIR/../shared/runner.sh" pnpm zx "tools/git-hooks/hooks/pre-commit.ts" "$@"

booster/tools/git-hooks/hooks/pre-push

@@ -1,7 +1,9 @@
 #!/usr/bin/env bash
 
 # Git hook wrapper for ZX implementation
-# This script calls the modern ZX-based pre-push hook
 
-# Call the ZX-based TypeScript hook
-pnpm zx "tools/git-hooks/hooks/pre-push.ts" "$@"
+# Get the directory of this script
+HOOK_DIR="$(dirname "$0")"
+
+# Use the generic runner script to execute the TypeScript hook
+exec "$HOOK_DIR/../shared/runner.sh" pnpm zx "tools/git-hooks/hooks/pre-push.ts" "$@"

booster/tools/git-hooks/shared/runner.sh

@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+# Generic runner script - handles DDEV container detection and command execution
+
+# Force color output to preserve colors through shell layers
+export FORCE_COLOR=1
+export CLICOLOR_FORCE=1
+
+# Check if we're inside a DDEV container
+is_inside_container() {
+    [[ -n "$DDEV_HOSTNAME" || -n "$DDEV_PROJECT" || -n "$DDEV_SITENAME" ]]
+}
+
+# Main execution
+if [[ $# -lt 1 ]]; then
+    echo "Usage: $0 <command> [arguments...]" >&2
+    exit 1
+fi
+
+if is_inside_container; then
+    exec "$@"
+elif command -v ddev >/dev/null 2>&1; then
+    exec ddev exec "$@"
+else
+    exec "$@"
+fi

booster/tools/git-hooks/shared/utils.ts

@@ -18,64 +18,17 @@ interface RunOptions {
 }
 
 /**
- * Check if we're already inside a DDEV container
- */
-async function isInsideDdevContainer(): Promise<boolean> {
-  try {
-    // Check for CI environment first - in CI we should use DDEV commands explicitly
-    if (process.env.CI === 'true' || process.env.GITHUB_ACTIONS === 'true') {
-      return false // In CI, always use ddev exec commands
-    }
-
-    // Check for DDEV_HOSTNAME environment variable (most reliable)
-    if (process.env.DDEV_HOSTNAME) {
-      return true
-    }
-
-    // Check for specific DDEV environment variables
-    if (process.env.DDEV_PROJECT || process.env.DDEV_SITENAME) {
-      return true
-    }
-
-    // Check if we're inside a container by examining hostname or other indicators
-    const result = await $`hostname`.quiet()
-    const hostname = result.toString().trim()
-
-    // Check for DDEV container indicators
-    return hostname.includes('ddev') || hostname.includes('web')
-  } catch (error) {
-    return false
-  }
-}
-
-/**
- * Execute command with appropriate runner (DDEV or direct)
+ * Execute command directly with ZX
  * @param command Array of command parts
  * @param options Execution options
  */
 export async function runWithRunner(command: string[], options: RunOptions = {}): Promise<any> {
   const { quiet = false } = options
 
-  // Build command array
-  let fullCommand: string[]
-  let contextLabel: string
-
-  const isInsideContainer = await isInsideDdevContainer()
-
-  if (!isInsideContainer) {
-    // We're not inside a container - run via DDEV
-    fullCommand = ['ddev', 'exec', ...command]
-    contextLabel = 'via DDEV'
-  } else {
-    // Run directly (already inside container)
-    fullCommand = command
-    contextLabel = isInsideContainer ? 'inside DDEV container' : 'direct'
-  }
-
   // Log command execution if not quiet
   if (!quiet) {
     const commandStr = command.join(' ')
-    log.info(`Executing (${contextLabel}): ${commandStr}`)
+    log.info(`Executing: ${commandStr}`)
   }
 
   // Set clean environment to avoid locale warnings
@@ -87,26 +40,11 @@ export async function runWithRunner(command: string[], options: RunOptions = {})
 
   try {
     // Execute with appropriate stdio handling and clean environment
-    return await $({ stdio: quiet ? 'pipe' : 'inherit', env: cleanEnv })`${fullCommand}`
+    return await $({ stdio: quiet ? 'pipe' : 'inherit', env: cleanEnv })`${command}`
   } catch (error: unknown) {
-    // Add better error context for debugging CI issues
-    const errorMessage = error instanceof Error ? error.message : String(error)
-    const commandStr = fullCommand.join(' ')
-    log.error(`Command failed: ${commandStr}`)
-    log.error(`Error: ${errorMessage}`)
-    log.error(`Context: ${contextLabel}`)
-    log.error(`Working directory: ${process.cwd()}`)
-
-    // In CI environments, also log environment details for debugging
-    if (process.env.CI === 'true' || process.env.GITHUB_ACTIONS === 'true') {
-      log.error(`CI Environment detected`)
-      log.error(`Container detection result: inside=${isInsideContainer}`)
-    }
-
     throw error
   }
 }
-
 /**
  * Logging utilities with consistent formatting
  */