Remove strange entity-wrapping code#1257
Open
7f-galaxii wants to merge 1 commit intoTerryCavanagh:masterfrom
Open
Remove strange entity-wrapping code#12577f-galaxii wants to merge 1 commit intoTerryCavanagh:masterfrom
7f-galaxii wants to merge 1 commit intoTerryCavanagh:masterfrom
Conversation
This removes a block of code that checks for specifically vertical screenwrap, and then does horizontal entity wrapping. Under normal circumstances, this code is never reached, because entity bounds aren't expanded in the x-direction if horizontal wrapping is disabled.
Author
|
I ran this PR by both @mothbeanie and @NyakoFox, and they agreed that despite changing behavior, it would not change behavior in any meaningful way. Notably, it does not affect speedrunning, no custom levels have ever used it, and this is behavior that can be replicated by using intended features (setting warp direction to "All"). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
This removes a block of code that checks for specifically vertical screenwrap, and then does horizontal entity wrapping. Under normal circumstances, this code is never reached, because entity bounds aren't expanded in the x-direction if horizontal wrapping is disabled.
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes unless there is a prior written agreement