Merge pull request #1015 from book/fix-version-string-comparisons

fix string comparisons with $] to use numeric comparison instead

Author: exodist

lib/Test2/API.pm

@@ -74,7 +74,7 @@ sub CLONE {
 
 BEGIN {
     no warnings 'once';
-    if($] ge '5.014' || $ENV{T2_CHECK_DEPTH} || $Test2::API::DO_DEPTH_CHECK) {
+    if("$]" >= 5.014 || $ENV{T2_CHECK_DEPTH} || $Test2::API::DO_DEPTH_CHECK) {
         *DO_DEPTH_CHECK = sub() { 1 };
     }
     else {

lib/Test2/Formatter/TAP.pm

@@ -66,7 +66,7 @@ sub _open_handles {
 sub encoding {
     my $self = shift;
 
-    if ($] ge "5.007003" and @_) {
+    if ("$]" >= 5.007003 and @_) {
         my ($enc) = @_;
         my $handles = $self->{+HANDLES};
 

lib/Test2/Tools/Tiny.pm

@@ -3,7 +3,7 @@ use strict;
 use warnings;
 
 BEGIN {
-    if ($] lt "5.008") {
+    if ("$]" < 5.008) {
         require Test::Builder::IO::Scalar;
     }
 }
@@ -260,7 +260,7 @@ sub capture(&) {
 
         ($ok, $e) = try {
           # Scalar refs as filehandles were added in 5.8.
-          if ($] ge "5.008") {
+          if ("$]" >= 5.008) {
             open($out_fh, '>', \$out) or die "Failed to open a temporary STDOUT: $!";
             open($err_fh, '>', \$err) or die "Failed to open a temporary STDERR: $!";
           }

t/HashBase.t

@@ -84,7 +84,7 @@ is($pkg->do_it, 'const', "worked as expected");
 }
 ok(!$pkg->FOO, "overrode const sub");
 {
-local $TODO = "known to fail on $]" if $] le "5.006002";
+local $TODO = "known to fail on $]" if "$]" <= 5.006002;
 is($pkg->do_it, 'const', "worked as expected, const was constant");
 }
 

t/Legacy/Regression/736_use_ok.t

@@ -19,7 +19,7 @@ sub capture(&) {
 }
 
 {
-local $TODO = "known to fail on $]" if $] le "5.006002";
+local $TODO = "known to fail on $]" if "$]" <= 5.006002;
 my $file = __FILE__;
 my $line = __LINE__ + 4;
 like(

t/Legacy/overload_threads.t

@@ -20,7 +20,7 @@ BEGIN {
 
 use Test::More;
 
-plan skip_all => "known to crash on $]" if $] le "5.006002";
+plan skip_all => "known to crash on $]" if "$]" <= 5.006002;
 
 plan tests => 5;
 

t/Legacy_And_Test2/preload_diag_note.t

@@ -1,7 +1,7 @@
 use strict;
 use warnings;
 
-if ($] lt "5.008") {
+if ("$]" < 5.008) {
     print "1..0 # SKIP Test cannot run on perls below 5.8.0\n";
     exit 0;
 }

t/Test2/behavior/init_croak.t

@@ -14,7 +14,7 @@ BEGIN {
     }
 }
 
-skip_all("known to fail on $]") if $] le "5.006002";
+skip_all("known to fail on $]") if "$]" <= 5.006002;
 
 $@ = "";
 my ($file, $line) = (__FILE__, __LINE__ + 1);

t/Test2/behavior/nested_context_exception.t

@@ -5,7 +5,7 @@ use Test2::Tools::Tiny;
 
 use Test2::API qw/context/;
 
-skip_all("known to fail on $]") if $] le "5.006002";
+skip_all("known to fail on $]") if "$]" <= 5.006002;
 
 sub outer {
     my $code = shift;

t/Test2/modules/API.t

@@ -114,7 +114,7 @@ like(
     "got warning about adding driver too late"
 );
 };
-if ($] le "5.006002") {
+if ("$]" <= 5.006002) {
     todo("TODO known to fail on $]", $sub1);
 } else {
     $sub1->();