Skip to content
This repository was archived by the owner on Dec 10, 2025. It is now read-only.

Commit 321b02b

Browse files
committed
Disable engine version checking
1 parent 52597be commit 321b02b

File tree

1 file changed

+13
-11
lines changed

1 file changed

+13
-11
lines changed

src/testcentric.extensibility/ExtensionManager.cs

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -489,17 +489,19 @@ internal void FindExtensionsInAssembly(ExtensionAssembly extensionAssembly)
489489
ExtensionNode extensionNode = BuildExtensionNode(extensionAttr, extensionType, extensionAssembly);
490490
ExtensionPoint? extensionPoint = BuildExtensionPoint(extensionNode, extensionType, extensionAssembly.FromWildCard);
491491

492-
string? versionArg = extensionAttr.GetNamedArgument("EngineVersion") as string;
493-
if (versionArg is not null && !CheckRequiredVersion(versionArg, extensionPoint))
494-
log.Warning($" Ignoring {extensionType.Name}. It requires version {versionArg}.");
495-
else
496-
{
497-
AddExtensionPropertiesToNode(extensionType, extensionNode);
498-
499-
_extensions.Add(extensionNode);
500-
extensionPoint.Install(extensionNode);
501-
log.Info($" Installed at path {extensionNode.Path}");
502-
}
492+
// TODO: Ignoring version requirement for now. Decide whether or how to implement
493+
// it for varying hosts. Replace with ExtensibilityVersion?
494+
//string? versionArg = extensionAttr.GetNamedArgument("EngineVersion") as string;
495+
//if (versionArg is not null && !CheckRequiredVersion(versionArg, extensionPoint))
496+
// log.Warning($" Ignoring {extensionType.Name}. It requires version {versionArg}.");
497+
//else
498+
//{
499+
AddExtensionPropertiesToNode(extensionType, extensionNode);
500+
501+
_extensions.Add(extensionNode);
502+
extensionPoint.Install(extensionNode);
503+
log.Info($" Installed at path {extensionNode.Path}");
504+
//}
503505
}
504506
}
505507
}

0 commit comments

Comments
 (0)