Add 'Test Run Settings' UI to configure engine settings

Author: Wolff, Roald (DI FA HMI EE PRC3)

src/GuiRunner/TestCentric.Gui.Tests/Presenters/Main/WhenTestsAreLoaded.cs

@@ -49,6 +49,7 @@ public void SimulateTestLoad()
         [TestCase("ForceStopButton", false)]
         [TestCase("SaveResultsCommand", false)]
         [TestCase("TransformResultsCommand", false)]
+        [TestCase("TestRunSettingsCommand", true)]
         public void CheckCommandEnabled(string propName, bool enabled)
         {
             ViewElement(propName).Received().Enabled = enabled;

src/GuiRunner/TestCentric.Gui.Tests/Presenters/Main/WhenTestsAreUnloaded.cs

@@ -38,6 +38,7 @@ public void SimulateTestUnload()
         [TestCase("RunParametersButton", false)]
         [TestCase("StopRunButton", false)]
         [TestCase("ForceStopButton", false)]
+        [TestCase("TestRunSettingsCommand", false)]
         public void CheckCommandEnabled(string propName, bool enabled)
         {
             ViewElement(propName).Received().Enabled = enabled;

src/GuiRunner/TestCentric.Gui/Dialogs/SettingsDialog.cs

@@ -19,9 +19,13 @@ public static void Display(TestCentricPresenter presenter, ITestModel model)
             TreeBasedSettingsDialog.Display(presenter, model,
             new GuiSettingsPage("General"),
             new TreeSettingsPage("Tree Display", presenter.ImageSetManager),
-            new AdvancedLoaderSettingsPage("Assembly Load Settings"),
             new AssemblyReloadSettingsPage("Automatic Reload"),
             new ProjectEditorSettingsPage("Project Editor"));
         }
+
+        public static void DisplayTestRunSettings(TestCentricPresenter presenter, ITestModel model)
+        {
+            TreeBasedSettingsDialog.Display(presenter, model, new AdvancedLoaderSettingsPage("Assembly Load Settings"));
+        }
     }
 }

src/GuiRunner/TestCentric.Gui/Presenters/TestCentricPresenter.cs

@@ -494,6 +494,11 @@ void OnRunFinished(ResultNode result)
                 SettingsDialog.Display(this, _model);
             };
 
+            _view.TestRunSettingsCommand.Execute += () =>
+            {
+                SettingsDialog.DisplayTestRunSettings(this, _model);
+            };
+
             _view.TestCentricHelpCommand.Execute += () =>
             {
                 System.Diagnostics.Process.Start("https://test-centric.org/testcentric-gui");
@@ -776,6 +781,7 @@ private void UpdateViewCommands(bool testLoading = false)
             _view.RecentFilesMenu.Enabled = !testRunning && !testLoading;
             _view.ExitCommand.Enabled = !testLoading;
             _view.SaveResultsCommand.Enabled = _view.TransformResultsCommand.Enabled = !testRunning && !testLoading && hasResults;
+            _view.TestRunSettingsCommand.Enabled = testLoaded && !testRunning;
         }
 
         private void UpdateRunSelectedTestsTooltip()

src/GuiRunner/TestCentric.Gui/SettingsPages/AdvancedLoaderSettingsPage.cs

@@ -245,20 +245,26 @@ private void InitializeComponent()
 
         public override void LoadSettings()
         {
+            // Update UI elements based on current settings in TestCentricProject
             int agents = PackageSettings.GetValueOrDefault(SettingDefinitions.MaxAgents);
             numberOfAgentsCheckBox.Checked = agents > 0;
             numberOfAgentsUpDown.Value = agents;
 
             disableShadowCopyCheckBox.Checked = !PackageSettings.GetValueOrDefault(SettingDefinitions.ShadowCopyFiles); ;
 
             string principalPolicy = PackageSettings.GetValueOrDefault(SettingDefinitions.PrincipalPolicy);
+            if (string.IsNullOrEmpty(principalPolicy))
+                principalPolicy = nameof(PrincipalPolicy.UnauthenticatedPrincipal);
+
             principalPolicyCheckBox.Checked = principalPolicyListBox.Enabled =
                 principalPolicy != nameof(PrincipalPolicy.UnauthenticatedPrincipal);
             principalPolicyListBox.SelectedItem = principalPolicy;
         }
 
         public override void ApplySettings()
         {
+            // Check if current values in UI elements differ from those in TestCentricProject
+            // If values differ, add them to SettingsChanges list, so they can be applied later
             int numAgents = numberOfAgentsCheckBox.Checked
                 ? (int)numberOfAgentsUpDown.Value : 0;
             if (numAgents != PackageSettings.GetValueOrDefault(SettingDefinitions.MaxAgents))

src/GuiRunner/TestCentric.Gui/Views/IMainView.cs

@@ -62,6 +62,7 @@ public interface IMainView
         ICommand OpenWorkDirectoryCommand { get; }
         ICommand ExtensionsCommand { get; }
         ICommand SettingsCommand { get; }
+        ICommand TestRunSettingsCommand { get; }
 
         // Help Menu Items
         ICommand TestCentricHelpCommand { get; }

src/GuiRunner/TestCentric.Gui/Views/TestCentricMainView.cs

@@ -42,6 +42,7 @@ public class TestCentricMainView : TestCentricFormBase, IMainView
 
         private System.Windows.Forms.ToolStripMenuItem toolsMenu;
         private System.Windows.Forms.ToolStripMenuItem settingsMenuItem;
+        private System.Windows.Forms.ToolStripMenuItem testRunSettingsMenuItem;
         private System.Windows.Forms.ToolStripMenuItem saveResultsMenuItem;
         private System.Windows.Forms.ToolStripMenuItem transformResultsMenuItem;
 
@@ -142,6 +143,7 @@ public TestCentricMainView() : base("TestCentric")
             CloseProjectCommand = new CommandMenuElement(closeMenuItem);
             AddTestFilesCommand = new CommandMenuElement(addTestFileMenuItem);
             ReloadTestsCommand = new CommandMenuElement(reloadTestsMenuItem);
+            TestRunSettingsCommand = new CommandMenuElement(testRunSettingsMenuItem);
             SelectAgentMenu = new PopupMenuElement(selectAgentMenu);
             RunAsX86 = new CheckedMenuElement(runAsX86MenuItem);
             RecentFilesMenu = new PopupMenuElement(recentFilesMenu);
@@ -287,6 +289,7 @@ private void InitializeComponent()
             this.toolStripSeparator7 = new System.Windows.Forms.ToolStripSeparator();
             this.extensionsMenuItem = new System.Windows.Forms.ToolStripMenuItem();
             this.settingsMenuItem = new System.Windows.Forms.ToolStripMenuItem();
+            this.testRunSettingsMenuItem = new System.Windows.Forms.ToolStripMenuItem();
             this.helpItem = new System.Windows.Forms.ToolStripMenuItem();
             this.testCentricHelpMenuItem = new System.Windows.Forms.ToolStripMenuItem();
             this.nunitHelpMenuItem = new System.Windows.Forms.ToolStripMenuItem();
@@ -580,8 +583,9 @@ private void InitializeComponent()
             this.addTestFileMenuItem,
             this.toolStripSeparator1,
             this.reloadTestsMenuItem,
-            this.selectAgentMenu,
             this.toolStripSeparator2,
+            this.testRunSettingsMenuItem,
+            this.selectAgentMenu,
             this.runAsX86MenuItem,
             this.toolStripSeparator3,
             this.recentFilesMenu,
@@ -866,6 +870,12 @@ private void InitializeComponent()
             this.settingsMenuItem.Size = new System.Drawing.Size(194, 22);
             this.settingsMenuItem.Text = "&Settings...";
             // 
+            // testRunSettingsMenuItem
+            // 
+            this.testRunSettingsMenuItem.Name = "testRunSettingsMenuItem";
+            this.testRunSettingsMenuItem.Size = new System.Drawing.Size(194, 22);
+            this.testRunSettingsMenuItem.Text = "&Test Run Settings...";
+            // 
             // helpItem
             // 
             this.helpItem.DropDownItems.AddRange(new System.Windows.Forms.ToolStripItem[] {
@@ -1202,6 +1212,7 @@ public int SplitterPosition
         public ICommand OpenWorkDirectoryCommand { get; }
         public ICommand ExtensionsCommand { get; }
         public ICommand SettingsCommand { get; }
+        public ICommand TestRunSettingsCommand { get; }
 
         // Help Menu Items
         public ICommand TestCentricHelpCommand { get; }