removed .NET 4 related code

removed conditionally compiled code

Author: Gurpreet Singh

src/TestStack.BDDfy/Configuration/Scanners.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using TestStack.BDDfy.Scanners;
 
 namespace TestStack.BDDfy.Configuration
 {
@@ -11,7 +12,7 @@ public class Scanners
         private readonly StepScannerFactory _methodNameStepScanner = new(() => new DefaultMethodNameStepScanner());
         public StepScannerFactory DefaultMethodNameStepScanner { get { return _methodNameStepScanner; } }
 
-        private readonly List<Func<IStepScanner>> _addedStepScanners = new();
+        private readonly List<Func<IStepScanner>> _addedStepScanners = [];
         public Scanners Add(Func<IStepScanner> stepScannerFactory)
         {
             _addedStepScanners.Add(stepScannerFactory);

src/TestStack.BDDfy/Processors/InconclusiveException.cs

@@ -15,11 +15,5 @@ public InconclusiveException(string message) : base(message)
         public InconclusiveException(string message, Exception innerException) : base(message, innerException)
         {
         }
-#if NET40
-
-        protected InconclusiveException(SerializationInfo info, StreamingContext context) : base(info, context)
-        {
-        }
-#endif
     }
 }

src/TestStack.BDDfy/Scanners/ScenarioScanners/FluentScenarioScanner.cs

@@ -2,46 +2,25 @@
 using System.Linq;
 using TestStack.BDDfy.Configuration;
 
-namespace TestStack.BDDfy
-{
-    public class FluentScenarioScanner(List<Step> steps, string title): IScenarioScanner
-    {
-        private readonly string _title = title;
-        private readonly List<Step> _steps = steps;
-
-        public IEnumerable<Scenario> Scan(ITestContext testContext)
-        {
-            var scenarioText = _title ?? GetTitleFromMethodNameInStackTrace(testContext.TestObject);
-            if (testContext.Examples != null)
-            {
-                var scenarioId = Configurator.IdGenerator.GetScenarioId();
-                return testContext.Examples.Select(example =>
-                    new Scenario(scenarioId, testContext.TestObject, CloneSteps(_steps), scenarioText, example, testContext.Tags));
-            }
+namespace TestStack.BDDfy.Scanners.ScenarioScanners;
 
-            return new[] { new Scenario(testContext.TestObject, _steps, scenarioText, testContext.Tags) };
-        }
+internal class FluentScenarioScanner(List<Step> steps, string title): IScenarioScanner
+{
+    private readonly string _title = title;
+    private readonly List<Step> _steps = steps;
 
-        private List<Step> CloneSteps(IEnumerable<Step> steps)
+    public IEnumerable<Scenario> Scan(ITestContext testContext)
+    {
+        var scenarioText = _title ?? testContext.TestObject.GetType().Name;
+        if (testContext.Examples != null)
         {
-            return steps.Select(step => new Step(step)).ToList();
+            var scenarioId = Configurator.IdGenerator.GetScenarioId();
+            return testContext.Examples.Select(example =>
+                new Scenario(scenarioId, testContext.TestObject, CloneSteps(_steps), scenarioText, example, testContext.Tags));
         }
 
-        private static string GetTitleFromMethodNameInStackTrace(object testObject)
-        {
-            // ReSharper disable once JoinDeclarationAndInitializer
-#if STACKTRACE
-            var trace = new System.Diagnostics.StackTrace();
-            var frames = trace.GetFrames();
-
-            var initiatingFrame = frames?.LastOrDefault(s => s.GetMethod().DeclaringType == testObject.GetType());
-            if (initiatingFrame == null)
-                return null;
-
-            return Configurator.Humanizer.Humanize(initiatingFrame.GetMethod().Name);
-#else
-            return null;
-#endif
-        }
+        return [new Scenario(testContext.TestObject, _steps, scenarioText, testContext.Tags)];
     }
+
+    private static List<Step> CloneSteps(IEnumerable<Step> steps) => [.. steps.Select(static step => new Step(step))];
 }

src/TestStack.BDDfy/Scanners/StepScanners/Fluent/FluentScanner.cs

@@ -4,38 +4,11 @@
 using System.Linq.Expressions;
 using System.Reflection;
 using System.Threading.Tasks;
-using TestStack.BDDfy.Annotations;
 using TestStack.BDDfy.Configuration;
+using TestStack.BDDfy.Scanners.ScenarioScanners;
 
 namespace TestStack.BDDfy
 {
-    /// <summary>
-    /// Provides an alternative method of implementing stories and scenarios.
-    /// </summary>
-    /// <remarks>
-    /// Reflecting scanners run in a pipeline which means you can mix and match their
-    /// usage in your scenario; however, when you use FluentStepScanner, BDDfy does not
-    /// use other scanners which means method names and attributes are ignored for
-    /// scanning methods. You are in full control of what steps you want
-    /// run and in what order.
-    /// </remarks>
-    /// <typeparam name="TScenario"></typeparam>
-    /// <example>
-    /// <code>
-    /// [Fact]
-    /// public void AccountHasSufficientFund()
-    /// {
-    ///     this.Given(s => s.GivenTheAccountBalanceIs(100), GivenTheAccountBalanceIsTitleTemplate)
-    ///             .And(s => s.AndTheCardIsValid())
-    ///             .And(s => s.AndTheMachineContains(100), AndTheMachineContainsEnoughMoneyTitleTemplate)
-    ///         .When(s => s.WhenTheAccountHolderRequests(20), WhenTheAccountHolderRequestsTitleTemplate)
-    ///         .Then(s => s.TheAtmShouldDispense(20), "Then the ATM should dispense $20")
-    ///             .And(s => s.AndTheAccountBalanceShouldBe(80), "And the account balance should be $80")
-    ///             .And(s => s.ThenCardIsRetained(false), AndTheCardShouldBeReturnedTitleTemplate)
-    ///         .BDDfy(storyCategory: "ATM");
-    /// }
-    /// </code>
-    /// </example>
     internal class FluentScanner<TScenario> : IFluentScanner
         where TScenario : class
     {
@@ -48,7 +21,7 @@ internal FluentScanner(TScenario testObject)
         {
             _testObject = testObject;
             _testContext = TestContext.GetContext(_testObject);
-            _fakeExecuteActionMethod = typeof(FluentScanner<TScenario>).GetMethod("ExecuteAction", BindingFlags.Instance | BindingFlags.NonPublic);
+            _fakeExecuteActionMethod = typeof(FluentScanner<TScenario>).GetMethod(nameof(ExecuteAction), BindingFlags.Instance | BindingFlags.NonPublic);
         }
 
         IScanner IFluentScanner.GetScanner(string scenarioTitle, Type explicitStoryType)
@@ -80,9 +53,10 @@ public void AddStep(Expression<Func<ExampleAction>> stepAction, bool reports, Ex
             AddStep(_ => compiledAction().Action(), expression, null, true, reports, executionOrder, asserts, stepPrefix);
         }
 
-        [UsedImplicitly]
         [StepTitle("")]
-        private void ExecuteAction(ExampleAction action)
+#pragma warning disable CA1822 // Mark members as static
+        private void ExecuteAction(ExampleAction _)
+#pragma warning restore CA1822 // Mark members as static
         {
 
         }

src/TestStack.BDDfy/Scanners/StepScanners/StepTitleException.cs

@@ -15,12 +15,5 @@ public StepTitleException(string message) : base(message)
         public StepTitleException(string message, Exception innerException) : base(message, innerException)
         {
         }
- #if NET40
-
-       protected StepTitleException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
-#endif
     }
 }

src/TestStack.BDDfy/Scanners/StoryAttributeMetaDataScanner.cs

@@ -1,9 +1,9 @@
 using System;
 using System.Linq;
 
-namespace TestStack.BDDfy
+namespace TestStack.BDDfy.Scanners
 {
-    public class StoryAttributeMetadataScanner : IStoryMetadataScanner
+    internal class StoryAttributeMetadataScanner : IStoryMetadataScanner
     {
         public virtual StoryMetadata Scan(object testObject, Type explicitStoryType = null)
         {
@@ -38,22 +38,9 @@ protected virtual Type GetCandidateStory(object testObject, Type explicitStoryTy
             if (explicitStoryType != null)
                 return explicitStoryType;
 
-#if STACKTRACE
-            StackTrace stackTrace = new StackTrace();
-
-            var frames = stackTrace.GetFrames();
-            if (frames == null)
-                return null;
-            var scenarioType = testObject.GetType();
-            // This is assuming scenario and story live in the same assembly
-            var firstFrame = frames.LastOrDefault(f => f.GetMethod().DeclaringType.Assembly() == scenarioType.Assembly());
-            if (firstFrame == null)
-                return null;
-
-            return firstFrame.GetMethod().DeclaringType;
-#else
-            return null;
-#endif
+            var testObjectType = testObject.GetType();
+            var declaringType = testObjectType.DeclaringType;
+            return declaringType ?? testObjectType;
         }
 
         static StoryNarrativeAttribute GetStoryAttribute(Type candidateStoryType)