fix path scrubber to work with windows and linux

Author: Gurpreet Singh

src/TestStack.BDDfy.Tests/Reporters/MarkDown/MarkDownReportBuilderTests.cs

@@ -12,7 +12,8 @@ public class MarkDownReportBuilderTests
         [MethodImpl(MethodImplOptions.NoInlining)]
         public void ShouldProduceExpectedMarkdown()
         {
-            var model = new FileReportModel(new ReportTestData().CreateMixContainingEachTypeOfOutcome().ToReportModel());
+            var reportModel = new ReportTestData().CreateMixContainingEachTypeOfOutcome().ToReportModel();
+            var model = new FileReportModel(reportModel);
             var sut = new MarkDownReportBuilder();
             ReportApprover.Approve(model, sut);
         }
@@ -21,12 +22,14 @@ public void ShouldProduceExpectedMarkdown()
         [MethodImpl(MethodImplOptions.NoInlining)]
         public void ShouldProduceExpectedMarkdownWithExamples()
         {
-            var model = 
-                new FileReportModel(new ReportTestData().CreateTwoStoriesEachWithOneFailingScenarioAndOnePassingScenarioWithThreeStepsOfFiveMillisecondsAndEachHasTwoExamples()
-                    .ToReportModel())
-                {
-                    RunDate = new DateTime(2014, 3, 25, 11, 30, 5)
-                };
+            var reportModel = new ReportTestData()
+                .CreateTwoStoriesEachWithOneFailingScenarioAndOnePassingScenarioWithThreeStepsOfFiveMillisecondsAndEachHasTwoExamples()
+                .ToReportModel();
+
+            var model =  new FileReportModel(reportModel)
+            {
+                RunDate = new DateTime(2014, 3, 25, 11, 30, 5)
+            };
 
             var sut = new MarkDownReportBuilder();
             ReportApprover.Approve(model, sut);

src/TestStack.BDDfy.Tests/Reporters/ReportApprover.cs

@@ -35,7 +35,8 @@ static string ScrubLineNumbers(string source)
 
         static string ScrubPaths(string source)
         {
-            var result = new Regex(@"\b\w:[\\\w.\s-]+\\").Replace(source, "...\\");
+            var result = Regex.Replace(source, @"^.*[\\/]", @"...\");
+            //var result = new Regex(@"\b\w:[\\\w.\s-]+\\").Replace(source, "...\\");
             return result;
         }
     }

src/TestStack.BDDfy/Reporters/MarkDown/MarkDownReportBuilder.cs

@@ -8,7 +8,7 @@ namespace TestStack.BDDfy.Reporters.MarkDown
 {
     public class MarkDownReportBuilder : IReportBuilder
     {
-        private readonly List<Exception> _exceptions = new();
+        private readonly List<Exception> _exceptions = [];
 
         public string CreateReport(FileReportModel model)
         {
@@ -38,7 +38,7 @@ public string CreateReport(FileReportModel model)
                         var exampleScenario = story.Scenarios.First();
                         report.AppendLine(string.Format("### {0}", exampleScenario.Title));
 
-                        if (exampleScenario.Steps.Any())
+                        if (exampleScenario.Steps.Count != 0)
                         {
                             foreach (var step in exampleScenario.Steps.Where(s => s.ShouldReport))
                                 report.AppendLine("  " + WebUtility.HtmlEncode(step.Title) + "  ");
@@ -72,9 +72,9 @@ public string CreateReport(FileReportModel model)
             return report.ToString();
         }
 
-        private void ReportTags(StringBuilder report, List<string> tags)
+        private static void ReportTags(StringBuilder report, List<string> tags)
         {
-            if (!tags.Any())
+            if (tags.Count == 0)
                 return;
 
             report.AppendLine(string.Format("Tags: {0}", string.Join(", ", tags.Select(t => string.Format("`{0}`", t)))));
@@ -91,7 +91,7 @@ private void WriteExamples(StringBuilder report, ReportModel.Scenario exampleSce
             var maxWidth = new int[numberColumns];
             var rows = new List<string[]>();
 
-            Action<IEnumerable<string>, string, string> addRow = (cells, result, error) =>
+            void addRow(IEnumerable<string> cells, string result, string error)
             {
                 var row = new string[numberColumns];
                 var index = 0;
@@ -113,7 +113,7 @@ private void WriteExamples(StringBuilder report, ReportModel.Scenario exampleSce
                 }
 
                 rows.Add(row);
-            };
+            }
 
             addRow(exampleScenario.Example.Headers, "Result", "Errors");
             foreach (var scenario in scenarios)
@@ -130,7 +130,7 @@ private void WriteExamples(StringBuilder report, ReportModel.Scenario exampleSce
                 WriteExampleRow(report, row, maxWidth);
         }
 
-        private void WriteExampleRow(StringBuilder report, string[] row, int[] maxWidth)
+        private static void WriteExampleRow(StringBuilder report, string[] row, int[] maxWidth)
         {
             report.Append("    ");
             for (int index = 0; index < row.Length; index++)
@@ -173,7 +173,7 @@ void ReportExceptions(StringBuilder report)
                 else
                     report.AppendLine();
 
-                var stackTrace = string.Join(Environment.NewLine, exception.StackTrace.Split(new[] { Environment.NewLine }, StringSplitOptions.None)
+                var stackTrace = string.Join(Environment.NewLine, exception.StackTrace.Split([Environment.NewLine], StringSplitOptions.None)
                     .Select(s => "    " + s));
                 report.AppendLine(stackTrace);
             }
@@ -185,7 +185,7 @@ static string FlattenExceptionMessage(string message)
         {
             return string.Join(" ", message
                 .Replace("\t", " ") // replace tab with one space
-                .Split(new[] { "\r\n", "\n" }, StringSplitOptions.None)
+                .Split(["\r\n", "\n"], StringSplitOptions.None)
                 .Select(s => s.Trim()))
                 .TrimEnd(','); // chop any , from the end
         }