Reordered the ConventionResult.For arguments

Author: Jake Ginnivan

TestStack.ConventionTests.Tests/ConventionAssertionClassTests.cs

@@ -30,7 +30,7 @@ public class FailingConvention : IConvention<FakeData>
         {
             public ConventionResult Execute(FakeData data)
             {
-                return ConventionResult.For(new[] { "" }, "Header", (s, builder) => builder.AppendLine("Different"));
+                return ConventionResult.For("Header", new[] { "" }, (s, builder) => builder.AppendLine("Different"));
             }
         }
     }

TestStack.ConventionTests/Conventions/AllMethodsAreVirtual.cs

@@ -25,7 +25,7 @@ public ConventionResult Execute(Types data)
                         let nonVirtuals = applicableType.NonVirtualMethods()
                         where nonVirtuals.Any()
                         select Tuple.Create(applicableType, nonVirtuals);
-            return ConventionResult.For(items, HeaderMessage, DescribeTypeAndMethods);
+            return ConventionResult.For(HeaderMessage, items, DescribeTypeAndMethods);
         }
 
         // I like how that's encapsulated in the reusable convention type, whereas previously it was part of the convention/test code

TestStack.ConventionTests/Conventions/FilesAreEmbeddedResources.cs

@@ -8,9 +8,8 @@ public class FilesAreEmbeddedResources : IConvention<ProjectFiles>
     {
         public ConventionResult Execute(ProjectFiles data)
         {
-            return ConventionResult.For(data.Files.Where(s => s.ReferenceType != "EmbeddedResource"),
-                "The following files which should be embedded resources:",
-                (t, m) => m.AppendLine("\t" + t.FilePath));
+            return ConventionResult.For("The following files which should be embedded resources:",
+                data.Files.Where(s => s.ReferenceType != "EmbeddedResource"), (t, m) => m.AppendLine("\t" + t.FilePath));
         }
     }
 }

TestStack.ConventionTests/Conventions/ProjectDoesNotReferenceDllsFromBinOrObjDirectories.cs

@@ -14,7 +14,7 @@ public ConventionResult Execute(ProjectReferences data)
         {
             var invalid = data.References.Where(IsBinOrObjReference);
             var header = string.Format("Some invalid assembly references found in {0}", data.Assembly.GetName().Name);
-            return ConventionResult.For(invalid, header, FormatLine);
+            return ConventionResult.For(header, invalid, FormatLine);
         }
 
         void FormatLine(ProjectReference assemblyReference, StringBuilder m)

TestStack.ConventionTests/Internal/ConventionResult.cs

@@ -19,8 +19,7 @@ public bool Failed
         }
 
         public static ConventionResult For<TResult>(
-            IEnumerable<TResult> items,
-            string header,
+            string header, IEnumerable<TResult> items, 
             Action<TResult, StringBuilder> itemDescriptor)
         {
             var array = items.ToArray();
@@ -41,11 +40,10 @@ public static ConventionResult For<TResult>(
         }
 
         public static ConventionResult For<TResult>(
-            IEnumerable<TResult> items,
-            string header,
+            IEnumerable<TResult> items, string header,
             Func<TResult, string> itemDescriptor)
         {
-            return For(items, header, (item, message) => message.AppendLine(itemDescriptor(item)));
+            return For(header, items, (item, message) => message.AppendLine(itemDescriptor(item)));
         }
 
         public static ConventionResult ForSymmetric<TResult>(