converted IConventionReportRenderer to IResultsProcessor

This seems like a better abstraction, especially that some of them actually not render anything but approve/validate the results.
This seems like a better abstraction not imposing any particular way the result should be handled

Author: kkozmic

TestStack.ConventionTests/Convention.cs

@@ -35,7 +35,7 @@ public static void Is<TDataSource>(IConvention<TDataSource> convention, TDataSou
             Is(convention, data, new ConventionResultExceptionReporter());
         }
 
-        public static void Is<TDataSource>(IConvention<TDataSource> convention, TDataSource data, IConventionReportRenderer reporter) 
+        public static void Is<TDataSource>(IConvention<TDataSource> convention, TDataSource data, IResultsProcessor reporter) 
             where TDataSource : IConventionData
         {
             try
@@ -44,12 +44,12 @@ public static void Is<TDataSource>(IConvention<TDataSource> convention, TDataSou
                 var conventionResult = context.GetConventionResults(convention, data);
                 Reports.AddRange(conventionResult);
 
-                new ConventionReportTraceRenderer().Render(conventionResult);
-                reporter.Render(conventionResult);
+                new ConventionReportTraceRenderer().Process(conventionResult);
+                reporter.Process(conventionResult);
             }
             finally
             {
-                HtmlRenderer.Render(Reports.ToArray());
+                HtmlRenderer.Process(Reports.ToArray());
             }
         }
 
@@ -63,18 +63,18 @@ public static void IsWithApprovedExeptions<TDataSource>(IConvention<TDataSource>
             try
             {
                 var conventionReportTextRenderer = new ConventionReportTextRenderer();
-                conventionReportTextRenderer.Render(conventionResult);
+                conventionReportTextRenderer.Process(conventionResult);
                 Approvals.Verify(conventionReportTextRenderer.Output);
 
-                new ConventionReportTraceRenderer().Render(conventionResult);
+                new ConventionReportTraceRenderer().Process(conventionResult);
             }
             catch (ApprovalException ex)
             {
                 throw new ConventionFailedException("Approved exceptions for convention differs\r\n\r\n"+ex.Message, ex);
             }
             finally
             {
-                HtmlRenderer.Render(Reports.ToArray());
+                HtmlRenderer.Process(Reports.ToArray());
             }
         }
 

TestStack.ConventionTests/Internal/IResultsProcessor.cs

@@ -3,9 +3,9 @@
     using System.Text;
     using TestStack.ConventionTests.Internal;
 
-    public class ConventionReportTextRenderer : IConventionReportRenderer
+    public class ConventionReportTextRenderer : IResultsProcessor
     {
-        public void Render(params ConventionResult[] conventionResult)
+        public void Process(params ConventionResult[] conventionResult)
         {
             var stringBuilder = new StringBuilder();
 

TestStack.ConventionTests/Reporting/ConventionReportTextRenderer.cs

@@ -3,12 +3,12 @@
     using System.Diagnostics;
     using TestStack.ConventionTests.Internal;
 
-    public class ConventionReportTraceRenderer : IConventionReportRenderer
+    public class ConventionReportTraceRenderer : IResultsProcessor
     {
-        public void Render(params ConventionResult[] conventionResult)
+        public void Process(params ConventionResult[] conventionResult)
         {
             var conventionReportTextRenderer = new ConventionReportTextRenderer();
-            conventionReportTextRenderer.Render(conventionResult);
+            conventionReportTextRenderer.Process(conventionResult);
             Trace.WriteLine(conventionReportTextRenderer.Output);
         }
     }

TestStack.ConventionTests/Reporting/ConventionReportTraceRenderer.cs

@@ -3,12 +3,12 @@
     using System.Linq;
     using TestStack.ConventionTests.Internal;
 
-    public class ConventionResultExceptionReporter : IConventionReportRenderer
+    public class ConventionResultExceptionReporter : IResultsProcessor
     {
-        public void Render(params ConventionResult[] conventionResult)
+        public void Process(params ConventionResult[] conventionResult)
         {
             var conventionReportTextRenderer = new ConventionReportTextRenderer();
-            conventionReportTextRenderer.Render(conventionResult);
+            conventionReportTextRenderer.Process(conventionResult);
             if (conventionResult.Any(r => r.Result == TestResult.Failed))
             {
                 throw new ConventionFailedException(conventionReportTextRenderer.Output);

TestStack.ConventionTests/Reporting/ConventionResultExceptionReporter.cs

@@ -5,7 +5,7 @@
     using System.Web.UI;
     using TestStack.ConventionTests.Internal;
 
-    public class HtmlReportRenderer : IConventionReportRenderer
+    public class HtmlReportRenderer : IResultsProcessor
     {
         readonly string file;
 
@@ -14,7 +14,7 @@ public HtmlReportRenderer(string assemblyDirectory)
             file = Path.Combine(assemblyDirectory, "Conventions.htm");
         }
 
-        public void Render(params ConventionResult[] conventionResult)
+        public void Process(params ConventionResult[] conventionResult)
         {
             var sb = new StringBuilder();
             var html = new HtmlTextWriter(new StringWriter(sb));

TestStack.ConventionTests/Reporting/HtmlReportRenderer.cs

@@ -0,0 +1,9 @@
+namespace TestStack.ConventionTests.Reporting
+{
+    using TestStack.ConventionTests.Internal;
+
+    public interface IResultsProcessor
+    {
+        void Process(params ConventionResult[] conventionResult);
+    }
+}

TestStack.ConventionTests/Reporting/IConventionReportRenderer.cs

@@ -63,7 +63,6 @@
     <Compile Include="Internal\ConventionReportFailure.cs" />
     <Compile Include="Internal\ConventionContext.cs" />
     <Compile Include="Internal\ConventionResult.cs" />
-    <Compile Include="Internal\IResultsProcessor.cs" />
     <Compile Include="Internal\NoDataFormatterFoundException.cs" />
     <Compile Include="Reporting\CsvReporter.cs" />
     <Compile Include="Reporting\DefaultFormatter.cs" />
@@ -81,7 +80,7 @@
     <Compile Include="Conventions\AllMethodsAreVirtual.cs" />
     <Compile Include="Conventions\AllClassesHaveDefaultConstructor.cs" />
     <Compile Include="Conventions\FilesAreEmbeddedResources.cs" />
-    <Compile Include="Reporting\IConventionReportRenderer.cs" />
+    <Compile Include="Reporting\IResultsProcessor.cs" />
     <Compile Include="Reporting\IReportDataFormatter.cs" />
     <Compile Include="Internal\AssemblyProjectLocator.cs" />
     <Compile Include="Convention.cs" />