Added MvcConventions test

Author: Jake Ginnivan

TestAssembly/Controllers/BarApiControler.cs

@@ -0,0 +1,9 @@
+namespace TestAssembly.Controllers
+{
+    using System.Web.Http;
+
+    public class BarApiControler : ApiController
+    {
+         
+    }
+}

TestAssembly/Controllers/FooControler.cs

@@ -0,0 +1,9 @@
+namespace TestAssembly.Controllers
+{
+    using System.Web.Mvc;
+
+    public class FooControler : Controller
+    {
+         
+    }
+}

TestAssembly/Controllers/MyApiController.cs

@@ -0,0 +1,9 @@
+namespace TestAssembly.Controllers
+{
+    using System.Web.Http;
+
+    public class MyApiController : ApiController
+    {
+         
+    }
+}

TestAssembly/Controllers/TestController.cs

@@ -0,0 +1,7 @@
+namespace TestAssembly.Controllers
+{
+    public class TestController
+    {
+         
+    }
+}

TestAssembly/TestAssembly.csproj

@@ -73,6 +73,11 @@
     <Compile Include="Collections\ICanRemove.cs" />
     <Compile Include="Collections\Leaf.cs" />
     <Compile Include="Collections\Tree.cs" />
+    <Compile Include="Controllers\BarApiControler.cs" />
+    <Compile Include="Controllers\FooControler.cs" />
+    <Compile Include="Controllers\MyApiController.cs" />
+    <Compile Include="Controllers\TestApiController.cs" />
+    <Compile Include="Controllers\TestController.cs" />
     <Compile Include="Dtos\AnotherClass.cs" />
     <Compile Include="Dtos\BlahDto.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />

TestStack.ConventionTests.Tests/MvcConventions.api_controller_conventions.approved.txt

@@ -0,0 +1,11 @@
+Failed: 'WebApi controllers must be suffixed with Controller' for 'TestAssembly'
+--------------------------------------------------------------------------------
+
+	TestAssembly.Controllers.BarApiControler
+
+
+Failed: 'Types named *Controller must inherit from ApiController or Controller' for 'TestAssembly'
+--------------------------------------------------------------------------------------------------
+
+	TestAssembly.Controllers.TestApiController
+	TestAssembly.Controllers.TestController

TestStack.ConventionTests.Tests/MvcConventions.controller_conventions.approved.txt

@@ -0,0 +1,11 @@
+Failed: 'Mvc controllers must be suffixed with Controller' for 'TestAssembly'
+-----------------------------------------------------------------------------
+
+	TestAssembly.Controllers.FooControler
+
+
+Failed: 'Types named *Controller must inherit from ApiController or Controller' for 'TestAssembly'
+--------------------------------------------------------------------------------------------------
+
+	TestAssembly.Controllers.TestApiController
+	TestAssembly.Controllers.TestController

TestStack.ConventionTests.Tests/MvcConventions.cs

@@ -0,0 +1,34 @@
+namespace TestStack.ConventionTests.Tests
+{
+    using ApprovalTests;
+    using ApprovalTests.Reporters;
+    using NUnit.Framework;
+    using TestAssembly.Controllers;
+    using TestStack.ConventionTests.ConventionData;
+    using TestStack.ConventionTests.Conventions;
+
+    [TestFixture]
+    [UseReporter(typeof(DiffReporter))] 
+    public class MvcConventions
+    {
+        [Test]
+        public void controller_conventions()
+        {
+            var types = Types.InAssemblyOf<TestController>();
+            var convention = new MvcControllerConvention();
+
+            var ex = Assert.Throws<ConventionFailedException>(() => Convention.Is(convention, types));
+            Approvals.Verify(ex.Message);
+        }
+
+        [Test]
+        public void api_controller_conventions()
+        {
+            var types = Types.InAssemblyOf<TestController>();
+            var convention = new ApiControllerConvention();
+
+            var ex = Assert.Throws<ConventionFailedException>(() => Convention.Is(convention, types));
+            Approvals.Verify(ex.Message);
+        } 
+    }
+}

TestStack.ConventionTests.Tests/TestStack.ConventionTests.Tests.csproj

@@ -53,6 +53,7 @@
   <ItemGroup>
     <Compile Include="ConventionAssertionClassTests.cs" />
     <Compile Include="CsvReportTests.cs" />
+    <Compile Include="MvcConventions.cs" />
     <Compile Include="ProjectBasedConventions.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="Properties\Resources.Designer.cs">