Changing BuildDataList to BuildList it sounds better

robdmoore · robdmoore · commit 43ea66b47d17 · 2013-05-26T14:48:09.000+08:00
diff --git a/NTestDataBuilder.Tests/BuildListTests.cs b/NTestDataBuilder.Tests/BuildListTests.cs
@@ -6,34 +6,34 @@
 
 namespace NTestDataBuilder.Tests
 {
-    class BuildDataListTests
+    class BuildListTests
     {
         [Test]
-        public void GivenListOfBuilders_WhenCallingBuildDataList_ThenAListOfEntitiesOfTheRightSizeShouldBeReturned()
+        public void GivenListOfBuilders_WhenCallingBuildList_ThenAListOfEntitiesOfTheRightSizeShouldBeReturned()
         {
             var builders = BasicCustomerBuilder.CreateListOfSize(5);
 
-            var entities = builders.BuildDataList<Customer, BasicCustomerBuilder>();
+            var entities = builders.BuildList<Customer, BasicCustomerBuilder>();
 
             Assert.That(entities, Has.Count.EqualTo(5));
         }
 
         [Test]
-        public void GivenListOfBuilders_WhenCallingBuildDataList_ThenAListOfEntitiesOfTheRightTypeShouldBeReturned()
+        public void GivenListOfBuilders_WhenCallingBuildList_ThenAListOfEntitiesOfTheRightTypeShouldBeReturned()
         {
             var builders = BasicCustomerBuilder.CreateListOfSize(5);
 
-            var entities = builders.BuildDataList<Customer, BasicCustomerBuilder>();
+            var entities = builders.BuildList<Customer, BasicCustomerBuilder>();
 
             Assert.That(entities, Has.All.With.TypeOf<Customer>());
         }
 
         [Test]
-        public void GivenListOfBuilders_WhenCallingBuildDataList_ThenAListOfUniqueEntitiesShouldBeReturned()
+        public void GivenListOfBuilders_WhenCallingBuildList_ThenAListOfUniqueEntitiesShouldBeReturned()
         {
             var builders = BasicCustomerBuilder.CreateListOfSize(5);
 
-            var entities = builders.BuildDataList<Customer, BasicCustomerBuilder>();
+            var entities = builders.BuildList<Customer, BasicCustomerBuilder>();
 
             Assert.That(entities, Is.Unique);
         }
@@ -43,7 +43,7 @@ public void GivenListOfBuildersWithNoCustomisation_WhenCallingExtensionMethodToB
         {
             var builders = CustomerBuilder.CreateListOfSize(5);
 
-            var entities = builders.BuildDataList();
+            var entities = builders.BuildList();
 
             Assert.That(entities, Has.Count.EqualTo(5));
         }
@@ -53,7 +53,7 @@ public void GivenListOfBuildersWithNoCustomisation_WhenCallingExtensionMethodToB
         {
             var builders = CustomerBuilder.CreateListOfSize(5);
 
-            var entities = builders.BuildDataList();
+            var entities = builders.BuildList();
 
             Assert.That(entities, Has.All.TypeOf<Customer>());
         }
@@ -63,7 +63,7 @@ public void GivenListOfBuildersWithNoCustomisation_WhenCallingExtensionMethodToB
         {
             var builders = CustomerBuilder.CreateListOfSize(5);
 
-            var entities = builders.BuildDataList();
+            var entities = builders.BuildList();
 
             Assert.That(entities, Is.Unique);
         }
@@ -75,7 +75,7 @@ public void GivenListOfBuildersWithCustomisation_WhenCallingExtensionMethodToBui
             var list = CustomerBuilder.CreateListOfSize(3)
                 .All().With(b => b.WithFirstName(generator.Generate().ToString()));
 
-            var data = list.BuildDataList();
+            var data = list.BuildList();
 
             Assert.That(data.Select(c => c.FirstName), Is.EqualTo(new[]{"0", "1", "2"}));
         }
diff --git a/NTestDataBuilder.Tests/Builders/CustomerBuilder.cs b/NTestDataBuilder.Tests/Builders/CustomerBuilder.cs
@@ -6,14 +6,14 @@ namespace NTestDataBuilder.Tests.Builders
 {
     static class CustomerBuilderExtensions
     {
-        public static IList<Customer> BuildDataList(this IOperable<CustomerBuilder> list)
+        public static IList<Customer> BuildList(this IOperable<CustomerBuilder> list)
         {
-            return list.BuildDataList<Customer, CustomerBuilder>();
+            return list.BuildList<Customer, CustomerBuilder>();
         }
 
-        public static IList<Customer> BuildDataList(this IListBuilder<CustomerBuilder> list)
+        public static IList<Customer> BuildList(this IListBuilder<CustomerBuilder> list)
         {
-            return list.BuildDataList<Customer, CustomerBuilder>();
+            return list.BuildList<Customer, CustomerBuilder>();
         }
     }
 
diff --git a/NTestDataBuilder.Tests/NTestDataBuilder.Tests.csproj b/NTestDataBuilder.Tests/NTestDataBuilder.Tests.csproj
@@ -48,7 +48,7 @@
   </ItemGroup>
   <ItemGroup>
     <Compile Include="AsProxyTests.cs" />
-    <Compile Include="BuildDataListTests.cs" />
+    <Compile Include="BuildListTests.cs" />
     <Compile Include="Builders\BasicCustomerBuilder.cs" />
     <Compile Include="Builders\CustomerBuilder.cs" />
     <Compile Include="Builders\ProxyAlteringCustomerBuilder.cs" />
diff --git a/NTestDataBuilder/DataBuilderExtensions.cs b/NTestDataBuilder/DataBuilderExtensions.cs
@@ -16,7 +16,7 @@ public static class DataBuilderExtensions
         /// <typeparam name="TObject">The type of object being generated</typeparam>
         /// <param name="builderList">The NBuilder list of builders</param>
         /// <returns>The built list of objects</returns>
-        public static IList<TObject> BuildDataList<TObject, TBuilder>(this IOperable<TBuilder> builderList)
+        public static IList<TObject> BuildList<TObject, TBuilder>(this IOperable<TBuilder> builderList)
             where TBuilder : IDataBuilder<TObject>
             where TObject : class
         {
@@ -30,11 +30,11 @@ public static IList<TObject> BuildDataList<TObject, TBuilder>(this IOperable<TBu
         /// <typeparam name="TObject">The type of object being generated</typeparam>
         /// <param name="builderList">The NBuilder list of builders</param>
         /// <returns>The built list of objects</returns>
-        public static IList<TObject> BuildDataList<TObject, TBuilder>(this IListBuilder<TBuilder> builderList)
+        public static IList<TObject> BuildList<TObject, TBuilder>(this IListBuilder<TBuilder> builderList)
             where TBuilder : IDataBuilder<TObject>
             where TObject : class
         {
-            return builderList.All().BuildDataList<TObject, TBuilder>();
+            return builderList.All().BuildList<TObject, TBuilder>();
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -6,34 +6,34 @@`
`6`	`6`
`7`	`7`	`namespace NTestDataBuilder.Tests`
`8`	`8`	`{`
`9`		`- class BuildDataListTests`
	`9`	`+ class BuildListTests`
`10`	`10`	`{`
`11`	`11`	`[Test]`
`12`		`- public void GivenListOfBuilders_WhenCallingBuildDataList_ThenAListOfEntitiesOfTheRightSizeShouldBeReturned()`
	`12`	`+ public void GivenListOfBuilders_WhenCallingBuildList_ThenAListOfEntitiesOfTheRightSizeShouldBeReturned()`
`13`	`13`	`{`
`14`	`14`	`var builders = BasicCustomerBuilder.CreateListOfSize(5);`
`15`	`15`
`16`		`- var entities = builders.BuildDataList<Customer, BasicCustomerBuilder>();`
	`16`	`+ var entities = builders.BuildList<Customer, BasicCustomerBuilder>();`
`17`	`17`
`18`	`18`	`Assert.That(entities, Has.Count.EqualTo(5));`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`[Test]`
`22`		`- public void GivenListOfBuilders_WhenCallingBuildDataList_ThenAListOfEntitiesOfTheRightTypeShouldBeReturned()`
	`22`	`+ public void GivenListOfBuilders_WhenCallingBuildList_ThenAListOfEntitiesOfTheRightTypeShouldBeReturned()`
`23`	`23`	`{`
`24`	`24`	`var builders = BasicCustomerBuilder.CreateListOfSize(5);`
`25`	`25`
`26`		`- var entities = builders.BuildDataList<Customer, BasicCustomerBuilder>();`
	`26`	`+ var entities = builders.BuildList<Customer, BasicCustomerBuilder>();`
`27`	`27`
`28`	`28`	`Assert.That(entities, Has.All.With.TypeOf<Customer>());`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`[Test]`
`32`		`- public void GivenListOfBuilders_WhenCallingBuildDataList_ThenAListOfUniqueEntitiesShouldBeReturned()`
	`32`	`+ public void GivenListOfBuilders_WhenCallingBuildList_ThenAListOfUniqueEntitiesShouldBeReturned()`
`33`	`33`	`{`
`34`	`34`	`var builders = BasicCustomerBuilder.CreateListOfSize(5);`
`35`	`35`
`36`		`- var entities = builders.BuildDataList<Customer, BasicCustomerBuilder>();`
	`36`	`+ var entities = builders.BuildList<Customer, BasicCustomerBuilder>();`
`37`	`37`
`38`	`38`	`Assert.That(entities, Is.Unique);`
`39`	`39`	`}`
`@@ -43,7 +43,7 @@ public void GivenListOfBuildersWithNoCustomisation_WhenCallingExtensionMethodToB`
`43`	`43`	`{`
`44`	`44`	`var builders = CustomerBuilder.CreateListOfSize(5);`
`45`	`45`
`46`		`- var entities = builders.BuildDataList();`
	`46`	`+ var entities = builders.BuildList();`
`47`	`47`
`48`	`48`	`Assert.That(entities, Has.Count.EqualTo(5));`
`49`	`49`	`}`
`@@ -53,7 +53,7 @@ public void GivenListOfBuildersWithNoCustomisation_WhenCallingExtensionMethodToB`
`53`	`53`	`{`
`54`	`54`	`var builders = CustomerBuilder.CreateListOfSize(5);`
`55`	`55`
`56`		`- var entities = builders.BuildDataList();`
	`56`	`+ var entities = builders.BuildList();`
`57`	`57`
`58`	`58`	`Assert.That(entities, Has.All.TypeOf<Customer>());`
`59`	`59`	`}`
`@@ -63,7 +63,7 @@ public void GivenListOfBuildersWithNoCustomisation_WhenCallingExtensionMethodToB`
`63`	`63`	`{`
`64`	`64`	`var builders = CustomerBuilder.CreateListOfSize(5);`
`65`	`65`
`66`		`- var entities = builders.BuildDataList();`
	`66`	`+ var entities = builders.BuildList();`
`67`	`67`
`68`	`68`	`Assert.That(entities, Is.Unique);`
`69`	`69`	`}`
`@@ -75,7 +75,7 @@ public void GivenListOfBuildersWithCustomisation_WhenCallingExtensionMethodToBui`
`75`	`75`	`var list = CustomerBuilder.CreateListOfSize(3)`
`76`	`76`	`.All().With(b => b.WithFirstName(generator.Generate().ToString()));`
`77`	`77`
`78`		`- var data = list.BuildDataList();`
	`78`	`+ var data = list.BuildList();`
`79`	`79`
`80`	`80`	`Assert.That(data.Select(c => c.FirstName), Is.EqualTo(new[]{"0", "1", "2"}));`
`81`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,14 +6,14 @@ namespace NTestDataBuilder.Tests.Builders`
`6`	`6`	`{`
`7`	`7`	`static class CustomerBuilderExtensions`
`8`	`8`	`{`
`9`		`- public static IList<Customer> BuildDataList(this IOperable<CustomerBuilder> list)`
	`9`	`+ public static IList<Customer> BuildList(this IOperable<CustomerBuilder> list)`
`10`	`10`	`{`
`11`		`- return list.BuildDataList<Customer, CustomerBuilder>();`
	`11`	`+ return list.BuildList<Customer, CustomerBuilder>();`
`12`	`12`	`}`
`13`	`13`
`14`		`- public static IList<Customer> BuildDataList(this IListBuilder<CustomerBuilder> list)`
	`14`	`+ public static IList<Customer> BuildList(this IListBuilder<CustomerBuilder> list)`
`15`	`15`	`{`
`16`		`- return list.BuildDataList<Customer, CustomerBuilder>();`
	`16`	`+ return list.BuildList<Customer, CustomerBuilder>();`
`17`	`17`	`}`
`18`	`18`	`}`
`19`	`19`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ public static class DataBuilderExtensions`
`16`	`16`	`/// <typeparam name="TObject">The type of object being generated</typeparam>`
`17`	`17`	`/// <param name="builderList">The NBuilder list of builders</param>`
`18`	`18`	`/// <returns>The built list of objects</returns>`
`19`		`- public static IList<TObject> BuildDataList<TObject, TBuilder>(this IOperable<TBuilder> builderList)`
	`19`	`+ public static IList<TObject> BuildList<TObject, TBuilder>(this IOperable<TBuilder> builderList)`
`20`	`20`	`where TBuilder : IDataBuilder<TObject>`
`21`	`21`	`where TObject : class`
`22`	`22`	`{`
`@@ -30,11 +30,11 @@ public static IList<TObject> BuildDataList<TObject, TBuilder>(this IOperable<TBu`
`30`	`30`	`/// <typeparam name="TObject">The type of object being generated</typeparam>`
`31`	`31`	`/// <param name="builderList">The NBuilder list of builders</param>`
`32`	`32`	`/// <returns>The built list of objects</returns>`
`33`		`- public static IList<TObject> BuildDataList<TObject, TBuilder>(this IListBuilder<TBuilder> builderList)`
	`33`	`+ public static IList<TObject> BuildList<TObject, TBuilder>(this IListBuilder<TBuilder> builderList)`
`34`	`34`	`where TBuilder : IDataBuilder<TObject>`
`35`	`35`	`where TObject : class`
`36`	`36`	`{`
`37`		`- return builderList.All().BuildDataList<TObject, TBuilder>();`
	`37`	`+ return builderList.All().BuildList<TObject, TBuilder>();`
`38`	`38`	`}`
`39`	`39`	`}`
`40`	`40`	`}`