Ensured that building a list of entities uses the same anonymous value fixture

This means things like enums will alternate between the generated objects

Author: robdmoore

BREAKING_CHANGES.md

@@ -19,7 +19,7 @@ If you want to fix a static value for a property then by all means you can still
 Version 2.0.0
 -------------
 
-The way that lists are generated no longer uses NBuilder - the new syntax is backwards compatible with NBuilder except that the namespace you need to include is different. You can also refactor your list generation to be a lot more terse, but that is optional. Any `BuildList` extension methods you created will now need to be deleted since they are no longer needed.
+The way that lists are generated no longer uses NBuilder - the new syntax is backwards compatible with NBuilder except that the namespace you need to include is different. You can also refactor your list generation to be a lot more terse, but that is optional. Any `BuildList` extension methods you created will now need to be deleted since they are no longer needed. You also need to ensure that all of the methods you call are marked virtual so the list generation can proxy those method calls.
 
 ### Reason
 In order to support a new, much terser syntax for generating lists we rewrote the list generation code ourselves. You can now do this:
@@ -44,7 +44,7 @@ You also no longer need a custom extension method for the `BuildList` method so
 
 ### Fix
 
-Simply add the following to the files that generate lists of builders and the existing syntax should work:
+Simply add the following to the files that generate lists of builders and change your builder modification methods to be virtual and the existing syntax should work:
 
 ```
 using NTestDataBuilder.Lists;

NTestDataBuilder.Tests/BuildListTests.cs

@@ -84,5 +84,17 @@ public void GivenListOfBuildersWithARangeOfCustomisationMethods_WhenBuildingEnti
             customers[4].LastName.ShouldBe("Last Last");
             customers.ShouldAllBe(c => c.YearJoined == 1999);
         }
+
+        [Fact]
+        public void WhenBuildingEntities_ThenTheAnonymousValueFixtureIsSharedAcrossBuilders()
+        {
+            var customers = CustomerBuilder.CreateListOfSize(5).BuildList();
+
+            customers[0].CustomerClass.ShouldBe(CustomerClass.Normal);
+            customers[1].CustomerClass.ShouldBe(CustomerClass.Bronze);
+            customers[2].CustomerClass.ShouldBe(CustomerClass.Silver);
+            customers[3].CustomerClass.ShouldBe(CustomerClass.Gold);
+            customers[4].CustomerClass.ShouldBe(CustomerClass.Platinum);
+        }
     }
 }

NTestDataBuilder.Tests/Builders/BasicCustomerBuilder.cs

@@ -8,7 +8,7 @@ public class BasicCustomerBuilder : TestDataBuilder<Customer, BasicCustomerBuild
     {
         protected override Customer BuildObject()
         {
-            return new Customer("First Name", "Last Name", 2013);
+            return new Customer("First Name", "Last Name", 2013, CustomerClass.Normal);
         }
 
         public new BasicCustomerBuilder Set<TValue>(Expression<Func<Customer, TValue>> property, TValue value)

NTestDataBuilder.Tests/Builders/CustomerBuilder.cs

@@ -24,7 +24,8 @@ protected override Customer BuildObject()
             return new Customer(
                 Get(x => x.FirstName),
                 Get(x => x.LastName),
-                Get(x => x.YearJoined)
+                Get(x => x.YearJoined),
+                Get(x => x.CustomerClass)
             );
         }
     }

NTestDataBuilder.Tests/Entities/Customer.cs

@@ -6,7 +6,7 @@ public class Customer
     {
         protected Customer() {}
 
-        public Customer(string firstName, string lastName, int yearJoined)
+        public Customer(string firstName, string lastName, int yearJoined, CustomerClass customerClass)
         {
             if (string.IsNullOrEmpty(firstName))
                 throw new ArgumentNullException("firstName");
@@ -16,6 +16,7 @@ public Customer(string firstName, string lastName, int yearJoined)
             FirstName = firstName;
             LastName = lastName;
             YearJoined = yearJoined;
+            CustomerClass = customerClass;
         }
 
         public virtual int CustomerForHowManyYears(DateTime since)
@@ -28,5 +29,6 @@ public virtual int CustomerForHowManyYears(DateTime since)
         public virtual string FirstName { get; private set; }
         public virtual string LastName { get; private set; }
         public virtual int YearJoined { get; private set; }
+        public virtual CustomerClass CustomerClass { get; private set; }
     }
 }

NTestDataBuilder.Tests/Entities/CustomerClass.cs

@@ -0,0 +1,11 @@
+namespace NTestDataBuilder.Tests.Entities
+{
+    public enum CustomerClass
+    {
+        Normal,
+        Bronze,
+        Silver,
+        Gold,
+        Platinum
+    }
+}

NTestDataBuilder.Tests/NTestDataBuilder.Tests.csproj

@@ -49,6 +49,7 @@
     </Reference>
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="Entities\CustomerClass.cs" />
     <Compile Include="DataSources\DataSourceTests.cs" />
     <Compile Include="DataSources\Dictionaries\CacheTests.cs" />
     <Compile Include="DataSources\Dictionaries\FileDictionaryRepositoryIntegrationTests.cs" />

NTestDataBuilder/Lists/EnsureAllMethodsVirtual.cs

@@ -13,7 +13,7 @@ public void MethodsInspected()
 
         public void NonProxyableMemberNotification(Type type, MemberInfo memberInfo)
         {
-            if (new[]{"get_Any", "Build", "AsProxy", "Get", "GetOrDefault", "Set", "Has", "get_ListBuilder", "set_ListBuilder"}.Contains(memberInfo.Name))
+            if (new[]{"get_Any", "set_Any", "Build", "AsProxy", "Get", "GetOrDefault", "Set", "Has", "get_ListBuilder", "set_ListBuilder"}.Contains(memberInfo.Name))
                 return;
             throw new InvalidOperationException(string.Format("Tried to build a list with a builder who has non-virtual method. Please make {0} on type {1} virtual.", memberInfo.Name, type.Name));
         }

NTestDataBuilder/Lists/ListBuilder.cs

@@ -24,8 +24,9 @@ internal ListBuilder(int size)
                 .CreateClassProxy(typeof (TBuilder), new ProxyGenerationOptions(new EnsureAllMethodsVirtual()), new ListBuilderInterceptor<TObject, TBuilder>(this));
             BuilderProxy.ListBuilder = this;
             _list = new List<TBuilder>();
+            var fixture = new AnonymousValueFixture();
             for (var i = 0; i < size; i++)
-                _list.Add(new TBuilder());
+                _list.Add(new TBuilder {Any = fixture});
         }
 
         internal TBuilder BuilderProxy { get; private set; }

NTestDataBuilder/TestDataBuilder.cs

@@ -29,7 +29,7 @@ protected TestDataBuilder()
         /// <summary>
         /// Generate anonymous data using this fixture - one instance per builder instance.
         /// </summary>
-        public AnonymousValueFixture Any { get; private set; }
+        public AnonymousValueFixture Any { get; internal set; }
 
         /// <summary>
         /// Build the object.