Adding a ctor-set readonly property to the MixedAccessibilityDto

robdmoore · robdmoore · commit 68810c97c6c4 · 2015-05-14T18:40:52.000+02:00
diff --git a/TestStack.Dossier.Tests/Factories/AllPropertiesFactoryTests.cs b/TestStack.Dossier.Tests/Factories/AllPropertiesFactoryTests.cs
@@ -13,15 +13,11 @@ public void GivenAllPropertiesFactory_WhenBuilding_ThenAllPropertiesSet()
         {
             MixedAccessibilityDto dto = Builder<MixedAccessibilityDto>.CreateNew(new AllPropertiesFactory());
 
-            // ctor properties
+            dto.SetByCtorNoPropertySetter.ShouldNotBe(null);
             dto.SetByCtorWithPrivateSetter.ShouldNotBe(null);
             dto.SetByCtorWithPublicSetter.ShouldNotBe(null);
-
-            // public properties
-            dto.NotSetByCtorWithPublicSetter.ShouldNotBe(null);
-
-            // private properties
             dto.NotSetByCtorWithPrivateSetter.ShouldNotBe(null);
+            dto.NotSetByCtorWithPublicSetter.ShouldNotBe(null);
         }
     }
 }
diff --git a/TestStack.Dossier.Tests/Factories/AutoFixtureFactoryTests.cs b/TestStack.Dossier.Tests/Factories/AutoFixtureFactoryTests.cs
@@ -13,6 +13,7 @@ public void GivenAutoFixtureFactory_WhenBuilding_ThenOnlyConstructorAndPublicPro
         {
             MixedAccessibilityDto dto = Builder<MixedAccessibilityDto>.CreateNew(new AutoFixtureFactory());
 
+            dto.SetByCtorNoPropertySetter.ShouldNotBe(null);
             dto.SetByCtorWithPrivateSetter.ShouldNotBe(null);
             dto.SetByCtorWithPublicSetter.ShouldNotBe(null);
             dto.NotSetByCtorWithPrivateSetter.ShouldBe(null);
@@ -24,11 +25,13 @@ public void GivenAutoFixtureFactoryAgainstBuilderWithModifications_WhenBuilding_
         {
             MixedAccessibilityDto dto = Builder<MixedAccessibilityDto>
                 .CreateNew(new AutoFixtureFactory())
+                .Set(x => x.SetByCtorNoPropertySetter, "0")
                 .Set(x => x.SetByCtorWithPrivateSetter, "1")
                 .Set(x => x.SetByCtorWithPublicSetter, "2")
                 .Set(x => x.NotSetByCtorWithPrivateSetter, "3")
                 .Set(x => x.NotSetByCtorWithPublicSetter, "4");
 
+            dto.SetByCtorNoPropertySetter.ShouldNotBe("0");
             dto.SetByCtorWithPrivateSetter.ShouldNotBe("1");
             dto.SetByCtorWithPublicSetter.ShouldNotBe("2");
             dto.NotSetByCtorWithPrivateSetter.ShouldNotBe("3");
diff --git a/TestStack.Dossier.Tests/Factories/CallConstructorFactoryTests.cs b/TestStack.Dossier.Tests/Factories/CallConstructorFactoryTests.cs
@@ -13,15 +13,11 @@ public void GivenConstructorFactory_WhenBuilding_ThenOnlyConstructorPropertiesSe
         {
             MixedAccessibilityDto dto = Builder<MixedAccessibilityDto>.CreateNew(new CallConstructorFactory());
 
-            // ctor properties
+            dto.SetByCtorNoPropertySetter.ShouldNotBe(null);
             dto.SetByCtorWithPrivateSetter.ShouldNotBe(null);
             dto.SetByCtorWithPublicSetter.ShouldNotBe(null);
-
-            // public properties
-            dto.NotSetByCtorWithPublicSetter.ShouldBe(null);
-
-            // private properties
             dto.NotSetByCtorWithPrivateSetter.ShouldBe(null);
+            dto.NotSetByCtorWithPublicSetter.ShouldBe(null);
         }
     }
 }
diff --git a/TestStack.Dossier.Tests/Factories/PublicPropertySettersFactoryTests.cs b/TestStack.Dossier.Tests/Factories/PublicPropertySettersFactoryTests.cs
@@ -10,17 +10,13 @@ public class PublicPropertySettersFactoryTests
         [Fact]
         public void GivenPublicPropertiesFactory_WhenBuilding_ThenOnlyConstructorAndPublicPropertiesSet()
         {
-            MixedAccessibilityDto instructor = Builder<MixedAccessibilityDto>.CreateNew(new PublicPropertySettersFactory());
+            MixedAccessibilityDto dto = Builder<MixedAccessibilityDto>.CreateNew(new PublicPropertySettersFactory());
 
-            // ctor properties
-            instructor.SetByCtorWithPrivateSetter.ShouldNotBe(null);
-            instructor.SetByCtorWithPublicSetter.ShouldNotBe(null);
-            
-            // public properties
-            instructor.NotSetByCtorWithPublicSetter.ShouldNotBe(null);
-
-            // private properties
-            instructor.NotSetByCtorWithPrivateSetter.ShouldBe(null);
+            dto.SetByCtorNoPropertySetter.ShouldNotBe(null);
+            dto.SetByCtorWithPrivateSetter.ShouldNotBe(null);
+            dto.SetByCtorWithPublicSetter.ShouldNotBe(null);
+            dto.NotSetByCtorWithPublicSetter.ShouldNotBe(null);
+            dto.NotSetByCtorWithPrivateSetter.ShouldBe(null);
         }
     }
 }
diff --git a/TestStack.Dossier.Tests/TestHelpers/Objects/Examples/MixedAccessibilityDto.cs b/TestStack.Dossier.Tests/TestHelpers/Objects/Examples/MixedAccessibilityDto.cs
@@ -2,10 +2,13 @@
 {
     public class MixedAccessibilityDto
     {
-        public MixedAccessibilityDto(string setByCtorWithPrivateSetter, string setByCtorWithPublicSetter)
+        private readonly string _setByCtorNoPropertySetter;
+
+        public MixedAccessibilityDto(string setByCtorWithPrivateSetter, string setByCtorWithPublicSetter, string setByCtorNoPropertySetter)
         {
             SetByCtorWithPrivateSetter = setByCtorWithPrivateSetter;
             SetByCtorWithPublicSetter = setByCtorWithPublicSetter;
+            _setByCtorNoPropertySetter = setByCtorNoPropertySetter;
         }
 
         public string SetByCtorWithPrivateSetter { get; private set; }
@@ -15,9 +18,9 @@ public MixedAccessibilityDto(string setByCtorWithPrivateSetter, string setByCtor
         public string NotSetByCtorWithPrivateSetter { get; private set; }
         public string NotSetByCtorWithPublicSetter { get; set; }
 
-        public string CalculatedProperty
+        public string SetByCtorNoPropertySetter
         {
-            get { return SetByCtorWithPrivateSetter + " " + SetByCtorWithPublicSetter; }
+            get { return _setByCtorNoPropertySetter; }
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -13,15 +13,11 @@ public void GivenAllPropertiesFactory_WhenBuilding_ThenAllPropertiesSet()`
`13`	`13`	`{`
`14`	`14`	`MixedAccessibilityDto dto = Builder<MixedAccessibilityDto>.CreateNew(new AllPropertiesFactory());`
`15`	`15`
`16`		`- // ctor properties`
	`16`	`+ dto.SetByCtorNoPropertySetter.ShouldNotBe(null);`
`17`	`17`	`dto.SetByCtorWithPrivateSetter.ShouldNotBe(null);`
`18`	`18`	`dto.SetByCtorWithPublicSetter.ShouldNotBe(null);`
`19`		`-`
`20`		`- // public properties`
`21`		`- dto.NotSetByCtorWithPublicSetter.ShouldNotBe(null);`
`22`		`-`
`23`		`- // private properties`
`24`	`19`	`dto.NotSetByCtorWithPrivateSetter.ShouldNotBe(null);`
	`20`	`+ dto.NotSetByCtorWithPublicSetter.ShouldNotBe(null);`
`25`	`21`	`}`
`26`	`22`	`}`
`27`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,15 +13,11 @@ public void GivenConstructorFactory_WhenBuilding_ThenOnlyConstructorPropertiesSe`
`13`	`13`	`{`
`14`	`14`	`MixedAccessibilityDto dto = Builder<MixedAccessibilityDto>.CreateNew(new CallConstructorFactory());`
`15`	`15`
`16`		`- // ctor properties`
	`16`	`+ dto.SetByCtorNoPropertySetter.ShouldNotBe(null);`
`17`	`17`	`dto.SetByCtorWithPrivateSetter.ShouldNotBe(null);`
`18`	`18`	`dto.SetByCtorWithPublicSetter.ShouldNotBe(null);`
`19`		`-`
`20`		`- // public properties`
`21`		`- dto.NotSetByCtorWithPublicSetter.ShouldBe(null);`
`22`		`-`
`23`		`- // private properties`
`24`	`19`	`dto.NotSetByCtorWithPrivateSetter.ShouldBe(null);`
	`20`	`+ dto.NotSetByCtorWithPublicSetter.ShouldBe(null);`
`25`	`21`	`}`
`26`	`22`	`}`
`27`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,17 +10,13 @@ public class PublicPropertySettersFactoryTests`
`10`	`10`	`[Fact]`
`11`	`11`	`public void GivenPublicPropertiesFactory_WhenBuilding_ThenOnlyConstructorAndPublicPropertiesSet()`
`12`	`12`	`{`
`13`		`- MixedAccessibilityDto instructor = Builder<MixedAccessibilityDto>.CreateNew(new PublicPropertySettersFactory());`
	`13`	`+ MixedAccessibilityDto dto = Builder<MixedAccessibilityDto>.CreateNew(new PublicPropertySettersFactory());`
`14`	`14`
`15`		`- // ctor properties`
`16`		`- instructor.SetByCtorWithPrivateSetter.ShouldNotBe(null);`
`17`		`- instructor.SetByCtorWithPublicSetter.ShouldNotBe(null);`
`18`		`-`
`19`		`- // public properties`
`20`		`- instructor.NotSetByCtorWithPublicSetter.ShouldNotBe(null);`
`21`		`-`
`22`		`- // private properties`
`23`		`- instructor.NotSetByCtorWithPrivateSetter.ShouldBe(null);`
	`15`	`+ dto.SetByCtorNoPropertySetter.ShouldNotBe(null);`
	`16`	`+ dto.SetByCtorWithPrivateSetter.ShouldNotBe(null);`
	`17`	`+ dto.SetByCtorWithPublicSetter.ShouldNotBe(null);`
	`18`	`+ dto.NotSetByCtorWithPublicSetter.ShouldNotBe(null);`
	`19`	`+ dto.NotSetByCtorWithPrivateSetter.ShouldBe(null);`
`24`	`20`	`}`
`25`	`21`	`}`
`26`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,10 +2,13 @@`
`2`	`2`	`{`
`3`	`3`	`public class MixedAccessibilityDto`
`4`	`4`	`{`
`5`		`- public MixedAccessibilityDto(string setByCtorWithPrivateSetter, string setByCtorWithPublicSetter)`
	`5`	`+ private readonly string _setByCtorNoPropertySetter;`
	`6`	`+`
	`7`	`+ public MixedAccessibilityDto(string setByCtorWithPrivateSetter, string setByCtorWithPublicSetter, string setByCtorNoPropertySetter)`
`6`	`8`	`{`
`7`	`9`	`SetByCtorWithPrivateSetter = setByCtorWithPrivateSetter;`
`8`	`10`	`SetByCtorWithPublicSetter = setByCtorWithPublicSetter;`
	`11`	`+ _setByCtorNoPropertySetter = setByCtorNoPropertySetter;`
`9`	`12`	`}`
`10`	`13`
`11`	`14`	`public string SetByCtorWithPrivateSetter { get; private set; }`
`@@ -15,9 +18,9 @@ public MixedAccessibilityDto(string setByCtorWithPrivateSetter, string setByCtor`
`15`	`18`	`public string NotSetByCtorWithPrivateSetter { get; private set; }`
`16`	`19`	`public string NotSetByCtorWithPublicSetter { get; set; }`
`17`	`20`
`18`		`- public string CalculatedProperty`
	`21`	`+ public string SetByCtorNoPropertySetter`
`19`	`22`	`{`
`20`		`- get { return SetByCtorWithPrivateSetter + " " + SetByCtorWithPublicSetter; }`
	`23`	`+ get { return _setByCtorNoPropertySetter; }`
`21`	`24`	`}`
`22`	`25`	`}`
`23`	`26`	`}`