Moved new tests to a more appropriate place with a more appropriate type

(you typically wouldn't use Set for a domain object builder)

Author: robdmoore

TestStack.Dossier.Tests/BuildTests.cs

@@ -48,32 +48,6 @@ public void GivenBuilder_WhenCallingSetExplicitly_ShouldOverrideValues()
             customer.YearJoined.ShouldBe(2014);
         }
 
-        [Fact]
-        public void GivenBuilder_WhenCallingSetWithLambda_ShouldInvokeEachTime()
-        {
-            int counter = 2014;
-            var builder = new CustomerBuilder()
-                .Set(x => x.FirstName, "Pi")
-                .Set(x => x.LastName, "Lanningham")
-                .Set(x => x.YearJoined, () => counter++);
-
-            var customerA = builder.Build();
-            var customerB = builder.Build();
-
-            customerA.YearJoined.ShouldBe(2014);
-            customerB.YearJoined.ShouldBe(2015);
-
-            List<Customer> customerList = CustomerBuilder.CreateListOfSize(10)
-                                            .All()
-                                                .Set(x => x.YearJoined, () => counter++);
-            int newCounter = 2016;
-            foreach (var c in customerList)
-            {
-                c.YearJoined.ShouldBe(newCounter++);
-            }
-
-        }
-
         [Fact]
         public void GivenBasicBuilder_WhenCallingBuildImplicitly_ThenReturnAnObject()
         {

TestStack.Dossier.Tests/Builder_CreateListTests.cs

@@ -170,7 +170,7 @@ public void WhenBuildingObjectsImplicitly_ThenTheAnonymousValueFixtureIsSharedAc
             studentViewModels.Select(x => x.Grade).ShouldBeUnique();
         }
 
-        public void WhenBuildingObjectsWithCtorAndPrivateSetters_ShouldSetPrivateSettersByDefault()
+        public void WhenBuildingObjectsWithCtorAndPrivateSetters_ThenSetPrivateSettersByDefault()
         {
             var dto = Builder<MixedAccessibilityDto>.CreateListOfSize(1)
                 .TheFirst(1)
@@ -188,7 +188,7 @@ public void WhenBuildingObjectsWithCtorAndPrivateSetters_ShouldSetPrivateSetters
         }
 
         [Fact]
-        public void GivenBuilderListWithFactoryOverride_WhenBuildingObjects_ShouldRespectOverriddenFactory()
+        public void GivenBuilderListWithFactoryOverride_WhenBuildingObjects_ThenRespectOverriddenFactory()
         {
             var dto = Builder<MixedAccessibilityDto>.CreateListOfSize(1, new CallConstructorFactory())
                 .TheFirst(1)
@@ -204,5 +204,18 @@ public void GivenBuilderListWithFactoryOverride_WhenBuildingObjects_ShouldRespec
             dto.NotSetByCtorWithPrivateSetter.ShouldNotBe("3");
             dto.NotSetByCtorWithPublicSetter.ShouldNotBe("4");
         }
+
+        [Fact]
+        public void GivenBuilder_WhenCallingSetWithLambda_ThenInvokeEachTime()
+        {
+            var grade = Grade.A;
+            var customers = Builder<StudentViewModel>.CreateListOfSize(10)
+                .All().Set(x => x.Grade, () => grade++)
+                .BuildList();
+
+            var gradeAssertion = Grade.A;
+            foreach (var c in customers)
+                c.Grade.ShouldBe(gradeAssertion++);
+        }
     }
 }

TestStack.Dossier.Tests/Builder_CreateNewTests.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using Shouldly;
 using TestStack.Dossier.Factories;
 using TestStack.Dossier.Tests.TestHelpers.Objects.Examples;
@@ -29,7 +30,7 @@ public void GivenBuilder_WhenCallingBuildImplicitly_ThenReturnAnObject()
         }
 
         [Fact]
-        public void GivenBuilderWithModifications_WhenCallingBuildExplicitly_ShouldOverrideValues()
+        public void GivenBuilderWithModifications_WhenCallingBuildExplicitly_ThenOverrideValues()
         {
             var builder = Builder<StudentViewModel>.CreateNew()
                 .Set(x => x.FirstName, "Pi")
@@ -44,7 +45,7 @@ public void GivenBuilderWithModifications_WhenCallingBuildExplicitly_ShouldOverr
         }
 
         [Fact]
-        public void GivenBuilderWithModifications_WhenCallingBuildImplicitly_ShouldOverrideValues()
+        public void GivenBuilderWithModifications_WhenCallingBuildImplicitly_ThenOverrideValues()
         {
             StudentViewModel vm = Builder<StudentViewModel>.CreateNew()
                 .Set(x => x.FirstName, "Pi")
@@ -57,7 +58,7 @@ public void GivenBuilderWithModifications_WhenCallingBuildImplicitly_ShouldOverr
         }
 
         [Fact]
-        public void GivenBuilder_WhenBuildingObjectWithCtorAndPrivateSetters_ShouldSetPrivateSettersByDefault()
+        public void GivenBuilder_WhenBuildingObjectWithCtorAndPrivateSetters_ThenSetPrivateSettersByDefault()
         {
             MixedAccessibilityDto dto = Builder<MixedAccessibilityDto>.CreateNew()
                 .Set(x => x.SetByCtorWithPublicSetter, "1")
@@ -72,7 +73,7 @@ public void GivenBuilder_WhenBuildingObjectWithCtorAndPrivateSetters_ShouldSetPr
         }
 
         [Fact]
-        public void GivenBuilderWithFactoryOverride_WhenBuildingObject_ShouldRespectOverriddenFactory()
+        public void GivenBuilderWithFactoryOverride_WhenBuildingObject_ThenRespectOverriddenFactory()
         {
             MixedAccessibilityDto dto = Builder<MixedAccessibilityDto>.CreateNew(new CallConstructorFactory())
                 .Set(x => x.SetByCtorWithPublicSetter, "1")
@@ -85,5 +86,21 @@ public void GivenBuilderWithFactoryOverride_WhenBuildingObject_ShouldRespectOver
             dto.NotSetByCtorWithPrivateSetter.ShouldNotBe("3");
             dto.NotSetByCtorWithPublicSetter.ShouldNotBe("4");
         }
+
+        [Fact]
+        public void GivenBuilder_WhenCallingSetWithLambda_ThenInvokeEachTime()
+        {
+            var grade = Grade.A;
+            var builder = Builder<StudentViewModel>.CreateNew()
+                .Set(x => x.FirstName, "Pi")
+                .Set(x => x.LastName, "Lanningham")
+                .Set(x => x.Grade, () => grade++);
+
+            var customerA = builder.Build();
+            var customerB = builder.Build();
+
+            customerA.Grade.ShouldBe(Grade.A);
+            customerB.Grade.ShouldBe(Grade.B);
+        }
     }
 }