Skip to content

Commit 6df127c

Browse files
committed
Updated version and documented breaking change.
1 parent 7484d73 commit 6df127c

File tree

2 files changed

+27
-1
lines changed

2 files changed

+27
-1
lines changed

BREAKING_CHANGES.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# Version 2.0.0
2+
3+
## ShouldRenderFileStream Method
4+
5+
The following overload of the `ShouldRenderFile` method has been *replaced*:
6+
7+
public FileStreamResult ShouldRenderFileStream(string contentType = null)
8+
9+
I place emphasis on the word "replace" because it is important to note that this overload has not been removed but replaced - this means that you will not encounter a compile-time error but you will encounter a logical error when you run the test.
10+
11+
### Reason
12+
13+
The aforementioned overload has been replaced in order to enable an overload that takes an actual stream for comparison in a way that is consistent with the existing convention.
14+
15+
### Fix
16+
17+
Use a [named argument](http://msdn.microsoft.com/en-gb/library/dd264739.aspx).
18+
19+
As where you would have previously done this:
20+
21+
.ShouldRenderFileStream("application/json");
22+
23+
You must now do this:
24+
25+
.ShouldRenderFileStream(contentType: "application/json");
26+

NextVersion.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.1.0
1+
2.0.0

0 commit comments

Comments
 (0)