Removed ShouldRenderFile and documented breaking change.

Author: AlexArchive

BREAKING_CHANGES.md

@@ -18,9 +18,27 @@ Use a [named argument](http://msdn.microsoft.com/en-gb/library/dd264739.aspx).
 
 As where you would have previously done this:
 
-    .ShouldRenderFileStream("application/json");
+    ShouldRenderFileStream("application/json");
 
 You must now do this: 
 
-    .ShouldRenderFileStream(contentType: "application/json");
+    ShouldRenderFileStream(contentType: "application/json");
+    
+    
+## ShouldRenderFileMethod
+
+The `ShouldRenderFile` method has been removed.
+
+### Reason
+
+The `ShouldRenderFile` method was equivocal because it had the possibility to be interperted to test for a `FileResult` when in fact, it tested for a `FileContentResult`. 
+
+It is for this reason that we introduced two unequivocal methods namely, `ShouldRenderAnyFile` and `ShouldRenderFileContents`.
+
+### Fix
+
+Use the `ShouldRenderFileContents` method instead: 
+
+    ShouldRenderAnyFile()
+    ShouldRenderAnyFile(contentType: "application/json")
 

TestStack.FluentMVCTesting.Tests/ControllerResultTestTests.cs

@@ -28,8 +28,6 @@ class ControllerResultTestShould
             ReturnType<ViewResult>(t => t.ShouldRenderDefaultView()),
             ReturnType<PartialViewResult>(t => t.ShouldRenderPartialView("")),
             ReturnType<PartialViewResult>(t => t.ShouldRenderDefaultPartialView()),
-            ReturnType<FileContentResult>(t => t.ShouldRenderFile()),
-            ReturnType<FileContentResult>(t => t.ShouldRenderFile("")),
             ReturnType<FileContentResult>(t => t.ShouldRenderFileContents()),
             ReturnType<FileContentResult>(t => t.ShouldRenderFileContents(new byte[0])),
             ReturnType<FileContentResult>(t => t.ShouldRenderFileContents(new byte[0], "")),
@@ -479,18 +477,6 @@ public void Check_for_file_content_result_and_check_textual_content_using_invali
                 _controller.WithCallTo(c => c.TextualFile()).ShouldRenderFileContents(ControllerResultTestController.TextualFileContent, ControllerResultTestController.FileContentType, Encoding.BigEndianUnicode));
         }
 
-        [Test]
-        public void Check_for_file_result()
-        {
-            _controller.WithCallTo(c => c.EmptyFile()).ShouldRenderFile();
-        }
-
-        [Test]
-        public void Check_for_file_result_and_check_content_type()
-        {
-            _controller.WithCallTo(c => c.EmptyFile()).ShouldRenderFile(ControllerResultTestController.FileContentType);
-        }
-
         [Test]
         public void Check_for_file_stream_result()
         {

TestStack.FluentMvcTesting/ControllerResultTest.cs

@@ -278,21 +278,6 @@ public FileContentResult ShouldRenderFileContents(string contents, string conten
             return fileResult;
         }
 
-        [Obsolete("Obsolete: Use ShouldRenderFileContents instead.")]
-        public FileContentResult ShouldRenderFile(string contentType = null)
-        {
-            ValidateActionReturnType<FileContentResult>();
-
-            var fileResult = (FileContentResult)_actionResult;
-
-            if (contentType != null && fileResult.ContentType != contentType)
-            {
-                throw new ActionResultAssertionException(string.Format("Expected file to be of content type '{0}', but instead was given '{1}'.", contentType, fileResult.ContentType));
-            }
-
-            return fileResult;
-        }
-
         public FileStreamResult ShouldRenderFileStream(byte[] content, string contentType = null)
         {
             return ShouldRenderFileStream(new MemoryStream(content), contentType);